Build failed in Jenkins: commons-csv #17

2016-07-30 Thread Apache Jenkins Server
See Changes: [ggregory] [CSV-192] Add convenience API CSVParser.parse(Path, Charset, CSVFormat). [ggregory] [CSV-192] Add convenience API CSVParser.parse(Path, Charset, CSVFormat). [ggregory] Javadocs. [ggregory] Sort method.

Re: commons-csv git commit: [CSV-189] CSVParser: Add factory method accepting InputStream.

2016-07-30 Thread Gary Gregory
Nope, not both, fixed as you suggested which matches the ticket title anyway. Gary On Sat, Jul 30, 2016 at 12:16 PM, Gary Gregory wrote: > Sure, or provide both? > > Gary > > On Jul 30, 2016 11:13 AM, "Benedikt Ritter" wrote: > >> I think it would

[VOTE] Release DBCP 2.2 based on RC1

2016-07-30 Thread Matt Sicker
We have fixed quite aWe have fixed quite a few bugs and added some significant enhancements since DBCP 2.1.1 was released, so I would like to release DBCP 2.2. This is my first release on Apache Commons, so please take a close look at everything as it's been almost two years since I've been an RM

Re: [DBCP] Working on 2.2 RC1

2016-07-30 Thread Matt Sicker
https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-12357 I'd be ok with putting it on GitHub like we did for the last log4j release, but I wasn't sure if Commons allowed that. On 30 July 2016 at 16:49, Gary Gregory wrote: > It's OK to publish the RC site

Re: [DBCP] Working on 2.2 RC1

2016-07-30 Thread Gary Gregory
It's OK to publish the RC site elsewhere IMO. Gary On Jul 30, 2016 2:45 PM, "Matt Sicker" wrote: > Well, I still can't use sftp to connect, nor Filezilla. I'll try asking > infra. > > On 30 July 2016 at 11:33, Gary Gregory wrote: > > > I do not think

Re: [DBCP] Working on 2.2 RC1

2016-07-30 Thread Matt Sicker
Well, I still can't use sftp to connect, nor Filezilla. I'll try asking infra. On 30 July 2016 at 11:33, Gary Gregory wrote: > I do not think it takes long at all. > > G. > > On Jul 29, 2016 9:22 PM, "Matt Sicker" wrote: > > > I added a new ssh key to

[VOTE] Release Configuration 2.1 based on RC2

2016-07-30 Thread Oliver Heger
Hi all, after the failed vote for RC1 a new RC has been created. The only difference is that the checkstyle plugin has been downgraded which should allow building the project on Java 1.6. Configuration 2.1 RC2 is available for review here:

Jenkins build is back to normal : commons-csv #16

2016-07-30 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

2016-07-30 Thread Rob Tompkins
> On Jul 30, 2016, at 12:41 PM, Gary Gregory wrote: > > Can this all be solved with better Javadocs? > I don’t think so. So, I would think that we would do one of two things: (1) Clarify Javadocs, and set up unit tests to reflect the intent (that being that

Re: commons-csv git commit: [CSV-189] CSVParser: Add factory method accepting InputStream.

2016-07-30 Thread Gary Gregory
Sure, or provide both? Gary On Jul 30, 2016 11:13 AM, "Benedikt Ritter" wrote: > I think it would be better to use a Charset object as parameter instead of > a String. > > WDYT? > > schrieb am Sa., 30. Juli 2016 um 19:57: > > > Repository: commons-csv

Build failed in Jenkins: commons-csv #15

2016-07-30 Thread Apache Jenkins Server
See Changes: [ggregory] [CSV-189] CSVParser: Add factory method accepting InputStream. [ggregory] Javadocs. [ggregory] Javadocs. [ggregory] Sort static methods. [ggregory] Add missing JIRA IDs. [ggregory] [CSV-192] Add convenience API

Re: commons-csv git commit: [CSV-189] CSVParser: Add factory method accepting InputStream.

2016-07-30 Thread Benedikt Ritter
I think it would be better to use a Charset object as parameter instead of a String. WDYT? schrieb am Sa., 30. Juli 2016 um 19:57: > Repository: commons-csv > Updated Branches: > refs/heads/master 0d7c984c6 -> ac46f73b2 > > > [CSV-189] CSVParser: Add factory method

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

2016-07-30 Thread Gary Gregory
Can this all be solved with better Javadocs? Gary On Jul 29, 2016 7:59 AM, "Rob Tompkins" wrote: > Hi Benedikt, > > Thanks for the insights here. > > > On Jul 29, 2016, at 3:53 AM, Benedikt Ritter wrote: > > > > Hello Rob, > > > > Rob Tompkins

Re: [DBCP] Working on 2.2 RC1

2016-07-30 Thread Gary Gregory
I do not think it takes long at all. G. On Jul 29, 2016 9:22 PM, "Matt Sicker" wrote: > I added a new ssh key to id.apache.org (forgot to do that), not sure how > long it takes to take effect. > > On 29 July 2016 at 22:25, Gary Gregory wrote: > > >