Re: Enable travis-ci for commons-io?

2016-11-08 Thread Pascal Schumacher
went ahead and created the infra-ticket: https://issues.apache.org/jira/browse/INFRA-12874 Am 08.11.2016 um 19:45 schrieb Benedikt Ritter: Pascal Schumacher schrieb am Di., 8. Nov. 2016 um 08:34 Uhr: Hello everybody, what about enabling travis-ci for commons-io,

Re: commons-io git repository write access

2016-11-08 Thread Benedikt Ritter
sebb schrieb am Di., 8. Nov. 2016 um 20:23 Uhr: > Sorry, am I missing something here? > > If/when a Commons component moves to Git, we just need to ensure that > the correct karma settings are requested at the time. > That does not seem like a big overhead for Commons or Infra.

Re: [Text] Any reason to not upgrade to lang 3.5

2016-11-08 Thread Bruno P. Kinoshita
Yesterday I had a look while fixing Checkstyle and PMD issues, and noticed the StringUtils in HumanNameParser. + to remove and use a simple if null or empty string. Cheers Bruno > > From: Rob Tompkins >To: Commons Developers List

Re: commons-io git repository write access

2016-11-08 Thread sebb
Sorry, am I missing something here? If/when a Commons component moves to Git, we just need to ensure that the correct karma settings are requested at the time. That does not seem like a big overhead for Commons or Infra. On 8 November 2016 at 19:11, Gary Gregory wrote:

Re: commons-io git repository write access

2016-11-08 Thread Gary Gregory
On Tue, Nov 8, 2016 at 10:47 AM, Benedikt Ritter wrote: > Gary Gregory schrieb am Di., 8. Nov. 2016 um > 08:48 Uhr: > > > On Mon, Nov 7, 2016 at 11:29 PM, Pascal Schumacher < > > pascalschumac...@gmx.net > > > wrote: > > > > > quoting Chris Lambertus

[GitHub] commons-io pull request #24: [IO-516] fixed line endings for source files an...

2016-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-io/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC2

2016-11-08 Thread Gary Gregory
On Tue, Nov 8, 2016 at 9:36 AM, Thomas Vandahl wrote: > On 08.11.16 10:26, sebb wrote: > > Alpha should be used for unstable API > > Beta would be for unstable Behaviour (i.e. implementation) > > That is exactly what happened. JCS actually has only 3 public API > classes, JCS,

Re: commons-io git repository write access

2016-11-08 Thread Benedikt Ritter
Gary Gregory schrieb am Di., 8. Nov. 2016 um 08:48 Uhr: > On Mon, Nov 7, 2016 at 11:29 PM, Pascal Schumacher < > pascalschumac...@gmx.net > > wrote: > > > quoting Chris Lambertus from the ticket: > > > > This needs to be requested on a per-repo basis, as it is not part of

Re: Enable travis-ci for commons-io?

2016-11-08 Thread Benedikt Ritter
Pascal Schumacher schrieb am Di., 8. Nov. 2016 um 08:34 Uhr: > Hello everybody, > > what about enabling travis-ci for commons-io, so that pull requests are > tested automatically? > > I'm willing to do the work if everybody is o.k. with this. > Go for it! > > Thanks,

Re: [TEXT] Add a duration parser, using donated code from gunip

2016-11-08 Thread Benedikt Ritter
Hi, is this about java.util.time.Duration ?! Regards, Benedikt Matt Benson schrieb am Di., 8. Nov. 2016 um 15:21 Uhr: > TBH I think we need a software grant agreement (SGA) executed for this, > regardless of license. Any other opinions? > > Matt > > On Nov 8, 2016 8:16 AM,

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC2

2016-11-08 Thread Thomas Vandahl
On 08.11.16 10:26, sebb wrote: > Alpha should be used for unstable API > Beta would be for unstable Behaviour (i.e. implementation) That is exactly what happened. JCS actually has only 3 public API classes, JCS, CacheAccess and CacheGroupAccess. These have been redesigned for the step from 1.3 to

Re: [Text] Any reason to not upgrade to lang 3.5

2016-11-08 Thread Gary Gregory
I would be OK with a direct dependency because in my mind [text] is a higher level component. Gary On Nov 8, 2016 6:38 AM, "Rob Tompkins" wrote: > > > On Nov 7, 2016, at 10:23 PM, Bruno P. Kinoshita < > brunodepau...@yahoo.com.br.INVALID> wrote: > > > > +1 to update away >

Re: [Text] Any reason to not upgrade to lang 3.5

2016-11-08 Thread Jörg Schaible
Rob Tompkins wrote: > > >> On Nov 8, 2016, at 9:38 AM, Rob Tompkins wrote: >> >> >>> On Nov 7, 2016, at 10:23 PM, Bruno P. Kinoshita >>> wrote: >>> >>> +1 to update away >>> >>> I think it could be a mistake while creating the

Re: [Text] Any reason to not upgrade to lang 3.5

2016-11-08 Thread Rob Tompkins
> On Nov 8, 2016, at 9:38 AM, Rob Tompkins wrote: > > >> On Nov 7, 2016, at 10:23 PM, Bruno P. Kinoshita >> wrote: >> >> +1 to update away >> >> I think it could be a mistake while creating the initial project structure. >> Don't

Re: [Text] Any reason to not upgrade to lang 3.5

2016-11-08 Thread Rob Tompkins
> On Nov 7, 2016, at 10:23 PM, Bruno P. Kinoshita > wrote: > > +1 to update away > > I think it could be a mistake while creating the initial project structure. > Don't remember why there would be a dependency between [text] and [lang]. Do you want to

Re: [TEXT] Add a duration parser, using donated code from gunip

2016-11-08 Thread Matt Benson
TBH I think we need a software grant agreement (SGA) executed for this, regardless of license. Any other opinions? Matt On Nov 8, 2016 8:16 AM, "Jean Champémont" wrote: > Hi all, > > Yes, I confirm I'm OK to donate the code of gunip to the Apache commons > project. > >

Re: [TEXT] Add a duration parser, using donated code from gunip

2016-11-08 Thread Jean Champémont
Hi all, Yes, I confirm I'm OK to donate the code of gunip to the Apache commons project. If there is anything else I can do to help with the Commons Text component, tell me . Best regards, Jean Le Mar 08 nov 2016, à 10:37, Bruno P. Kinoshita a écrit : > Oh, forgot to add the link to the

Re: [TEXT] Add a duration parser, using donated code from gunip

2016-11-08 Thread Jean Champémont
(Sending this email again, as I think the first I sent earlier today was not sent to the list, because I was not a member of the list) Hi all, Yes, I confirm I'm OK to donate the code of gunip to the Apache commons project. If there is anything else I can do to help with the Commons Text

Re: [crypto] package access on ivars?

2016-11-08 Thread sebb
For vars that need to be accessed only within the package, there is the choice of package-protected variable or p-p getter/setter. The latter is simpler, and is my preference. The problem with methods is that in theory they are easier to deal with when maintaining API compat. Protected and

Re: [crypto] package access on ivars?

2016-11-08 Thread Stian Soiland-Reyes
Agree to change them to private. If there are particular fields that are always needed by a subclass, then it should be exposed as a protected method. (The class is then later free to make those on demand) On 8 November 2016 at 09:43, Gary Gregory wrote: > On Tue, Nov 8,

Re: [crypto] package access on ivars?

2016-11-08 Thread Gary Gregory
On Tue, Nov 8, 2016 at 1:40 AM, sebb wrote: > On 8 November 2016 at 09:30, Gary Gregory wrote: > > On Tue, Nov 8, 2016 at 1:19 AM, sebb wrote: > > > >> On 8 November 2016 at 07:34, Stian Soiland-Reyes > wrote: > >>

Re: [crypto] package access on ivars?

2016-11-08 Thread sebb
On 8 November 2016 at 09:30, Gary Gregory wrote: > On Tue, Nov 8, 2016 at 1:19 AM, sebb wrote: > >> On 8 November 2016 at 07:34, Stian Soiland-Reyes wrote: >> > I don't think binary compatibility should include package level access, >>

Re: [TEXT] Add a duration parser, using donated code from gunip

2016-11-08 Thread Bruno P. Kinoshita
Oh, forgot to add the link to the repository (just the most important part of the e-mail I suspect :) https://github.com/jchampemont/gunip Is indeed the right repository, and licensed under Apache 2.0 Bruno - Original Message - > From: Gary Gregory > To:

Re: [TEXT] Add a duration parser, using donated code from gunip

2016-11-08 Thread Gary Gregory
If it is this Gunip https://github.com/jchampemont/gunip, then it is already licensed as Apache 2.0. Gary On Tue, Nov 8, 2016 at 1:23 AM, Bruno P. Kinoshita < brunodepau...@yahoo.com.br.invalid> wrote: > Hi all, > > This is regarding TEXT-25 [1], for adding a Duration Parser to [text]. > >

Re: [crypto] package access on ivars?

2016-11-08 Thread Gary Gregory
On Tue, Nov 8, 2016 at 1:19 AM, sebb wrote: > On 8 November 2016 at 07:34, Stian Soiland-Reyes wrote: > > I don't think binary compatibility should include package level access, > as > > long as that package is only used within a single Commons JAR, then we >

[TEXT] Add a duration parser, using donated code from gunip

2016-11-08 Thread Bruno P. Kinoshita
Hi all, This is regarding TEXT-25 [1], for adding a Duration Parser to [text]. Gunip is a "Generic UNIt Parser" by Jean Champémont (CC'ed). It provides a parser capable of interpreting text such as 2 hours, 1 mn and 22sec And get the value in base unit, such as seconds 2 * 60 * 60 + 1 *

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC2

2016-11-08 Thread sebb
On 8 November 2016 at 07:14, Romain Manni-Bucau wrote: > Le 8 nov. 2016 07:25, "Gary Gregory" a écrit : >> >> On Sun, Nov 6, 2016 at 7:44 AM, Oliver Heger > >> wrote: >> >> > Hi, >> > >> > sorry, I don't want to stand

Re: Enable travis-ci for commons-io?

2016-11-08 Thread Stian Soiland-Reyes
Sounds great to me, particularly if it can test the pull requests! For testing with Java 8 on Travis you may need a little workaround, as on the default build slave you get a broken oldie jdk8 build: https://github.com/apache/incubator-commonsrdf/blob/master/.travis.yml On 8 Nov 2016 7:34 am,

Re: [crypto] package access on ivars?

2016-11-08 Thread sebb
On 8 November 2016 at 07:34, Stian Soiland-Reyes wrote: > I don't think binary compatibility should include package level access, as > long as that package is only used within a single Commons JAR, then we are > free to change those, at least in a new minor release. (I would say