On 31/10/17 14:44, Gary Gregory wrote:
> On Tue, Oct 31, 2017 at 8:33 AM, Matt Sicker wrote:
>
>> On 31 October 2017 at 04:21, Mark Thomas wrote:
>>>
>>> If the methods are required then that makes 2.4.3 broken in my view. In
>>> which case we should wait for 2.4.4 before updating the version DB
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/42
LGTM
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.
On Tue, Oct 31, 2017 at 8:33 AM, Matt Sicker wrote:
> On 31 October 2017 at 04:21, Mark Thomas wrote:
> >
> > If the methods are required then that makes 2.4.3 broken in my view. In
> > which case we should wait for 2.4.4 before updating the version DBCP
> > depends on. I don't think we should a
Please see the WIP in git master. Right now, we do not throw anything on
close().
Gary
On Tue, Oct 31, 2017 at 8:38 AM, Matt Sicker wrote:
> On 31 October 2017 at 04:42, Mark Thomas wrote:
> >
> > If we implement Closeable then we get AutoCloseable for free.
> >
>
> With an IOException as its
On 31 October 2017 at 04:42, Mark Thomas wrote:
>
> If we implement Closeable then we get AutoCloseable for free.
>
With an IOException as its throwable instead of a more generic Exception,
though of course, that can be overridden.
--
Matt Sicker
On 31 October 2017 at 04:21, Mark Thomas wrote:
>
> If the methods are required then that makes 2.4.3 broken in my view. In
> which case we should wait for 2.4.4 before updating the version DBCP
> depends on. I don't think we should adapt the test. The test is telling
> us something is broken. We
On 30 October 2017 at 23:09, Stephen Colebourne wrote:
> Does commons-logging need to be a full module with a module-info.java?
> Probably not at this point. Adding Automatic-Module-Name is probably
> sufficient. However, if someone wants to do the work, then adding
> module-info shouldn't be bloc
>So (if my assumptions about method names being required are true) I>think I am
>proposing:
>
>- fix pool
>- release pool 2.4.4
>- update DBCP to pool 2.4.4
>- release DBCP
+1 sounds like a good plan to me. Closed pull request (either way, the other
solution was to add back the previous behaviou
On 31/10/2017 00:49, Gary Gregory wrote:
> Hi All:
>
> Several [pool] interfaces implement close() but do not extend Closeable.
> Should they?
I'm tempted. close() is part of the ObjectPool interface so it isn't as
if we are adding new functionality.
My only concern is that the Javadoc for Close
On 31/10/2017 00:54, Gary Gregory wrote:
> On Sun, Oct 29, 2017 at 2:09 AM, Mark Thomas wrote:
>
>> On 29 October 2017 03:54:40 GMT+00:00, "Bruno P. Kinoshita" <
>> brunodepau...@yahoo.com.br.INVALID> wrote:
>>> Hi Gary,
>>>
>>> Started the tests in Maven command line, found which tests failed.
>
Github user christopher-johnson commented on the issue:
https://github.com/apache/commons-rdf/pull/42
CI error is currently noted by Travis as an [open
issue](https://www.traviscistatus.com/incidents/xgpn2tq6mx7k).
---
Github user kinow commented on the issue:
https://github.com/apache/commons-pool/pull/3
Done! Thanks @garydgregory !
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: d
Github user kinow closed the pull request at:
https://github.com/apache/commons-pool/pull/3
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
13 matches
Mail list logo
