Re: [4/4] commons-release-plugin git commit: (fix) ingnore hidden files in staging

2018-06-14 Thread Rob Tompkins
@Gary - should be able to stage from the plugin and have it commit again. -Rob > On Jun 14, 2018, at 2:26 PM, chtom...@apache.org wrote: > > (fix) ingnore hidden files in staging > > > Project: http://git-wip-us.apache.org/repos/asf/commons-release-plugin/repo > Commit: > http://git-wip-us.ap

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

2018-06-14 Thread Rob Tompkins
> On Jun 14, 2018, at 9:52 AM, Gary Gregory wrote: > > On Thu, Jun 14, 2018 at 7:44 AM Rob Tompkins wrote: > >> >> >>> On Jun 14, 2018, at 9:37 AM, Gary Gregory >> wrote: >>> >>> On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory >> wrote: >>> That is just a bug in the release plugin th

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

2018-06-14 Thread Gary Gregory
On Thu, Jun 14, 2018 at 7:44 AM Rob Tompkins wrote: > > > > On Jun 14, 2018, at 9:37 AM, Gary Gregory > wrote: > > > > On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory > wrote: > > > >> That is just a bug in the release plugin that generated the vote text: > it > >> printed null for the Maven quali

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

2018-06-14 Thread Rob Tompkins
> On Jun 14, 2018, at 9:37 AM, Gary Gregory wrote: > > On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory wrote: > >> That is just a bug in the release plugin that generated the vote text: it >> printed null for the Maven qualifier when there is none (like "bin" for >> some other files.) >> > >

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

2018-06-14 Thread Gary Gregory
On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory wrote: > That is just a bug in the release plugin that generated the vote text: it > printed null for the Maven qualifier when there is none (like "bin" for > some other files.) > IOW, my email text was wrong those file names should not have "-null".

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

2018-06-14 Thread Sergio Fernández
+1 (non-binding) On Wed, Jun 13, 2018, 12:51 Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.3.0 was released, so I would like to release > Apache Commons DBCP 2.4.0. > > Apache Commons DBCP 2.4.0 RC1 is available for rev

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

2018-06-14 Thread Gary Gregory
That is just a bug in the release plugin that generated the vote text: it printed null for the Maven qualifier when there is none (like "bin" for some other files.) Gary On Thu, Jun 14, 2018, 04:59 Emmanuel Bourg wrote: > Le 13/06/2018 à 21:51, Gary Gregory a écrit : > > > #Release SHA-1s > > c

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

2018-06-14 Thread Emmanuel Bourg
Le 13/06/2018 à 21:51, Gary Gregory a écrit : > #Release SHA-1s > commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef > commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735 Are these "null" files excepted? Emmanuel Bourg ---

Re: [VOTE] Release Apache Commons DBCP 2.4.0 based on RC1

2018-06-14 Thread Bruno P. Kinoshita
[ X ] +1 Release these artifacts Building OK from commit d7aa662fbbb99e536ae28c47d0c4e1d51e39d5b9 passing OK on Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2 Java version: 1.8.0_171, vendor: Oracle Corporation Java