Re: [VOTE] Release Apache Commons Text 1.5 based on RC3

2018-10-03 Thread Bruno P. Kinoshita
[ X ] +1 Release these artifacts Build passing with mvn clean test site on Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2 Java version: 1.8.0_172, vendor: Oracle Corporation Java home: /opt/jdk1.8.0_172/jre Default loc

Re: [VOTE] Release Apache Commons Text 1.5 based on RC3

2018-10-03 Thread Amey Jadiye
Checked RC3 of Commons Text 1.5, here is my +1 (non-binding). 1. Build and Tests look good. 2. Clirr looks good. 3. Rat is good. 4. Spotbug looks good. 5. Checkstyle is good. 6. Hashes look good. Checked on:- Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T00:03:14+05:30

[GitHub] commons-collections issue #55: COLLECTIONS-697 JavaDoc FixedSizeList should ...

2018-10-03 Thread grimreaper
Github user grimreaper commented on the issue: https://github.com/apache/commons-collections/pull/55 cool. Now we're waiting for INFRA-17094. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For addi

[GitHub] commons-collections issue #55: COLLECTIONS-697 JavaDoc FixedSizeList should ...

2018-10-03 Thread george-ranjan
Github user george-ranjan commented on the issue: https://github.com/apache/commons-collections/pull/55 @grimreaper fixed & pushed. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional comm

Re: [collection] how to commit to commons collections?

2018-10-03 Thread Eitan Adler
(please make sure to explicitly add me to the reply until the mailing list is fixed) On Wed, 3 Oct 2018 at 09:36, Gary Gregory wrote: > > Did you clone your repo like this: > > git clone https://git-wip-us.apache.org/repos/asf/commons-collections.git Yes. > I wonder if you're the proper LDAP g

Re: [collection] how to commit to commons collections?

2018-10-03 Thread Gary Gregory
Did you clone your repo like this: git clone https://git-wip-us.apache.org/repos/asf/commons-collections.git ? I wonder if you're the proper LDAP group to do this. If so, you might want to file an INFRA ticket. Gary On Wed, Oct 3, 2018 at 10:18 AM Eitan Adler wrote: > Someone submitted a r

[collection] how to commit to commons collections?

2018-10-03 Thread Eitan Adler
Someone submitted a reasonable PR which I massaged and was planning on committing. However I get this Counting objects: 19, done. Delta compression using up to 4 threads. Compressing objects: 100% (10/10), done. Writing objects: 100% (19/19), 3.40 KiB | 386.00 KiB/s, done. Total 19 (delta 6), reus

[GitHub] commons-rng issue #11: RNG-57: Cache values for nextBoolean() and nextInt()

2018-10-03 Thread aherbert
Github user aherbert commented on the issue: https://github.com/apache/commons-rng/pull/11 This failed. This is partly due to 'Too many failures ...' in the testing of the different providers. This is for code I have not touched as the tests are for IntProvider.nextInt() and LongProv

[GitHub] commons-rng pull request #11: RNG-57: Cache values for nextBoolean() and nex...

2018-10-03 Thread aherbert
GitHub user aherbert opened a pull request: https://github.com/apache/commons-rng/pull/11 RNG-57: Cache values for nextBoolean() and nextInt() AbstractIntProvider has been updated to cache a value for nextBoolean(). AbstractLongProvider has been updated to cache a value for

[GitHub] commons-collections pull request #55: COLLECTIONS-697 JavaDoc FixedSizeList ...

2018-10-03 Thread grimreaper
Github user grimreaper commented on a diff in the pull request: https://github.com/apache/commons-collections/pull/55#discussion_r64747 --- Diff: src/main/java/org/apache/commons/collections4/list/FixedSizeList.java --- @@ -31,6 +31,12 @@ * The add, remove, clear and reta

[GitHub] commons-collections pull request #55: COLLECTIONS-697 JavaDoc FixedSizeList ...

2018-10-03 Thread grimreaper
Github user grimreaper commented on a diff in the pull request: https://github.com/apache/commons-collections/pull/55#discussion_r64719 --- Diff: src/test/java/org/apache/commons/collections4/list/FixedSizeListTest.java --- @@ -66,4 +68,20 @@ public String getCompatibilityVersi

Re: [VOTE] Release Apache Commons Text 1.5 based on RC3

2018-10-03 Thread Eitan Adler
+1 (not binding) everything builds and works for me Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00) Maven home: /opt/local/share/java/maven3 Java version: 11, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home D