[GitHub] asciborek commented on a change in pull request #72: [IO-596] Add DeleteFiles utility class

2018-12-26 Thread GitBox
asciborek commented on a change in pull request #72: [IO-596] Add DeleteFiles utility class URL: https://github.com/apache/commons-io/pull/72#discussion_r244072727 ## File path: src/main/java/org/apache/commons/io/DeleteFiles.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to t

[GitHub] jvz commented on issue #72: [IO-596] Add DeleteFiles utility class

2018-12-26 Thread GitBox
jvz commented on issue #72: [IO-596] Add DeleteFiles utility class URL: https://github.com/apache/commons-io/pull/72#issuecomment-450040762 Note that the build is failing as there is currently an existing unit test that tests a non-existent method. -

Re: [IO] Robust file remover, other Windows-specific enhancements

2018-12-26 Thread Matt Sicker
https://github.com/apache/commons-io/pull/72 for the PR. On Sat, 22 Dec 2018 at 10:16, Gary Gregory wrote: > Nice :-) > > On Fri, Dec 21, 2018, 11:11 Matt Sicker > > I like that idea. I'll reorganize some code from the Jenkins PR into a > one > > for IO. > > > > On Fri, 21 Dec 2018 at 11:51, Ga

[GitHub] jvz opened a new pull request #72: [IO-596] Add DeleteFiles utility class

2018-12-26 Thread GitBox
jvz opened a new pull request #72: [IO-596] Add DeleteFiles utility class URL: https://github.com/apache/commons-io/pull/72 This class provides configurable strategies to delete files and directories. Signed-off-by: Matt Sicker @reviewbybees @garydgregory @jeffret-b -

Re: [VOTE][RC2] Commons collections 4.3

2018-12-26 Thread Bruno P. Kinoshita
FWIW I had a similar experience, and realized I was doing `git fetch --all`, but it didn't bring the tags. `git fetch --tags` did the trick. After that I could `git checkout $tag-name` Cheers Bruno From: Gilles To: dev@commons.apache.org Sent: Thursday, 27

Re: [VOTE][RC2] Commons collections 4.3

2018-12-26 Thread Gilles
On Wed, 26 Dec 2018 21:21:34 +0100, Gilles wrote: Hi. On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote: This is a [VOTE] for releasing Apache Commons collections 4.3 Tag name: collections-4.3-RC2 (signature can be checked from git using 'git tag -v') $ git tag -v collections-

Re: [VOTE][RC2] Commons collections 4.3

2018-12-26 Thread Gilles
Hi. On Wed, 26 Dec 2018 20:41:59 +0700, Maxim Solodovnik wrote: This is a [VOTE] for releasing Apache Commons collections 4.3 Tag name: collections-4.3-RC2 (signature can be checked from git using 'git tag -v') $ git tag -v collections-4.3-RC2 error: tag 'collections-4.3-RC2' not found.

[VOTE][RC2] Commons collections 4.3

2018-12-26 Thread Maxim Solodovnik
This is a [VOTE] for releasing Apache Commons collections 4.3 Tag name: collections-4.3-RC2 (signature can be checked from git using 'git tag -v') RC1 was cancelled due to some release steps were not done Tag URL: https://gitbox.apache.org/repos/asf?p=commons-collections.git;a=commit;h=7

Re: [VOTE][RC1] Commons collections 4.3

2018-12-26 Thread Gilles
Hi. On Wed, 26 Dec 2018 08:23:03 +0700, Maxim Solodovnik wrote: This is the way Wicketstuff build is performed [1] The project consist of ~285 modules and it is wise to create tag only if build is already in Nexus :) [1] https://github.com/wicketstuff/core/wiki/Wicket-Stuff-Core-Release-Proc