Re: [Text, Lang] Matching two CharSequence instances

> On 3 Mar 2019, at 02:00, Bruno P. Kinoshita wrote: > > Hi Alex, > Also found the two implementations similar, but confusing. > - The parameter name inconsistency > +1 > > > - The edge case logic inconsistency > > +1 > > - Change to a stepwise charAt comparison > +1 if the behaviour is

[GitHub] kinow edited a comment on issue #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

kinow edited a comment on issue #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#issuecomment-467606333 Hi @ameyjadiye ! A new metric!  Added a few comments, but only spent a couple of minutes looking at the code. I will take

Re: [Text, Lang] Matching two CharSequence instances

Hi Alex, Also found the two implementations similar, but confusing. - The parameter name inconsistency +1 - The edge case logic inconsistency +1 - Change to a stepwise charAt comparison +1 if the behaviour is kept. Right now some crazy characters like those old latin letters are supported

Re: [Text, Lang] Matching two CharSequence instances

Having looked a bit more at StringUtils it appears that: public static boolean equals(final CharSequence cs1, final CharSequence cs2); public static boolean equalsIgnoreCase(final CharSequence str1, final CharSequence str2); share edge case logic checking but it is implemented differently

[GitHub] garydgregory merged pull request #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality.

garydgregory merged pull request #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality. URL: https://github.com/apache/commons-text/pull/105 This is an automated message from the Apache Git Service. To

[GitHub] chtompki commented on issue #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality.

chtompki commented on issue #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality. URL: https://github.com/apache/commons-text/pull/105#issuecomment-468962820 LGTM This is an automated message from the

[GitHub] coveralls commented on issue #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality.

coveralls commented on issue #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality. URL: https://github.com/apache/commons-text/pull/105#issuecomment-468961411 [](https://coveralls.io/builds/21949966)

[GitHub] aherbert opened a new pull request #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality.

aherbert opened a new pull request #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality. URL: https://github.com/apache/commons-text/pull/105 Comparing CharSequence using Object.equals will fail when the CharSequence implementation does not support this.

Re: [Text, Lang] Matching two CharSequence instances

> On 2 Mar 2019, at 16:59, Mark Dacek wrote: > > Is your proposed method a stepwise charAt comparison across both, assuming > non-null and equal length? Yes. Although the StringUtils.equals(CharSequence, CharSequence) from [lang] will do the job correctly (thanks Gary). It currently does all

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261841223 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

Re: [Text, Lang] Matching two CharSequence instances

Is your proposed method a stepwise charAt comparison across both, assuming non-null and equal length? Doesn't seem like a bad idea, though I'm curious whether there's a use-case where toString() on both and comparing isn't more expedient. On Sat, Mar 2, 2019 at 11:53 AM Alex Herbert wrote: > I

Re: [Text, Lang] Matching two CharSequence instances

See org.apache.commons.lang3.StringUtils.equals(CharSequence, CharSequence) Gary On Sat, Mar 2, 2019 at 11:53 AM Alex Herbert wrote: > I am helping with the PR for TEXT-126 to add to the similarity package. > > Part of the new algorithm requires identifying if two CharSequences are >

[Text, Lang] Matching two CharSequence instances

I am helping with the PR for TEXT-126 to add to the similarity package. Part of the new algorithm requires identifying if two CharSequences are identical. Is there a utility in Text to do something like this: public static boolean CharSequenceUtils.equals(CharSequence, CharSequence); I cannot

[GitHub] garydgregory commented on a change in pull request #5: optimize map columns 2 properties code

garydgregory commented on a change in pull request #5: optimize map columns 2 properties code URL: https://github.com/apache/commons-dbutils/pull/5#discussion_r261832711 ## File path: src/main/java/org/apache/commons/dbutils/BeanProcessor.java ## @@ -465,9 +465,6 @@

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261831169 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

Re: [ALL][RFC] Github subjects don't contain the repo name

> On Mar 2, 2019, at 3:39 AM, Stefan Bodewig wrote: > >> On 2019-03-01, sebb wrote: >> >> [GitHub] (commons-io) zsoltii opened a new pull request #74: Add new >> function: byteCountToDisplayRoundedSize > >> WDYT? > > I don't really care for the exact subject as long as the name of the >

Re: [ALL][RFC] Github subjects don't contain the repo name

Created https://issues.apache.org/jira/browse/INFRA-17940 On Sat, 2 Mar 2019 at 08:39, Stefan Bodewig wrote: > > On 2019-03-01, sebb wrote: > > > [GitHub] (commons-io) zsoltii opened a new pull request #74: Add new > > function: byteCountToDisplayRoundedSize > > > WDYT? > > I don't really care

Re: [ALL][RFC] Github subjects don't contain the repo name

On 2019-03-01, sebb wrote: > [GitHub] (commons-io) zsoltii opened a new pull request #74: Add new > function: byteCountToDisplayRoundedSize > WDYT? I don't really care for the exact subject as long as the name of the repo gets added :-) +1 Stefan

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261818800 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java