Re: [lang] immutable BitSet

2019-10-28 Thread Gilles Sadowski
Hello. 2019-10-29 0:16 UTC+01:00, Claude Warren : > Having "ImmutableBitSet" inherit from "BitSet" breaks the latter's > contract. >> >> > no more Yes, more, AFAICT... > so than the ImmutableSet breaks the Set contract. ... because "Set" is an interface whose contract explicitly mentions some

Re: [statistics-regression] Proposed Regression class/method structure

2019-10-28 Thread Eric Barnhill
On Mon, Oct 28, 2019 at 3:01 PM Gilles Sadowski wrote: > Hi Eric. > > 2019-10-28 18:55 UTC+01:00, Eric Barnhill : > > Here is a schematic for how the interface might be made more abstract. > > > > https://imgur.com/a/izx5Xkh > > This cannot be downloaded. > Please attach the image to a JIRA

Re: [lang] immutable BitSet

2019-10-28 Thread Claude Warren
Having "ImmutableBitSet" inherit from "BitSet" breaks the latter's contract. > > no more so than the ImmutableSet breaks the Set contract. Yes it does but the pattern is well established. -- I like: Like Like - The likeliest place on the web LinkedIn:

Re: [statistics-regression] Proposed Regression class/method structure

2019-10-28 Thread Gilles Sadowski
Hi Eric. 2019-10-28 18:55 UTC+01:00, Eric Barnhill : > Here is a schematic for how the interface might be made more abstract. > > https://imgur.com/a/izx5Xkh This cannot be downloaded. Please attach the image to a JIRA issue. Regards, Gilles > > In this case, we may want to just implement the

Re: [statistics-regression] Proposed Regression class/method structure

2019-10-28 Thread Gilles Sadowski
Hi. 2019-10-28 22:12 UTC+01:00, Alex Herbert : > > >> On 28 Oct 2019, at 17:55, Eric Barnhill wrote: >> >> Here is a schematic for how the interface might be made more abstract. >> >> https://imgur.com/a/izx5Xkh > > Regression and RegressionResults both have a

Re: [lang] immutable BitSet

2019-10-28 Thread Gilles Sadowski
Hi. 2019-10-28 20:38 UTC+01:00, Xeno Amess : > Then all ImmutableBitSet instance are instance of a mutable BitSet class > when we use instance of. > I just worry that could be kind of misleading sometimes. > I agree with that remark. Having "ImmutableBitSet" inherit from "BitSet" breaks the

Re: [statistics-regression] Proposed Regression class/method structure

2019-10-28 Thread Alex Herbert
> On 28 Oct 2019, at 17:55, Eric Barnhill wrote: > > Here is a schematic for how the interface might be made more abstract. > > https://imgur.com/a/izx5Xkh Regression and RegressionResults both have a predict method with the same signature. > > In this case,

Re: [lang] immutable BitSet

2019-10-28 Thread Xeno Amess
Then all ImmutableBitSet instance are instance of a mutable BitSet class when we use instance of. I just worry that could be kind of misleading sometimes. Gary Gregory 于 2019年10月29日周二 上午3:29写道: > On Mon, Oct 28, 2019 at 3:16 PM Xeno Amess wrote: > > > then it is better to make a

Re: [lang] immutable BitSet

2019-10-28 Thread Gary Gregory
On Mon, Oct 28, 2019 at 3:16 PM Xeno Amess wrote: > then it is better to make a AbstractBitSet abstract class?and two sub > classes MutableBitSet and ImmutableBitSet... > Why would you need that? The JRE already has a BitSet class. The idea is to reuse it, hence the new Lang immutable type

Re: [lang] immutable BitSet

2019-10-28 Thread Xeno Amess
then it is better to make a AbstractBitSet abstract class?and two sub classes MutableBitSet and ImmutableBitSet... ?? Outlook for Android From: Gary Gregory Sent: Tuesday, October 29, 2019 2:42:29 AM To: Commons Developers List Subject:

[lang] immutable BitSet

2019-10-28 Thread Gary Gregory
Hi All, Any thoughts for or against adding an ImmutableBitSet as a subclass of BitSet? It would throw an exception on attempt to mutate. I can then be used to define an EMPTY_BITSET constant. I could also be used in some of our methods that return a new empty bit set, if appropriate of course.

Re: [statistics-regression] Proposed Regression class/method structure

2019-10-28 Thread Eric Barnhill
Here is a schematic for how the interface might be made more abstract. https://imgur.com/a/izx5Xkh In this case, we may want to just implement the simplest case, using Matrix and double[], for now. In principle the RegressionMetric class could extend a Metrics class later. Do you feel this

Re: [collections] BloomFilter package architecture discussion

2019-10-28 Thread Claude Warren
Based on the feedback and questions I have created a different implementation (https://github.com/Claudenw/BloomFilter/tree/Hasher) -- note this is the Hasher branch. This implementation uses an abstract BloomFilter to implement the basic functionality required and required that implementations

[JEXL] GitHub/GitBox integration is out of whack

2019-10-28 Thread henrib
fyi https://issues.apache.org/jira/browse/INFRA-19344 Henrib -- Sent from: http://apache-commons.680414.n4.nabble.com/Commons-Dev-f680415.html - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

[vfs] GitHub/GitBox integration might be out of whack

2019-10-28 Thread Gary Gregory
FYI: https://issues.apache.org/jira/browse/INFRA-19348 Gary