Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Alex Herbert
> On 11 Nov 2019, at 23:40, Gilles Sadowski wrote: > > Hi. > > Maybe I'm missing what the issues really are, All empty japicmp reports on the site. Some confusing empty Jacoco aggregate reports on the site. > so sorry if this top-posted > reply is beside the points: > 1. There always have

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Gilles Sadowski
Hi. Maybe I'm missing what the issues really are, so sorry if this top-posted reply is beside the points: 1. There always have been several issues with JapiCmp (I do not remember exactly which; it must be in the ML archive); it never worked with Commons RNG. [As as been mentioned in some thread

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Alex Herbert
> On 11 Nov 2019, at 18:36, Gilles Sadowski wrote: > >>> [...] >>> >>> I will try and find out why these are running and just remove them. >> >> The pom requires this to skip aggregate reports [2]: >> >> >> org.jacoco >> jacoco-maven-plugin >> >>

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Gilles Sadowski
> > [...] > > > > I will try and find out why these are running and just remove them. > > The pom requires this to skip aggregate reports [2]: > > > org.jacoco > jacoco-maven-plugin > > > > >report >

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Gilles Sadowski
Hello. > [...] > > This may have always been the case. Yes. Gilles > [...] - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Gary Gregory
I usually run site builds with -P jacoco and -P japicmp Gary On Mon, Nov 11, 2019 at 12:55 PM Alex Herbert wrote: > On 11/11/2019 16:43, Gary Gregory wrote: > > The JApiCmp and JaCoCo reports are empty. You'll want to make sure you > fix > > that before publishing the site. > > Good spot.

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Alex Herbert
On 11/11/2019 17:55, Alex Herbert wrote: On 11/11/2019 16:43, Gary Gregory wrote: The JApiCmp and JaCoCo reports are empty. You'll want to make sure you fix that before publishing the site. Good spot. Unfortunately I've already pushed to the live site so I'll have to fix it in-place.

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Alex Herbert
On 11/11/2019 16:43, Gary Gregory wrote: The JApiCmp and JaCoCo reports are empty. You'll want to make sure you fix that before publishing the site. Good spot. Unfortunately I've already pushed to the live site so I'll have to fix it in-place. JAPIcmp was introduced in parent-49 but set to

[ANNOUNCEMENT] Apache Commons RNG Version 1.3 Released

2019-11-11 Thread Alex Herbert
The Apache Commons Team is pleased to announce the availability of version 1.3 of "Apache Commons RNG". Apache Commons RNG provides Java implementations of pseudo-random numbers generators. Note: A behavioural compatibility change has been introduced by the fix for RNG-96. Changes in this

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Gary Gregory
The JApiCmp and JaCoCo reports are empty. You'll want to make sure you fix that before publishing the site. Gary On Tue, Nov 5, 2019 at 11:36 AM Alex Herbert wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons RNG 1.2 was released, so I would

Re: [CODEC] Sign Extension Error in Murmur3

2019-11-11 Thread Claude Warren
https://github.com/apache/commons-codec/pull/27 On Mon, Nov 11, 2019 at 4:25 PM Claude Warren wrote: > I took the approach that I would leave the original code there and add new > methods hash128_x64 and hash32_x86. I also marked the older methods as > deprecated with a note that the

Re: [CODEC] Sign Extension Error in Murmur3

2019-11-11 Thread Claude Warren
I took the approach that I would leave the original code there and add new methods hash128_x64 and hash32_x86. I also marked the older methods as deprecated with a note that the implementation has a sign extension error and to use the new methods for new development and cases where the change

[RESULT][VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Alex Herbert
The votes are as follows: +1 - Gilles Sadowski (binding) +1 - Pascal Schumacher (binding) +1 - Alex Herbert (binding) I will perform the release now. Many thanks to the validators. Alex On 05/11/2019 16:36, Alex Herbert wrote: We have fixed quite a few bugs and added some significant

Re: [VOTE] Release Apache Commons RNG 1.3 based on RC1

2019-11-11 Thread Alex Herbert
Here's my +1. Alex On 05/11/2019 16:36, Alex Herbert wrote: We have fixed quite a few bugs and added some significant enhancements since Apache Commons RNG 1.2 was released, so I would like to release Apache Commons RNG 1.3. Apache Commons RNG 1.3 RC1 is available for review here: