Re: [BloomFilters] changes to BloomFilter

2020-03-18 Thread Claude Warren
bf.getBits() * Long.BYTES may be as long as Math.Ceil( Shape.getNumberOfBits() / 8.0 ) or it may be shorter. I am building byte buffers of fixed length that is the maximum size that any valid bf.getBits() * Long.BYTES I need to know Shape.getNumberOfBytes(). The conversion is required for some

Re: [math]Discussion: How to move out "EmptyClusterStrategy" from KMeansPlusPlusClusterer

2020-03-18 Thread Gilles Sadowski
Hi. 2020-03-18 15:10 UTC+01:00, chentao...@qq.com : > Hi, > I have created a PR to show my aim: > https://github.com/apache/commons-math/pull/126/files Am I correct that the implementations of "ClustersPointExtractor" modify the argument of the "extract" method? If so, that seems quite

Re: [BloomFilters] changes to BloomFilter

2020-03-18 Thread Alex Herbert
> On 18 Mar 2020, at 14:39, Claude Warren wrote: > >>> Shape Discussion: >>> >>> as for getNumberOfBytes() it should return the maximum number of bytes >>> returned by a getBits() call to a filter with this shape. So yes, if > there >>> is a compressed internal representation, no it won't

Re: [BloomFilters] changes to BloomFilter

2020-03-18 Thread Claude Warren
>> Shape Discussion: >> >> as for getNumberOfBytes() it should return the maximum number of bytes >> returned by a getBits() call to a filter with this shape. So yes, if there >> is a compressed internal representation, no it won't be that. It is a >> method on Shape so it should literally be

Re: [BloomFilters] changes to BloomFilter

2020-03-18 Thread Claude Warren
We are getting to the point where there are a lot of options that determine which implementation is "best". We could take a stab at creating a BloomFIlterFactory that takes a Shape as an argument and does a "finger in the air" guestimate of which implementation best fits. Store values in long

Re: [BloomFilters] changes to BloomFilter

2020-03-18 Thread Claude Warren
You don't need Iterator iterator() as we have forEachCount( BitCountConsumer ) I guess we need something like add( Iterator) or add( Collection ) or add( Stream ) It would be nice if we could have a BitCountProducer class that we could just pass to an add() method. On Wed, Mar 18, 2020 at

Re: [math]Discussion: How to move out "EmptyClusterStrategy" from KMeansPlusPlusClusterer

2020-03-18 Thread chentao...@qq.com
Hi,     I have created a PR to show my aim: https://github.com/apache/commons-math/pull/126/files  >Hello. > >Le mer. 11 mars 2020 à 07:28, chentao...@qq.com a écrit : >> >> Hi all, >> The "EmptyClusterStrategy" in KMeansPlusPlusClusterer can be reused >>MiniBatchKMeansClusterer and other

Re: [BloomFilters] changes to BloomFilter

2020-03-18 Thread Alex Herbert
> On 18 Mar 2020, at 11:14, Claude Warren wrote: > > On a slightly different note. CountingBloomFilters have no way to perform > a reload. All other bloom filters you can dump the bits and reload > (trivial) but if you preserve the counts from a bloom filter and want to > reload them you

Re: [BloomFilters] changes to BloomFilter

2020-03-18 Thread Alex Herbert
> On 17 Mar 2020, at 22:34, Claude Warren wrote: > > Builder discussion: > > Let's go with > >>> Builder with(CharSequence, Charset); >>> Builder withUnencoded(CharSequence); Added to master. I already note that not having it mandate UTF-8 is annoying. I had to include StandardCharsets in

Re: [BloomFilters] changes to BloomFilter

2020-03-18 Thread Claude Warren
On a slightly different note. CountingBloomFilters have no way to perform a reload. All other bloom filters you can dump the bits and reload (trivial) but if you preserve the counts from a bloom filter and want to reload them you can't. We need a constructor that takes the index,count pairs

Re: Release Announcement: General Availability of Java 14 / JDK 14

2020-03-18 Thread Hasan Diwan
Congrats to all of you who were involved with this project! -- H On Wed, 18 Mar 2020 at 01:47, Rory O'Donnell wrote: >Hi Benedikt, > > > **Release Announcement: General Availability of Java 14 / JDK 14 [1] * * > > * JDK 14, the reference implementation of Java 14, is now Generally >

Release Announcement: General Availability of Java 14 / JDK 14

2020-03-18 Thread Rory O'Donnell
  Hi Benedikt, **Release Announcement: General Availability of Java 14 / JDK 14 [1] * * * JDK 14, the reference implementation of Java 14, is now Generally Available. * GPL-licensed OpenJDK builds from Oracle are available here: https://jdk.java.net/14 * JDK 14 Release notes