Re: [VOTE] Release Apache Commons Imaging 1.0-alpha2 based on RC1

2020-08-02 Thread Bruno P. Kinoshita
Thanks Sebb! I used the latest version of the plugin when calling the vote mojo task. I will check if there's an issue in commons-release-plugin or if I simply forgot to update something in [imaging]'s pom.xml or pass some parameter. I found a couple of other things that need updating in the

Re: [VOTE] Release Apache Commons Imaging 1.0-alpha2 based on RC1

2020-08-02 Thread Bruno P. Kinoshita
>- The alpha1 release notes are not there, they jump from alpha2 to 0.97 I almost gave up sending the vote this weekend after spending some minutes trying to understand why that was happening. Then I realized it was generated using a template in the [imaging] project. The template from

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-02 Thread sebb
On Sun, 2 Aug 2020 at 19:27, Gary Gregory wrote: > > On Sun, Aug 2, 2020 at 12:00 PM sebb wrote: > > > On Sun, 2 Aug 2020 at 14:13, Gary Gregory wrote: > > > > > > -1: I do not think we should release when a test breaks on Java 11, an > > LTS > > > version; see below. > > > > > > The release

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-02 Thread Gary Gregory
On Sun, Aug 2, 2020 at 12:00 PM sebb wrote: > On Sun, 2 Aug 2020 at 14:13, Gary Gregory wrote: > > > > -1: I do not think we should release when a test breaks on Java 11, an > LTS > > version; see below. > > > > The release notes mention the wrong version here: > > > > "Updates Apache Commons

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-02 Thread Gary Gregory
On Sun, Aug 2, 2020 at 12:00 PM sebb wrote: > On Sun, 2 Aug 2020 at 14:13, Gary Gregory wrote: > > > > -1: I do not think we should release when a test breaks on Java 11, an > LTS > > version; see below. > > > > The release notes mention the wrong version here: > > > > "Updates Apache Commons

Re: [all] Thoughts on build system maven -> gradle??

2020-08-02 Thread Emmanuel Bourg
-1, I'd rather return to Ant than switching to Gradle. Gradle builds quickly become messy as hell, if you compare several Gradle based projects like Hibernate, Spring and OpenJFX they hardly look similar. Maven POM files may look verbose but at least the declarative syntax enforces a normalized

Re: [ALL] CI builds and Java versions

2020-08-02 Thread Emmanuel Bourg
Le 26/07/2020 à 23:39, Gary Gregory a écrit : > For mythical builds that require Java 6, we should really consider bumping > those up to Java 7 or 8 because newer JDKs do not accept compiling to > targets older than Java 7. Technically it's possible to build with Java 11 and use the --release 6

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-02 Thread sebb
On Sun, 2 Aug 2020 at 14:13, Gary Gregory wrote: > > -1: I do not think we should release when a test breaks on Java 11, an LTS > version; see below. > > The release notes mention the wrong version here: > > "Updates Apache Commons BeanUtils dependency from 1.9.2 to 1.9.3." > > It should be

Re: [VOTE] Release Apache Commons Imaging 1.0-alpha2 based on RC1

2020-08-02 Thread Gary Gregory
+1 Reviewing the git tag. Release notes need tweaks: - The alpha1 release notes are not there, they jump from alpha2 to 0.97 - There is no link to the download page, which you must have if you use the RNs as your source for the announcement email. - Sentences should end in a period: First and

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-02 Thread Gilles Sadowski
Le dim. 2 août 2020 à 15:37, Rob Tompkins a écrit : > > > > > On Aug 2, 2020, at 9:32 AM, Gilles Sadowski wrote: > > > > Le dim. 2 août 2020 à 15:13, Gary Gregory a écrit > > : > >> > >> -1: I do not think we should release when a test breaks on Java 11, an LTS > >> version; see below. > > >

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-02 Thread Gary Gregory
On Sun, Aug 2, 2020 at 9:32 AM Gilles Sadowski wrote: > Le dim. 2 août 2020 à 15:13, Gary Gregory a > écrit : > > > > -1: I do not think we should release when a test breaks on Java 11, an > LTS > > version; see below. > > If everybody agrees, doesn't this become a Commons' *rule* > that could

Re: [VOTE] Release Apache Commons Net 3.7 based on RC2

2020-08-02 Thread Gary Gregory
+1 Building from the git tag. Yikes: Is JaCoCo correct in reporting such low numbers: 32% code coverage and 26% branch coverage :-( My confidence is low that this RC does not introduce any regressions. But the building is OK with: mvn clean install site -P jacoco -P japicmp -V On these

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-02 Thread Rob Tompkins
> On Aug 2, 2020, at 9:32 AM, Gilles Sadowski wrote: > > Le dim. 2 août 2020 à 15:13, Gary Gregory a écrit : >> >> -1: I do not think we should release when a test breaks on Java 11, an LTS >> version; see below. > > If everybody agrees, doesn't this become a Commons' *rule* > that could

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-02 Thread Gilles Sadowski
Le dim. 2 août 2020 à 15:13, Gary Gregory a écrit : > > -1: I do not think we should release when a test breaks on Java 11, an LTS > version; see below. If everybody agrees, doesn't this become a Commons' *rule* that could be taken off the RM's shoulders? I mean, by setting up appropriate

Re: [VOTE] Release Apache Commons Net 3.7 based on RC2

2020-08-02 Thread Gary Gregory
Why is this an RC2 when there's never been an RC1? Gary On Sat, Aug 1, 2020 at 3:26 PM sebb wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Net 3.6 was released, so I would like to release > Apache Commons Net 3.7. > > Apache Commons Net

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

2020-08-02 Thread Gary Gregory
-1: I do not think we should release when a test breaks on Java 11, an LTS version; see below. The release notes mention the wrong version here: "Updates Apache Commons BeanUtils dependency from 1.9.2 to 1.9.3." It should be 1.9.4. Building from the git tag with "mvn clean install site -P

Re: [VOTE] Release Apache Commons Imaging 1.0-alpha2 based on RC1

2020-08-02 Thread sebb
+1 compared git tag with source archive Built and tested OK; site built OK Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T19:33:14+01:00) Maven home: /opt/apache-maven-3.5.4 Java version: 1.8.0_231, vendor: Oracle Corporation, runtime:

Re: [VOTE] Release Apache Commons Imaging 1.0-alpha2 based on RC1

2020-08-02 Thread sebb
On Sun, 2 Aug 2020 at 00:54, Bruno P. Kinoshita wrote: > > We have fixed quite a few bugs and added some significant enhancements since > Apache Commons Imaging 1.0-alpha1 was released, so I would like to release > Apache Commons Imaging 1.0-alpha2. > > Apache Commons Imaging 1.0-alpha2 RC1 is