Re: [IO] Test failures on Windows

2020-08-07 Thread sebb
If so, then it is not sufficient to run tests on Windows, it looks like we need to run tests on Windows with the appropriate version of Java. Presumably that is why Jenkins did not show the error. However, fixing the test won't fix the code - there may be instances of lastModified elsewhere.

Re: [IO] Test failures on Windows

2020-08-07 Thread Gary Gregory
On Fri, Aug 7, 2020 at 10:04 AM Matt Sicker wrote: > That sounds like a file modification time granularity issue. Does Windows > not support milliseconds or finer for file modification times? It could be > that the test executed too fast! > This might be a classic bug I've run into at work:

Re: [commons-io] branch master updated: Add getters for simpler subclassing.

2020-08-07 Thread sebb
On Fri, 7 Aug 2020 at 00:59, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-io.git > > > The following commit(s) were added to refs/heads/master by this push:

Re: [commons-io] branch master updated: Restore binary compatibility in IOUtils with latest released version 2.7.

2020-08-07 Thread sebb
On Fri, 7 Aug 2020 at 14:47, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-io.git > > > The following commit(s) were added to refs/heads/master by this push:

Re: [commons-io] branch master updated: Null-guard IOUtils.close(Closeable, IOConsumer).

2020-08-07 Thread sebb
On Fri, 7 Aug 2020 at 14:27, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-io.git > > > The following commit(s) were added to refs/heads/master by this push:

Re: [IO] Test failures on Windows

2020-08-07 Thread Gary Gregory
On Fri, Aug 7, 2020 at 10:09 AM Matt Sicker wrote: > You can basically copy the GitHub Actions setup we have in log4j2 minus the > toolchains stuff (unless you need that too). GHA looks to support macOS > runners as well. > It looks like we do it the same way...

Re: [IO] Test failures on Windows

2020-08-07 Thread sebb
I've just checked the Jenkins build and IO on Windows looks fine: https://ci-builds.apache.org/job/Commons/job/commons-net-windows/ On Fri, 7 Aug 2020 at 15:50, sebb wrote: > > On Fri, 7 Aug 2020 at 15:04, Matt Sicker wrote: > > > > That sounds like a file modification time granularity issue.

Re: [IO] Test failures on Windows

2020-08-07 Thread sebb
On Fri, 7 Aug 2020 at 15:04, Matt Sicker wrote: > > That sounds like a file modification time granularity issue. Does Windows > not support milliseconds or finer for file modification times? Could be; I thought I had allowed for that. I'll see if I can fix it for Windows. > It could be that the

Re: [IO] Test failures on Windows

2020-08-07 Thread Matt Sicker
You can basically copy the GitHub Actions setup we have in log4j2 minus the toolchains stuff (unless you need that too). GHA looks to support macOS runners as well. On Fri, Aug 7, 2020 at 09:07 Xeno Amess wrote: > there be document on travis-ci about windows environment but I havn't seen > any

Re: [IO] Test failures on Windows

2020-08-07 Thread Xeno Amess
there be document on travis-ci about windows environment but I havn't seen any java repo using it https://docs.travis-ci.com/user/reference/windows/ besides if my memory be correct, there be another site who have free windows environment. https://www.appveyor.com/ Gary Gregory 于2020年8月7日周五

Re: [IO] Test failures on Windows

2020-08-07 Thread Matt Sicker
That sounds like a file modification time granularity issue. Does Windows not support milliseconds or finer for file modification times? It could be that the test executed too fast! On Fri, Aug 7, 2020 at 09:01 Gary Gregory wrote: > As of recently, I am seing: > > [INFO] Running

[IO] Test failures on Windows

2020-08-07 Thread Gary Gregory
As of recently, I am seing: [INFO] Running org.apache.commons.io.FileUtilsTestCase [ERROR] Tests run: 142, Failures: 2, Errors: 0, Skipped: 1, Time elapsed: 5.613 s <<< FAILURE! - in org.apache.commons.io.FileUtilsTestCase [ERROR] testCopyFile2WithoutFileDatePreservation Time elapsed: 0.038 s

[ANNOUNCEMENT] Apache Commons Imaging 1.0-alpha2 Released

2020-08-07 Thread Bruno P. Kinoshita
The Apache Commons Imaging team is pleased to announce the commons-imaging-1.0-alpha2 release! Apache Commons Imaging (previously Sanselan) is a pure-Java image library. There are breaking changes between 1.0-alpha1 and 1.0-alpha2, until we stabilize the API for our 1.0 release. Users are

[RESULT] Release Apache Commons Validator 1.7 based on RC3

2020-08-07 Thread sebb
On Mon, 3 Aug 2020 at 18:12, sebb wrote:I More than 72 hours have now passed, and there have been the following binding votes: +1 Gary Gregory +1 Rob Tomkins +1 Sebb The vote has therefore succeeded, and publication will take place soon. Thanks again to all who voted. Sebb. > Thanks to those

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC3

2020-08-07 Thread sebb
Here's my +1 On Mon, 3 Aug 2020 at 18:12, sebb wrote: > > Thanks to those who voted for RC2, hopefully this will be OK > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Validator 1.6 was released, so I would like to > release Apache Commons

JDK 15 is now in the Initial Release Candidate Phase

2020-08-07 Thread Rory O'Donnell
Hi Benedikt, *Per the JDK 15 schedule  , we are now in the Initial Release Candidate Phase * ***Please advise if you have any open high priority issues.*** * Schedule for JDK 15 o *2020/08/06 Initial Release Candidate* o 2020/08/20 Final Release Candidate o 2020/09/15