Re: [Crypto] requesting help testing native binaries

2020-08-26 Thread Gary Gregory
On Wed, Aug 26, 2020 at 11:00 PM Gary Gregory wrote: > Part 2, trying to get macos to behave: > > echo $PATH > /opt/apache-maven-3.6.3/bin:/usr/local/opt/openssl@1.1 > /bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin > > *export LD_LIBRARY_PATH=/usr/local/Cellar/openssl@1.1/1.1.1g/lib/* > *java

Re: [Crypto] requesting help testing native binaries

2020-08-26 Thread Gary Gregory
Part 2, trying to get macos to behave: echo $PATH /opt/apache-maven-3.6.3/bin:/usr/local/opt/openssl@1.1 /bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin *export LD_LIBRARY_PATH=/usr/local/Cellar/openssl@1.1/1.1.1g/lib/* *java -cp target/classes org.apache.commons.crypto.Crypto* Apache Commons

Re: [Crypto] requesting help testing native binaries

2020-08-26 Thread Gary Gregory
Alex, All: Thank you for your review Alex. I agree that LibreSSL could be out of scope here. But, FTR, here is what I found: LibreSSL 2.8.3 does not seem to implement ENGINE_load_rdrand. https://www.libressl.org/ points to https://github.com/libressl-portable/openbsd and looking for

Re: [Crypto] requesting help testing native binaries

2020-08-26 Thread Alex Remily
Gary, I tested the most recent jar against Mac x86_64 and Linux x86_64 OpenSSL version 1.1.1. The unit tests passed and the main function ran to completion with expected output. I'll try to get to the Windows x86_64 test tomorrow and the OpenSSL 1.0 tests on the same three architectures by the

[All] Jenkins going haywire ?

2020-08-26 Thread Gilles Sadowski
Hi. Something happening recently (apparently unrelated to changes in the repository): https://ci-builds.apache.org/job/Commons/job/commons-statistics/3/console https://ci-builds.apache.org/job/Commons/job/commons-numbers/2/console

Re: [Crypto] requesting help testing native binaries

2020-08-26 Thread Geoffrey Blake
>From my end, that latest jar from 8/24 is working on AArch64 with a simple test on OpenSSL 1.1.x and OpenSSL 1.0.x based distros. I'm now trying it out on Spark to see if it links up with OpenSSL instead of the JCE. -Geoff On Tue, Aug 25, 2020 at 9:47 AM Alex Remily wrote: > Bruno, > > Are

Re: opinions about @NotNull and @Nullable ?

2020-08-26 Thread Matt Sicker
FindBugs and SpotBugs support the annotations. I mentioned that instead of the javax package version of the annotations for the JPMS reason mentioned by someone else earlier. That’s what we’re using in Jenkins (along with a mix of which annotation sets are used, but that’s the nature of a plugin

Re: [codec] Release 1.15

2020-08-26 Thread Gary Gregory
On Wed, Aug 26, 2020 at 4:55 AM Alex Herbert wrote: > This component has some useful bug fixes and new features to put out into > the open. > > I intend to cut an RC soon. > Nice :-) and thank you! Gary > > Alex > > > - > To

Re: opinions about @NotNull and @Nullable ?

2020-08-26 Thread Gary Gregory
Does SpotBugs use these annotations? If not, can SB make use of any annotations? Gary On Wed, Aug 26, 2020 at 2:30 AM Romain Manni-Bucau wrote: > For what it is worth: > > 1. Generally speaking - and IMHO - these annotations only make sense in a > particular tooling setup(s) - like considering

Re: opinions about @NotNull and @Nullable ?

2020-08-26 Thread Miguel Muñoz
Matt: Apache uses findBugs to assist Apache developers to catch bugs in the Apache code. Xeno's suggestion isn't for Apache developers, it's for our users. It's intended to help Apache users write better code. I have used annotations like this for years in my application code. They're very

[codec] Release 1.15

2020-08-26 Thread Alex Herbert
This component has some useful bug fixes and new features to put out into the open. I intend to cut an RC soon. Alex - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: opinions about @NotNull and @Nullable ?

2020-08-26 Thread Xeno Amess
> my point is if we want to go that path, which validation do we add to ensure it is correct Oh I see what you mean. I think there exist some toolchains which can do this, but I have no experience in doing the auto-validation myself. Maybe some source analyze plugin like pmd-maven-plugin can do

Re: opinions about @NotNull and @Nullable ?

2020-08-26 Thread Xeno Amess
> However, I've got a question: These annotations have @Retention(Runtime). (See https://www.javadoc.io/doc/com.google.code.findbugs/jsr305/latest/javax/annotation/Nullable.html .) Aren't we enforcing the presence of the respective jar at runtime? Hi. Usually, for Annotations, it have 3 ways to

Re: opinions about @NotNull and @Nullable ?

2020-08-26 Thread Romain Manni-Bucau
Le mer. 26 août 2020 à 08:42, Xeno Amess a écrit : > > how do we guarantee our meta are right and don't create false positives > If we cannot even make the meta correct, then means we cannot make sure > which function can return Null, which can not, > Then why do you think our customers can do.

Re: opinions about @NotNull and @Nullable ?

2020-08-26 Thread Xeno Amess
> how do we guarantee our meta are right and don't create false positives If we cannot even make the meta correct, then means we cannot make sure which function can return Null, which can not, Then why do you think our customers can do. And if people who write these libs are not sure which

Re: opinions about @NotNull and @Nullable ?

2020-08-26 Thread Romain Manni-Bucau
For what it is worth: 1. Generally speaking - and IMHO - these annotations only make sense in a particular tooling setup(s) - like considering values which can be null by code analysis and not by spec (@NotNull) - which I'm not sure we have so it is mainly about making it consumer friendly but