Re: [dbcp][pool] Use abort instead of close for abandoned connections?

2020-09-07 Thread Gary Gregory
On Mon, Sep 7, 2020 at 6:02 PM Phil Steitz wrote: > > > On 9/3/20 2:44 AM, Mark Thomas wrote: > > On 31/08/2020 01:05, Phil Steitz wrote: > > > > > > > >> If others agree it is a good idea for dbcp, I can do it. I can see the > >> argument that its better to stay with close() even for abandoned

Re: [dbcp][pool] Use abort instead of close for abandoned connections?

2020-09-07 Thread Phil Steitz
On 9/3/20 2:44 AM, Mark Thomas wrote: On 31/08/2020 01:05, Phil Steitz wrote: If others agree it is a good idea for dbcp, I can do it.  I can see the argument that its better to stay with close() even for abandoned and I have not been able to get the deadlock to happen, so I would like to

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread Gary Gregory
On Mon, Sep 7, 2020 at 2:25 PM Rob Tompkins wrote: > > > > > On Sep 7, 2020, at 2:16 PM, Mark Thomas wrote: > > > > On 07/09/2020 18:18, sebb wrote: > > > > > > > >> Such automation already exists, and is used to generate the VOTE > >> emails used by many Commons RMs > >> > >> $ mvn

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread Rob Tompkins
> On Sep 7, 2020, at 2:16 PM, Mark Thomas wrote: > > On 07/09/2020 18:18, sebb wrote: > > > >> Such automation already exists, and is used to generate the VOTE >> emails used by many Commons RMs >> >> $ mvn commons-release:vote-txt > > Thanks for that. > > I tried it out on the

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread Mark Thomas
On 07/09/2020 18:18, sebb wrote: > Such automation already exists, and is used to generate the VOTE > emails used by many Commons RMs > > $ mvn commons-release:vote-txt Thanks for that. I tried it out on the 1.2.3-RC1 release directory and it looks like it depends on various naming

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread sebb
On Mon, 7 Sep 2020 at 16:12, Mark Thomas wrote: > > On 07/09/2020 15:26, sebb wrote: > > Suppose we take the following example: > > > > https://lists.apache.org/thread.html/c99519e1c8e0a4af5be02f40e8e44b408cbc3d4568a334f3a400b94f%40%3Cdev.commons.apache.org%3E > > > > This is Commons Daemon 1.2.0

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread Matt Sicker
As long as your private key is safe, whatever the signed parts are will be tamper proof. Git lets you sign commits; does SVN offer anything similar? On Mon, Sep 7, 2020 at 10:12 Mark Thomas wrote: > On 07/09/2020 15:26, sebb wrote: > > > Suppose we take the following example: > > > > > > >

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread Mark Thomas
On 07/09/2020 15:26, sebb wrote: > Suppose we take the following example: > > https://lists.apache.org/thread.html/c99519e1c8e0a4af5be02f40e8e44b408cbc3d4568a334f3a400b94f%40%3Cdev.commons.apache.org%3E > > This is Commons Daemon 1.2.0 based on RC2. > > Take for example: > >

Re: [daemon] validation mechanics (was: Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1)

2020-09-07 Thread Mark Thomas
On 07/09/2020 15:40, Rob Tompkins wrote: > Also, I would think we should be as accommodating as possible to Mark as he > is indeed the top maintainer on [daemon]. I doubt we’d be making progress > there with out him. > > I’ve found his [VOTE] threads to be entirely sufficient for validation >

[daemon] validation mechanics (was: Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1)

2020-09-07 Thread Rob Tompkins
Also, I would think we should be as accommodating as possible to Mark as he is indeed the top maintainer on [daemon]. I doubt we’d be making progress there with out him. I’ve found his [VOTE] threads to be entirely sufficient for validation despite their differences in content. I’m. +1 for

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread sebb
Suppose we take the following example: https://lists.apache.org/thread.html/c99519e1c8e0a4af5be02f40e8e44b408cbc3d4568a334f3a400b94f%40%3Cdev.commons.apache.org%3E This is Commons Daemon 1.2.0 based on RC2. Take for example:

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread Gilles Sadowski
Hello. > > [...] > > see an explanation for why it is necessary > > (or even helpful) to include artefact hashes in the vote mail. > > > I agree and understand all your points here. Well, I don't. An explanation would be useful indeed. > > Validating the svn revision for the dist repo [ ... vs

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread Rob Tompkins
> On Sep 7, 2020, at 6:15 AM, Mark Thomas wrote: > > On 04/09/2020 12:30, Rob Tompkins wrote: >> +1 binding. > > Thanks for testing and voting. > >> Builds on java 7 and java 11 works with ‘mvn clean test’ >> >> Build on java 8 works with ‘mvn clean test install site’ >> >> % mvn

Re: [VOTE] Release Apache Commons Daemon 1.2.3 RC1

2020-09-07 Thread Mark Thomas
On 04/09/2020 12:30, Rob Tompkins wrote: > +1 binding. Thanks for testing and voting. > Builds on java 7 and java 11 works with ‘mvn clean test’ > > Build on java 8 works with ‘mvn clean test install site’ > > % mvn -version > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) >