Hi All
Please find my comments below:
>The build fails because of CheckStyle errors:
>https://app.travis-ci.com/github/apache/commons-math/builds/246683712
--Fixed the issues
[...]
>> >> >
>> >> >I did not suggest to remove any Javadoc, only to rephrase it as:
[...]
>> >As hinted
I approved the 2 GitHub workflows.
Gary
On Sun, Feb 20, 2022, 13:51 John Patrick wrote:
> Evening,
>
> Could someone approve my PR's workflow as still 1st time contributor for
> vfs. If they pass they are read for review and potential merge.
>
> Upgrades all the easy tests to JUnit v5
>
Evening,
Could someone approve my PR's workflow as still 1st time contributor for
vfs. If they pass they are read for review and potential merge.
Upgrades all the easy tests to JUnit v5
https://github.com/apache/commons-vfs/pull/240
Extracts test methods out of AbstractVfsTestCase, and also
Hello John,
In general, we've dropped Travis in favor of GitHub. We just did not get
around to do it for all components. No need for a Jira for that.
Updating Java for a component is always a challenge because some people are
usually ok with it and some not. You'll have to start a specific email
So wanted to update commons-jelly.
It's using travis and the default distro won't allow Java 1.7 to be
installed. So raised PR https://github.com/apache/commons-jelly/pull/8 to
fix that.
Now the build starts but I think due to Java 1.5 being the source and
target it's got another issue with
If they are my PR's they cover;
) @Test(expected=xxx.class) to using assertThrows
) trying to use assertAll
) removing unused imports
As I've been having issues with large PR changes, I've been trying to do
smaller PR's with a single item, or test being changed.
John
On Sun, 20 Feb 2022 at
I noticed a JAVA_1_7 home being injected in the build log. I removed:
JAVA_1_7_HOME=${JDK_1_7_LATEST_HOME}
from the configuration and added '-V' to the command to log the maven
and java version. Restarted the build and that did not work. The java
version is correct.
This added in the pom.xml
