Re: [pool] Resilience against factory outages (POOL-407)

No need to apologize  We all have complex system to deal with all over the place. Gary On Fri, May 31, 2024, 5:55 PM Phil Steitz wrote: > Thx and sorry. > > Phil > > On Fri, May 31, 2024 at 1:45 PM Gary D. Gregory > wrote: > > > Hello Phil, > > > > Before you push, run 'mvn' (buy itself),

Re: [pool] Resilience against factory outages (POOL-407)

Thx and sorry. Phil On Fri, May 31, 2024 at 1:45 PM Gary D. Gregory wrote: > Hello Phil, > > Before you push, run 'mvn' (buy itself), this runs the default goal, which > contains all build checks. > > If see the code coverage report, regardless of coverage failures, run: > > mvn clean site

Re: [pool] Resilience against factory outages (POOL-407)

I updated the README's "Contributing" sections with: + Before you pushing a PR, run `mvn` (by itself), this runs the default goal, which contains all build checks. + To see the code coverage report, regardless of coverage failures, run `mvn clean site -Dcommons.jacoco.haltOnFailure=false` This

Re: [pool] Resilience against factory outages (POOL-407)

Hello Phil, Before you push, run 'mvn' (buy itself), this runs the default goal, which contains all build checks. If see the code coverage report, regardless of coverage failures, run: mvn clean site -Dcommons.jacoco.haltOnFailure=false I'll update the readme... TY, Gary On 2024/05/31

Re: [pool] Resilience against factory outages (POOL-407)

The build worked locally for me fine. I could not get the site to build. Is there some sequence that I need to use to get the site to build? I did run Checksytle and Findbugs separately. What is the test coverage plugin and how do I run that? Phil On Fri, May 31, 2024 at 11:53 AM Gary Gregory

Re: [pool] Resilience against factory outages (POOL-407)

Hi Phil, Thank you for the note. I'll try to take a look soon. The new code causes the build to fail as it looks like not all of it is covered by unit tests. Gary On Fri, May 31, 2024, 2:29 PM Phil Steitz wrote: > I just committed a first attempt at providing the above, intended as a fix >

[pool] Resilience against factory outages (POOL-407)

I just committed a first attempt at providing the above, intended as a fix for POOL-407 and a lot of similar issues reported over the years. The scenario in POOL-407 is common when resource providers (like databases) go down: 1. makeObject requests start to fail and threads line up waiting on

[ANNOUNCE] Apache Commons Net 3.11.0

The Apache Commons Net team is pleased to announce the release of Apache Commons Net 3.11.0. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, and Whois.

[RESULT][VOTE] Release Apache Commons Net 3.11.0 based on RC1

This vote thread passes with the following binding +1 votes: - Henri Biestro (henrib) - Gary Gregory (ggregory) - Rob Tompkins (chtompki) Gary On Thu, May 30, 2024 at 8:28 AM Rob Tompkins wrote: > > +1 > > > On May 28, 2024, at 8:09 PM, Gary Gregory wrote: > > > > We have fixed a few bugs and

Re: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

Honestly I think not supporting empty literals is just as big a limitation as not supporting single quotes, so IMO we'd just be trading one limitation for another. i.e. if someone were to need empty literals, the things they would have to do to use them are the same things they'd have to do to

Re: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

I'm OK with Sebb's solution [1] Any further thoughts here? Gary [1] https://github.com/apache/commons-lang/pull/1227 On 2024/05/29 13:37:40 Mike Drob wrote: > On Wed, May 29, 2024 at 8:17 AM Gary Gregory wrote: > > > (Sorry for the top post, phone) > > > > A case I can imagine an empty ''

Re: [VOTE] Release Apache Commons Net 3.11.0 based on RC1

+1 > On May 28, 2024, at 8:09 PM, Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons > Net 3.10.0 was released, so I would like to release Apache Commons Net > 3.11.0. > > Apache Commons Net 3.11.0 RC1 is available for review here: >

Re: [VOTE] Release Apache Commons JCS 3.2.1 based on rc3

+1 > On May 27, 2024, at 2:24 PM, Thomas Vandahl wrote: > > Hi folks, > > We have fixed a few bugs since Apache Commons JCS 3.2 was released, so I > would like to release Apache Commons JCS 3.2.1. > > Apache Commons JCS 3.2.1 rc3 is available for review here: >

Re: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

On Wed, May 29, 2024 at 8:17 AM Gary Gregory wrote: > (Sorry for the top post, phone) > > A case I can imagine an empty '' occurring is when the format string itself > is built programmatically for example a '%s' or using string concatenate of > a variable that holds a string where that string

Re: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

(Sorry for the top post, phone) A case I can imagine an empty '' occurring is when the format string itself is built programmatically for example a '%s' or using string concatenate of a variable that holds a string where that string can be empty or an "s" to mark a plural or a quote for example.

Re: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

On Sun, 26 May 2024 at 23:37, sebb wrote: > > On Sun, 26 May 2024 at 08:25, Laertes Moustakas wrote: > > > > Hello Gary, > > > > Thank you for your response. Some of the new assertions indeed fail when > > interpreting the duplicate single quote as an escaped quote instead of a > > closing and

Re: [VOTE] Release Apache Commons Net 3.11.0 based on RC1

My +1 Gary On Wed, May 29, 2024 at 4:35 AM Henri Biestro wrote: > > [ +1 ] LGTM > > Site & Javadoc look good, changes & JIRA report clean (nice!), nit: Jacoco > report missing some classes > > Built using: > mvn clean install site -Pjacoco -s ~/.m2/commons-settings.xml > On: > mvn -version >

Re: [CLI] Parsing arguments with no options...

I seem to recall that the parsing multiple options code is "wonky" because it has to deal with a legacy "comma separated string". It may relate to CLI-306 On Tue, May 28, 2024 at 6:16 PM Gary Gregory wrote: > What about 'Hello World'? > > Gary > > On Tue, May 28, 2024, 11:13 AM Eric Pugh >

Re: [VOTE] Release Apache Commons Net 3.11.0 based on RC1

[ +1 ] LGTM Site & Javadoc look good, changes & JIRA report clean (nice!), nit: Jacoco report missing some classes Built using: mvn clean install site -Pjacoco -s ~/.m2/commons-settings.xml On: mvn -version Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home:

[VOTE] Release Apache Commons Net 3.11.0 based on RC1

We have fixed a few bugs and added enhancements since Apache Commons Net 3.10.0 was released, so I would like to release Apache Commons Net 3.11.0. Apache Commons Net 3.11.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/net/3.11.0-RC1 (svn revision 69435)

[ANNOUNCE] Apache Commons Validator 1.9.0

The Apache Commons Validator team is pleased to announce the release of Apache Commons Validator 1.9.0. Apache Commons Validator provides the building blocks for both client-side and server-side data validation. It may be used standalone or with a framework like Struts. This is a maintenance and

Re: [VOTE] Release Apache Commons JCS 3.2.1 based on rc3

+1 - Release notes are NOT historical (how am I supposed to know what changed since version X?) - Testing src zip file. - ASC OK - SHA512 OK - Maven RAT check OK - Maven default goal () openjdk version "17.0.11" 2024-04-16 OpenJDK Runtime Environment Homebrew (build 17.0.11+0) OpenJDK 64-Bit

[RESULT][VOTE] Release Apache Commons Validator 1.9.0 based on RC1

This vote thread passes with the following +1 binding votes: - Henri Biestro (henrib) - Phil Steitz (psteitz) - Gary Gregory (ggregory) Gary On Sun, May 26, 2024 at 9:49 PM Gary Gregory wrote: > > My +1 > > Gary > > > On Sat, May 25, 2024, 5:11 PM Gary Gregory wrote: >> >> We have fixed a few

Re: [VFS-853] Duplicate Listeners

TY Bernd! Gary On Mon, May 27, 2024 at 12:33 PM Bernd Eckenfels wrote: > > Hello, > > I pushed a PR which fixes the issue and > Contains a test (which fails if the fix is not > Present. Besides the uneeded double > Indirection this code also leads to prematurely > Dropped listeners and

Re: [CLI] Did https://github.com/apache/commons-cli/pull/252 make it into changes report?

Eric, I updated git master and uploaded a new site. TY! Gary On Tue, May 28, 2024 at 10:24 AM Eric Pugh wrote: > > I noticed that > https://commons.apache.org/proper/commons-cli/changes-report.html#a1.7.0 > doesn’t reflect it (I think?) and that >

Re: [CLI] Parsing arguments with no options...

What about 'Hello World'? Gary On Tue, May 28, 2024, 11:13 AM Eric Pugh wrote: > I may need to see if there is a unit test I can write, because on my Mac, > ‘Hello World” get’s turned into “Hello” and “World” as well :-(. > > > > > > > On May 28, 2024, at 10:57 AM, Gary Gregory > wrote: > > >

Re: [CLI] Parsing arguments with no options...

I may need to see if there is a unit test I can write, because on my Mac, ‘Hello World” get’s turned into “Hello” and “World” as well :-(. > On May 28, 2024, at 10:57 AM, Gary Gregory wrote: > > It depends on the operating system as the OS itself might do different > things with both

Re: [CLI] Parsing arguments with no options...

It depends on the operating system as the OS itself might do different things with both single-quotes and double-quotes. For example, on Linux/macOS, single quotes create a string that is not interpreted IIRC. Gary On Tue, May 28, 2024, 10:37 AM Eric Pugh wrote: > Hi all, trying to figure out

[CLI] Parsing arguments with no options...

Hi all, trying to figure out if I found a bug or if it’s user error. I have a command line: bin/solr stream -verbose echo.expr "Hello World” The -verbose is an option, and then the next two parameters I get via System.out.print(cli.getArgList());. I would expect to get two parameters:

[CLI] Did https://github.com/apache/commons-cli/pull/252 make it into changes report?

I noticed that https://commons.apache.org/proper/commons-cli/changes-report.html#a1.7.0 doesn’t reflect it (I think?) and that https://commons.apache.org/proper/commons-cli/properties.html doesn’t either… Eric ___ Eric Pugh | Founder | OpenSource Connections, LLC |

Re: [VOTE] Release Apache Commons JCS 3.2.1 based on rc3

My vote > Am 27.05.2024 um 20:24 schrieb Thomas Vandahl : > > Hi folks, > > We have fixed a few bugs since Apache Commons JCS 3.2 was released, so I > would like to release Apache Commons JCS 3.2.1. > > Apache Commons JCS 3.2.1 rc3 is available for review here: >

[VOTE] Release Apache Commons JCS 3.2.1 based on rc3

Hi folks, We have fixed a few bugs since Apache Commons JCS 3.2 was released, so I would like to release Apache Commons JCS 3.2.1. Apache Commons JCS 3.2.1 rc3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/jcs/3.2.1-rc3 (svn revision 69406) The Git tag

Re: [VFS-853] Duplicate Listeners

Hello, I pushed a PR which fixes the issue and Contains a test (which fails if the fix is not Present. Besides the uneeded double Indirection this code also leads to prematurely Dropped listeners and therefore loses change events. Unfortunately a CI Acrion on Girhub failed with a unrelated

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

My +1 Gary On Sat, May 25, 2024, 5:11 PM Gary Gregory wrote: > We have fixed a few bugs and added enhancements since Apache Commons > Validator 1.8.0 was released, so I would like to release Apache > Commons Validator 1.9.0. > > Apache Commons Validator 1.9.0 RC1 is available for review here:

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

[+1] Checked build, sigs, reports, notes. All look good. Tested on Apache Maven 3.9.3 Java version: 17.0.10, java-17-openjdk-amd64 OS name: "linux", version: "5.15.0-107-generic", arch: "amd64", family: "unix" Phil On Sat, May 25, 2024 at 2:12 PM Gary Gregory wrote: > We have fixed a few

Re: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

On Sun, 26 May 2024 at 08:25, Laertes Moustakas wrote: > > Hello Gary, > > Thank you for your response. Some of the new assertions indeed fail when > interpreting the duplicate single quote as an escaped quote instead of a > closing and opening quote. In particular, "y' ''years' M 'months'" is

Re: Javadoc usability

Emmanuel, It looks like you updated the Commons Parent POM to add a profile without documenting the change in changes.xml. Would you please do that? TY, Gary On 2024/05/18 12:21:54 sebb wrote: > If we are changing the Javadoc settings, we should update the footer > to include the full list of

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

Tomas, The link you provided is not relevant to Commons CLI because the class SetUniqueList from Commons Collections the link mentions is not used by CLI, so there is nothing to change. Gary On Sun, May 26, 2024 at 10:06 AM Tomas Lanik wrote: > > Hi All, > Has the security issue ( >

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

[+1] Site looks good, reports are clean (nit: coverage is low, JIRA report need some work wrt fix version/reported version). Build using: Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: /Users/hbiestro/Java/apache-maven-3.8.6 Java version: 1.8.0_352, vendor: Azul

[CANCEL][VOTE] Release Apache Commons JCS 3.2.1 based on rc2

Next attempt. > Am 20.04.2024 um 12:25 schrieb Thomas Vandahl : > > Hi folks, > > We have fixed a few bugs since Apache Commons JCS 3.2 was released, so I > would like to release Apache Commons JCS 3.2.1. > > Apache Commons JCS 3.2.1 rc2 is available for review here: >

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

Hi All, Has the security issue ( https://devhub.checkmarx.com/cve-details/Cx78f40514-81ff/ ) related to commons-collections:commons-collections:3.2.2 been addressed? I can not see it in release notes. FYI Tom On Sat, May 25, 2024 at 11:12 PM Gary Gregory wrote: > We have fixed a few bugs and

RE: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

Hello Gary, Thank you for your response. Some of the new assertions indeed fail when interpreting the duplicate single quote as an escaped quote instead of a closing and opening quote. In particular, "y' ''years' M 'months'" is interpreted as "4 'years 0 months" while the expected text lacks

[VOTE] Release Apache Commons Validator 1.9.0 based on RC1

We have fixed a few bugs and added enhancements since Apache Commons Validator 1.8.0 was released, so I would like to release Apache Commons Validator 1.9.0. Apache Commons Validator 1.9.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1

Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

Hello Laertes, Thank you for your interest in improving Apache Commons Lang :-) Do you foresee any compatibility issues for existing call sites and format strings? For example, can you make your use cases work and still support:

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

If you're still using Java 11 in 2032, then you're going to have different problems that supporting frames! ;-) Gary On Fri, May 24, 2024, 2:21 AM Emmanuel Bourg wrote: > Le 23/05/2024 à 21:42, Gary Gregory a écrit : > > > What happens when Java 11 is EOL? The frames will be gone for good >

Re: [CLI] Using cli to drive Ant and Maven UIs

Nice! :-) Gary On Fri, May 24, 2024, 5:36 AM Claude Warren wrote: > Just an observation. I am working on the Rat tool. Part of that is that > we want to harmonize the UIs (CLI, Ant, and Maven) so that there are > congruent options across the UIs. > > The Option definition in commons-cli

[ANNOUNCEMENT] Commons Daemon 1.4.0 Released

The Apache Commons Team is pleased to announce the availability of Apache Commons Daemon 1.4.0 The Apache Commons Daemon software library provides a generic Daemon (unix) or Service (Windows) wrapper for Java code. Version 1.4.0 raises the minimum supported version of Java to Java 8 and

[CLI] Using cli to drive Ant and Maven UIs

Just an observation. I am working on the Rat tool. Part of that is that we want to harmonize the UIs (CLI, Ant, and Maven) so that there are congruent options across the UIs. The Option definition in commons-cli v1.8.0 is sufficiently complex that we can define the options in the CLI interface

[VOTE][RESULT] Release Apache Commons Daemon 1.4.0 based on RC1

All, My apologies for the delay in closing this vote. I missed some of the the votes so I didn't realize there were sufficient votes for this to pass. The following votes were cast: Binding: +1: ggregory, markt, chtompki No other votes were cast. The vote therefore passes. Thanks to

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

Le 23/05/2024 à 21:48, Eric Pugh a écrit : From my perspective, we all need to move on to newer versions of Java, and while it’s a pain, it’s also key to gaining new capabilities. I'm not advocating staying on older JDKs to keep a usable javadoc, that wouldn't make sense. But if a component

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

Le 23/05/2024 à 21:42, Gary Gregory a écrit : What happens when Java 11 is EOL? The frames will be gone for good anyway. Java 11 won't be EOL before 2032 [1], that leaves some time to find an alternative. I wouldn't be surprised if someone releases a doclet supporting frames by then. Btw

[RESULT][VOTE] Release Apache Commons Compress 1.26.2 based on RC1

This vote thread passes with the following +1 binding votes: - Gary Gregory (ggregory) - Rob Tompkins (chtompki) - Henri Biestro (henrib) Gary On Thu, May 23, 2024 at 9:26 AM Henri Biestro wrote: > > [ +1 ] > > Site looks good, javadoc looks good, reports Ok (nit jacoco missing). > > Tested

[ANNOUNCE] Apache Commons CLI Version 1.8.0

The Apache Commons Team is pleased to announce Apache Commons CLI Version 1.8.0. Apache Commons CLI provides a simple API for presenting, processing, and validating a Command Line Interface. This release contains new features and bug fixes and requires Java 8 or above. New Features

[RESULT][VOTE] Release Apache Commons CLI 1.8.0 based on RC2

This vote thread passes with the following 3 +1 binding votes, with other votes listed: - Gary Gregory (ggregory, binding) +1 - Eric Pugh (epugh, non-binding) +1 - Rob Tompkins (chtompki, binding) +1 - Paul King (non-binding) +1 - Henri Biestro (henrib, binding) +1 - Emmanuel Bourg (ebourg,

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

From my perspective, we all need to move on to newer versions of Java, and while it’s a pain, it’s also key to gaining new capabilities. > On May 23, 2024, at 3:42 PM, Gary Gregory wrote: > > User experience is subjective... ;-) > > What happens when Java 11 is EOL? The frames will be gone

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

User experience is subjective... ;-) What happens when Java 11 is EOL? The frames will be gone for good anyway. Gary On Thu, May 23, 2024, 3:41 PM Emmanuel Bourg wrote: > So there is nothing I can do to convince you to install OpenJDK 11 to > improve the user experience? Having multiple JDKs

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

So there is nothing I can do to convince you to install OpenJDK 11 to improve the user experience? Having multiple JDKs installed isn't uncommon though. Emmanuel Bourg Le 23/05/2024 à 20:47, Gary Gregory a écrit : ATM, I am using Java 17 for everything, at work, at FOSS. Gary On Thu, May

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

ATM, I am using Java 17 for everything, at work, at FOSS. Gary On Thu, May 23, 2024, 2:28 PM Emmanuel Bourg wrote: > What about building with JDK 11 and the -frame option then? That's the > best of both worlds. > > Emmanuel Bourg > > Le 23/05/2024 à 18:44, Gary Gregory a écrit : > > I

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

What about building with JDK 11 and the -frame option then? That's the best of both worlds. Emmanuel Bourg Le 23/05/2024 à 18:44, Gary Gregory a écrit : I disagree, I think the search box is a great feature. Gary On Thu, May 23, 2024, 11:26 AM Emmanuel Bourg wrote: -0 The javadoc was

Re: [VFS] Duplicate Listeners

Hi Bernd, Thank you for researching this issue and presenting your findings. In 2.9.0, we had (as you found): public static void installListener(final FileObject file, final FileListener listener) { final WeakRefFileListener weakListener = new WeakRefFileListener(file, listener);

[VFS] Duplicate Listeners

Hello, I am dealing with a heapdump of VFS where I see a lot of WeakRefFileListener and all of them have a empty WeakRef to no listener. While I think I found the reason for that and fixed it on a dependent project, it still does not clean up correctly. I think the reason is that it does not

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

I disagree, I think the search box is a great feature. Gary On Thu, May 23, 2024, 11:26 AM Emmanuel Bourg wrote: > -0 > > The javadoc was built with Java 17 and is less usable than the javadoc > generated by Java 8. I recommend building the next release with Java 8 > instead. > > Emmanuel

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

-0 The javadoc was built with Java 17 and is less usable than the javadoc generated by Java 8. I recommend building the next release with Java 8 instead. Emmanuel Bourg Le 19/05/2024 à 16:55, Gary Gregory a écrit : We have fixed a few bugs and added enhancements since Apache Commons CLI

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

[ +1 ] Site, Javadoc, reports look good. Nit: site refers to version 1.7.0, so are the release notes and the JIRA report is not helpful. Using: mvn clean install site On: mvn -version Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home:

Re: [VOTE] Release Apache Commons Compress 1.26.2 based on RC1

[ +1 ] Site looks good, javadoc looks good, reports Ok (nit jacoco missing). Tested using: mvn clean install site On: Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: /Users/hbiestro/Java/apache-maven-3.8.6 Java version: 17.0.8, vendor: Oracle Corporation, runtime:

Re: [VOTE] Release Apache Commons Compress 1.26.2 based on RC1

+1 > On May 18, 2024, at 12:56 PM, Gary Gregory wrote: > > We have fixed a few bugs since Apache Commons Compress 1.26.1 was > released, so I would like to release Apache Commons Compress 1.26.2. > > Apache Commons Compress 1.26.2 RC1 is available for review here: >

Re: (commons-lang) branch master updated: Undoing 3322d974876b8d4f934d3544967103ebbcaef726

The build is broken. This maybe should have been a git revert instead of a plain commit. Gary On Wed, May 22, 2024, 2:00 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > jochen pushed a commit to branch master > in repository

Re: [VOTE] Release Apache Commons Compress 1.26.2 based on RC1

My +1 Gary On Sat, May 18, 2024, 12:56 PM Gary Gregory wrote: > We have fixed a few bugs since Apache Commons Compress 1.26.1 was > released, so I would like to release Apache Commons Compress 1.26.2. > > Apache Commons Compress 1.26.2 RC1 is available for review here: >

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

+1 (non-binding) I checked: * hash and signatures for src and bin zips * no unexpected binary files (just some expected image files under site) * I tested the staged artifacts against the Groovy groovy-cli-commons test suite (all tests pass) * There appears to be an empty

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

+1 > On May 19, 2024, at 10:55 AM, Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons > CLI 1.7.0 was released, so I would like to release Apache Commons CLI > 1.8.0. > > Apache Commons CLI 1.8.0 RC2 is available for review here: >

Re: [VOTE] Release Apache Commons Daemon 1.4.0 based on RC1

+1 > On May 17, 2024, at 2:05 PM, Mark Thomas wrote: > > We have fixed a few bugs, added enhancements and updated the minimum Java and > Windows version since Apache Commons Daemon 1.3.4 was released, so I would > like to release Apache Commons Daemon 1.4.0. > > Apache Commons Daemon 1.4.0

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

+1. Thanks for the quick turn around. > On May 19, 2024, at 11:36 AM, Gary Gregory wrote: > > My +1 > > Gary > > > On Sun, May 19, 2024, 10:55 AM Gary Gregory > wrote: > >> We have fixed a few bugs and added enhancements since Apache Commons >> CLI 1.7.0 was

Re: [VOTE] Release Apache Commons Daemon 1.4.0 based on RC1

On 17/05/2024 19:05, Mark Thomas wrote:   [X] +1 Release these artifacts   [ ] +0 OK, but...   [ ] -0 OK, but really should fix...   [ ] -1 I oppose this release because... Signatures confirmed for Windows binaries. Tested successfully with Tomcat 11.0.x build. Mark

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC2

My +1 Gary On Sun, May 19, 2024, 10:55 AM Gary Gregory wrote: > We have fixed a few bugs and added enhancements since Apache Commons > CLI 1.7.0 was released, so I would like to release Apache Commons CLI > 1.8.0. > > Apache Commons CLI 1.8.0 RC2 is available for review here: >

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC1

RC2 out. Gary On Sat, May 18, 2024, 12:52 PM Claude Warren wrote: > I would be OK with not making the additional method public. > > On Sat, May 18, 2024 at 3:38 PM Gary Gregory > wrote: > >> Thank you Claude. >> >> I'm OK either way. I've commented on the PR. I'd like to know what others >>

[VOTE] Release Apache Commons CLI 1.8.0 based on RC2

We have fixed a few bugs and added enhancements since Apache Commons CLI 1.7.0 was released, so I would like to release Apache Commons CLI 1.8.0. Apache Commons CLI 1.8.0 RC2 is available for review here: https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC2 (svn revision 69280) The

Re: [VOTE] Release Apache Commons Daemon 1.4.0 based on RC1

+1 Tested src zip, SHA512 OK, ASC OK. - Maven default goal OK - macOS Java 17 build of jsvc OK (from ./configure setup) - Windows Java 17 build OK for both EXEs. Note: Compiler WARNINGs: arguments.c:453:5: warning: switch condition has boolean value [-Wswitch-bool] switch (par) { ^

[CANCEL][VOTE] Release Apache Commons CLI 1.8.0 based on RC1

I am canceling this vote thread to incorporate Claude's idea. It is indeed simpler and clearer :-) I had to look at the code as a whole in Eclipse to better appreciate the whole picture. Gary On Sat, May 18, 2024 at 12:52 PM Claude Warren wrote: > > I would be OK with not making the additional

[VOTE] Release Apache Commons Compress 1.26.2 based on RC1

We have fixed a few bugs since Apache Commons Compress 1.26.1 was released, so I would like to release Apache Commons Compress 1.26.2. Apache Commons Compress 1.26.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/compress/1.26.2-RC1 (svn revision 69274) The

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC1

I would be OK with not making the additional method public. On Sat, May 18, 2024 at 3:38 PM Gary Gregory wrote: > Thank you Claude. > > I'm OK either way. I've commented on the PR. I'd like to know what others > think. > > The change proposed only makes sense if we cancel this RC othewise it >

Re: [VOTE] Release Apache Commons Daemon 1.4.0 based on RC1

Hi Gary, Looks like I missed adding them before I committed the changes. I've just done that. Mark On 18/05/2024 15:28, Gary Gregory wrote: Hi Mark, Thank you for preparing this release candidate. There are no SHA512 files in:

Re: [VOTE] Release Apache Commons Daemon 1.4.0 based on RC1

Hi Mark, Thank you for preparing this release candidate. There are no SHA512 files in: https://dist.apache.org/repos/dist/dev/commons/daemon/1.4.0-RC1/source/ https://dist.apache.org/repos/dist/dev/commons/daemon/1.4.0-RC1/binaries/ Gary On Fri, May 17, 2024 at 2:06 PM Mark Thomas wrote: > >

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC1

Thank you Claude. I'm OK either way. I've commented on the PR. I'd like to know what others think. The change proposed only makes sense if we cancel this RC othewise it would be a breaking change or would clutter up the API with an additional public method. Gary On Sat, May 18, 2024 at 9:04 AM

Re: [VOTE] Release Apache Commons CLI 1.8.0 based on RC1

-1 There is a design issue. The HelpFormatter now takes a BiFunction to format the description for deprecated Options. However, it is simple to implement Function instead. I think this makes for a cleaner interface. Since this interface is public facing, I would like to merge the change in

Re: Javadoc usability

If we are changing the Javadoc settings, we should update the footer to include the full list of attributions. On Sat, 18 May 2024 at 12:59, Emmanuel Bourg wrote: > > Le 18/05/2024 à 13:07, Gary Gregory a écrit : > > You must be talking about this: > > > >

Re: Javadoc usability

Le 18/05/2024 à 13:07, Gary Gregory a écrit : You must be talking about this: https://bugs.openjdk.org/browse/JDK-8202961 The frames command line option might be completely gone from the current Java version but I haven't tried Digging a bit, frames were deprecated in JDK 11 and eventually

Re: Javadoc usability

The "unknown unknowns" ;-) Gary On Sat, May 18, 2024 at 7:27 AM Emmanuel Bourg wrote: > > The search box is a nice addition, but it's only useful if you know what > you are looking for. It doesn't replace a plain list of classes that can > be explored at a glance. > > Emmanuel Bourg > > Le

Re: Javadoc usability

The search box is a nice addition, but it's only useful if you know what you are looking for. It doesn't replace a plain list of classes that can be explored at a glance. Emmanuel Bourg Le 18/05/2024 à 13:09, Gary Gregory a écrit : Notice that the newer Javadocs has a fancy Search box, quite

Re: Javadoc usability

Notice that the newer Javadocs has a fancy Search box, quite handy IMO. Gary On Sat, May 18, 2024, 7:07 AM Gary Gregory wrote: > You must be talking about this: > > https://bugs.openjdk.org/browse/JDK-8202961 > > The frames command line option might be completely gone from the current > Java

Re: Javadoc usability

You must be talking about this: https://bugs.openjdk.org/browse/JDK-8202961 The frames command line option might be completely gone from the current Java version but I haven't tried : https://docs.oracle.com/en/java/javase/21/docs/specs/man/javadoc.html#option-add-stylesheet Note that the no

Javadoc usability

Hi all, I got a look at the Commons IO Javadoc [1] yesterday and it looks like something got wrong starting with the 2.14 release, the framed layout [2] up to the version 2.13 was much more usable, with an instant overview of the package structure and the classes available. Exploring the API

[Collections] Implementation of EnhancedDoubleHasher

The code in the implementation of the EnhancedDoubleHasher is based on the wikipedia article https://en.wikipedia.org/wiki/Double_hashing. The code that appears in the article is: struct key; /// Opaque /// Use other data types when needed. (Must be unsigned for guaranteed wrapping.) extern

Re: [Collections] Implementation of EnhancedDoubleHasher

Tracking this with: https://issues.apache.org/jira/browse/COLLECTIONS-855 On Sat, 18 May 2024 at 08:26, Alex Herbert wrote: > Thanks for highlighting this. I did not use the original paper and based > the implementation on Wikipedia. > > I think the issue is that we use i in [0, k); we can

Re: [Collections] Implementation of EnhancedDoubleHasher

Thanks for highlighting this. I did not use the original paper and based the implementation on Wikipedia. I think the issue is that we use i in [0, k); we can correct this by using i in [1, k]. The order inside the loop would not change but we would have to decrement i to use in the assignment

Re: [CLI] Deprecated options and helpformatting

Gary, I just realized this AM that there is a change I proposed to simplify the deprecated output. Please see pull request 277. I think the change from BiFormat to Format makes the HelpFormatter API much cleaner. Claude On Fri, May 17, 2024 at 6:26 PM Claude Warren wrote: > Gary, > > I

[Collections] Implementation of EnhancedDoubleHasher

The code in the implementation of the EnhancedDoubleHasher is based on the wikipedia article https://en.wikipedia.org/wiki/Double_hashing. The code that appears in the article is: struct key; /// Opaque /// Use other data types when needed. (Must be unsigned for guaranteed wrapping.) extern

Re: [CLI] Deprecated options and helpformatting

The RC is out. Gary On Fri, May 17, 2024 at 12:27 PM Claude Warren wrote: > > Gary, > > I think the CLI release candidate can be cut now. I didn't see any more > issues when I was fixing the code. So I am > +1 on cutting a release candidate. > > On Sun, May 12, 2024 at 8:49 PM Gary Gregory

[VOTE] Release Apache Commons CLI 1.8.0 based on RC1

We have fixed a few bugs and added enhancements since Apache Commons CLI 1.7.0 was released, so I would like to release Apache Commons CLI 1.8.0. Apache Commons CLI 1.8.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/cli/1.8.0-RC1 (svn revision 69270) The

[VOTE] Release Apache Commons Daemon 1.4.0 based on RC1

We have fixed a few bugs, added enhancements and updated the minimum Java and Windows version since Apache Commons Daemon 1.3.4 was released, so I would like to release Apache Commons Daemon 1.4.0. Apache Commons Daemon 1.4.0 RC1 is available for review here:

Re: [CLI] Deprecated options and helpformatting

Gary, I think the CLI release candidate can be cut now. I didn't see any more issues when I was fixing the code. So I am +1 on cutting a release candidate. On Sun, May 12, 2024 at 8:49 PM Gary Gregory wrote: > How does it look now? > > Would you check git master is OK, then I can cut a

  1   2   3   4   5   6   7   8   9   10   >