Github user jbduncan commented on the issue:
https://github.com/apache/commons-imaging/pull/29
Looks much better, thanks @TheRealHaui!
As I discussed in #28, I'm sure there's area for improvement on the
whitespace/readability front, but that would require running `mvn
Github user jbduncan commented on the issue:
https://github.com/apache/commons-text/pull/56
@TheRealHaui Yes, precisely. :)
(With hindsight, I should have used the word "violations" instead of
"cases"; it would have been clearer that I was ref
Github user jbduncan commented on the issue:
https://github.com/apache/commons-text/pull/56
Thanks @TheRealHaui!
I think handling the rest of the cases reported by Checkstyle should be
done in a separate PR (or series of PRs if needed) by whoever feels up to it.
---
If your
Github user jbduncan commented on the issue:
https://github.com/apache/commons-text/pull/56
Oh sorry @TheRealHaui, I just reread my main comment in my review from a
few minutes ago, and I realise that I may have sounded confrontational. I had
not meant to come across as such, so I
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854299
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -55,11 +55,11 @@ public void testExtendedFormats
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854120
--- Diff: src/test/java/org/apache/commons/text/AlphabetConverterTest.java
---
@@ -201,4 +207,97 @@ private void test(final Character[] originalChars
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855372
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -426,10 +517,13 @@ public void testSetFormatsByArgumentIndex
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127856024
--- Diff:
src/test/java/org/apache/commons/text/similarity/LevenshteinResultsTest.java ---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854963
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -353,10 +355,11 @@ private void checkBuiltInFormat(final String
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854991
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -353,10 +355,11 @@ private void checkBuiltInFormat(final String
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854930
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -338,10 +339,11 @@ private void checkBuiltInFormat(final String
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854888
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -338,10 +339,11 @@ private void checkBuiltInFormat(final String
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855769
--- Diff: src/test/java/org/apache/commons/text/StrSubstitutorTest.java ---
@@ -17,21 +17,16 @@
package org.apache.commons.text
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855540
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -476,8 +578,8 @@ public Format getFormat(final String name
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855137
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -373,14 +376,15 @@ private void checkBuiltInFormat(final String
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854015
--- Diff: src/test/java/org/apache/commons/text/AlphabetConverterTest.java
---
@@ -201,4 +207,97 @@ private void test(final Character[] originalChars
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854827
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -295,41 +295,42 @@ public void testEqualsHashcode
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127855604
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -488,10 +590,10 @@ public Format getFormat(final String name
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127780127
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782716
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -17,24 +17,22 @@
package
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781644
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127780455
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782811
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -66,6 +64,22 @@ protected File createTempFile
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782170
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127783301
--- Diff:
src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcTypeLookupTest.java
---
@@ -0,0 +1,28 @@
+package
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127783226
--- Diff:
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782622
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -17,24 +17,22 @@
package
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781095
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781035
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781676
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782199
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781398
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127782141
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/28#discussion_r127781871
--- Diff:
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
---
@@ -0,0 +1,36 @@
+package
Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/27#discussion_r127778422
--- Diff:
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java
---
@@ -66,6 +64,22 @@ protected File createTempFile
Github user jbduncan commented on the issue:
https://github.com/apache/commons-text/pull/49
It's not clear to me why the ordering of the imports has changed and why
all the `assert*()` method imports have been replaced with a wildcard import.
Are those intentional?
---
If your
Github user jbduncan commented on the issue:
https://github.com/apache/commons-text/pull/55
Revisiting this in 2.x sounds good to me!
The only other thought I have is that I think this should go up as a new
issue on Apache JIRA if it hasn't already.
Other than
Github user jbduncan commented on the issue:
https://github.com/apache/commons-text/pull/55
@ameyjadiye I don't know if there's a convention in Apache Commons for
preferring `new X.Builder()` over static factory methods like `X.builder()`,
but if there isn't, then I would encourage
38 matches
Mail list logo
