Hi Elijah,
The ‘Continue’ and ‘Completed’ values look very similar to me, especially
in Unit tests. I suggest naming the two states:
- Continue
- Finished
With regards to an enum for status, wouldn't it be better to use a class so
that consumers could subclass it and add their own states if
+1 to everything.
With regards to an enum for status, wouldn't it be better to use a class so
that consumers could subclass it and add their own states if needed?
Thanks,
-Elijah
On Sat, Jun 22, 2013 at 4:30 AM, Benedikt Ritter benerit...@gmail.comwrote:
Am 22.06.2013 um 12:57 schrieb
Hi Jonas,
I will provide a patch for
CHAIN-98https://issues.apache.org/jira/browse/CHAIN-98tomorow. The
patch will only cover the refactoring of CONTINUE and
COMPLETED processing results.
nice to read that, looking forward to the patch! :)
But, I do not understand how exceptions should
Am 22.06.2013 um 12:57 schrieb Simone Tripodi simonetrip...@apache.org:
Hi Jonas,
I will provide a patch for
CHAIN-98https://issues.apache.org/jira/browse/CHAIN-98tomorow. The
patch will only cover the refactoring of CONTINUE and
COMPLETED processing results.
nice to read that,
Thanks Jonas,
would you submit a patch for that? TIA!
-Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
On Thu, Jun 20, 2013 at 11:09 PM, Jonas Sprenger sprenger...@gmail.com wrote:
Hi guys,
so we talk about an enum 'PROCESSING' providing at least 3 states?
2013/6/21 Simone Tripodi simonetrip...@apache.org
Thanks Jonas,
would you submit a patch for that? TIA!
-Simo
http://people.apache.org/~simonetripodi/
http://twitter.com/simonetripodi
On Thu, Jun 20, 2013 at 11:09 PM, Jonas Sprenger sprenger...@gmail.com
wrote:
Hi guys,
so we
I'm not sure if we need ABORTED. What is the difference between COMPLETE
and ABORTED from the PoV of the Chain? Chain defines an algorithm for
processing and I currently don't see how ABORTED fits in there.
OTOH I see some potential here:
* COMPLETE: all chain commands have completed their
Hi Simone,
more meat as I expected, thats for sure.
I will provide a patch for
CHAIN-98https://issues.apache.org/jira/browse/CHAIN-98tomorow. The
patch will only cover the refactoring of CONTINUE and
COMPLETED processing results.
But, I do not understand how exceptions should be handled in this
Hi guys,
I had a look at the command interface and it's base classes yesterday, and
I think there is some work to do :) Here are the points I found:
* JavaDoc of Command says that commands have to be designed in a
thread-safe manner, yet all the base implementations are not thread safe! I
have
Hallo Bene,
* JavaDoc of Command says that commands have to be designed in a
thread-safe manner, yet all the base implementations are not thread safe! I
have created CHAIN-96 [1] for this, because this definitely has to be fixed
before 2.0
+1
* The same is true for o.a.c.chain2.Chain and
Hi guys,
so we talk about an enum 'PROCESSING' providing at least 3 states?
- CONTINUE
- COMPLETE
- ABORTED
Ticket CHAIN-98 https://issues.apache.org/jira/browse/CHAIN-98 has been
created to cover this task.
regards,
Jonas
2013/6/20 Simone Tripodi simonetrip...@apache.org
Hallo Bene,
*
11 matches
Mail list logo