Re: [CSV] remaining issues before 1.0

2013-06-24 Thread Benedikt Ritter
Hi Gary, thanks for pushing csv forward. I feel we are getting close to actually releasing something :-) 2013/6/24 Gary Gregory garydgreg...@gmail.com I've done a bit of fiddling with the code and JIRA. It seems the biggest issue is the builder API. Then there are remaining issues:

Re: [CSV] remaining issues before 1.0

2013-06-23 Thread Gary Gregory
I've done a bit of fiddling with the code and JIRA. It seems the biggest issue is the builder API. Then there are remaining issues: https://issues.apache.org/jira/issues/?jql=project%20%3D%20CSV%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20ORDER%20BY%20key%20ASC If

Re: [CSV] remaining issues before 1.0

2013-06-21 Thread Benedikt Ritter
Hi Gary, nice to see some activity in CSV again. We were talking about reverting CSVFormat back to the old API that does not use the builder pattern, see CSV-99[1]. We still have 18 unresolved issues. I think we should go through all those issues and decide if we want to have them in 1.0.

Re: [CSV] remaining issues before 1.0

2013-06-21 Thread sebb
On 21 June 2013 07:54, Benedikt Ritter brit...@apache.org wrote: Hi Gary, nice to see some activity in CSV again. We were talking about reverting CSVFormat back to the old API that does not use the builder pattern, see CSV-99[1]. We still have 18 unresolved issues. I think we should go

[CSV] remaining issues before 1.0

2013-06-20 Thread Gary Gregory
So... what are the remaining issues before 1.0? Are we happy with the current state of the API? Builder and all? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Editionhttp://www.manning.com/bauer3/ JUnit in Action, Second Edition

Re: [CSV] remaining issues before 1.0

2013-06-20 Thread Gary Gregory
Thoughts on this FindBugs issue: On Thu, Jun 20, 2013 at 10:28 AM, Gary Gregory garydgreg...@gmail.comwrote: So... what are the remaining issues before 1.0? Are we happy with the current state of the API? Builder and all? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org

Re: [CSV] remaining issues before 1.0

2013-06-20 Thread Gary Gregory
[oops, send previous msg too soon] FIndBugs reports: Immediate dereference of the result of readLine() in org.apache.commons.csv.CSVLexer.nextToken(Token) at line 89. Which I addressed in SVN but wanted to check with the ML just in case... Gary On Thu, Jun 20, 2013 at 10:28 AM, Gary