My +1.
Gary
On Wed, Jun 13, 2018 at 1:51 PM Gary Gregory wrote:
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons DBCP 2.3.0 was released, so I would like to release
> Apache Commons DBCP 2.4.0.
>
> Apache Commons DBCP 2.4.0 RC1 is available for rev
Hi Emmanuel,
Where you planning on reviewing further?
Gary
On Thu, Jun 14, 2018 at 4:59 AM Emmanuel Bourg wrote:
> Le 13/06/2018 à 21:51, Gary Gregory a écrit :
>
> > #Release SHA-1s
> > commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> > commons-dbcp2-2.4.0-null-jar
md5’s good, sha1’s good, sha256’s good, builds java 7, 8, 9, site good: +1
Nits. Coverage (known), Findbugs issues.
> On Jun 13, 2018, at 3:51 PM, Gary Gregory wrote:
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons DBCP 2.3.0 was released, so I
> On Jun 14, 2018, at 9:52 AM, Gary Gregory wrote:
>
> On Thu, Jun 14, 2018 at 7:44 AM Rob Tompkins wrote:
>
>>
>>
>>> On Jun 14, 2018, at 9:37 AM, Gary Gregory
>> wrote:
>>>
>>> On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory
>> wrote:
>>>
That is just a bug in the release plugin th
On Thu, Jun 14, 2018 at 7:44 AM Rob Tompkins wrote:
>
>
> > On Jun 14, 2018, at 9:37 AM, Gary Gregory
> wrote:
> >
> > On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory
> wrote:
> >
> >> That is just a bug in the release plugin that generated the vote text:
> it
> >> printed null for the Maven quali
> On Jun 14, 2018, at 9:37 AM, Gary Gregory wrote:
>
> On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory wrote:
>
>> That is just a bug in the release plugin that generated the vote text: it
>> printed null for the Maven qualifier when there is none (like "bin" for
>> some other files.)
>>
>
>
On Thu, Jun 14, 2018 at 6:59 AM Gary Gregory wrote:
> That is just a bug in the release plugin that generated the vote text: it
> printed null for the Maven qualifier when there is none (like "bin" for
> some other files.)
>
IOW, my email text was wrong those file names should not have "-null".
+1 (non-binding)
On Wed, Jun 13, 2018, 12:51 Gary Gregory wrote:
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons DBCP 2.3.0 was released, so I would like to release
> Apache Commons DBCP 2.4.0.
>
> Apache Commons DBCP 2.4.0 RC1 is available for rev
That is just a bug in the release plugin that generated the vote text: it
printed null for the Maven qualifier when there is none (like "bin" for
some other files.)
Gary
On Thu, Jun 14, 2018, 04:59 Emmanuel Bourg wrote:
> Le 13/06/2018 à 21:51, Gary Gregory a écrit :
>
> > #Release SHA-1s
> > c
Le 13/06/2018 à 21:51, Gary Gregory a écrit :
> #Release SHA-1s
> commons-dbcp2-2.4.0-null-pom.asc=df3fbc3dc6460cba003b16f8eba13ed3ffd8beef
> commons-dbcp2-2.4.0-null-jar.asc=3352f1b1ab04452445709d19272449bc5238d735
Are these "null" files excepted?
Emmanuel Bourg
---
ins a lot on winter, so possibly working on it next
weekend?).
Checked maven artifacts and dist area zips signatures, and they look OK.
Thanks for RM'ing.
Cheers
Bruno
From: Gary Gregory
To: Commons Developers List
Sent: Thursday, 14 June 2018 7:51 A
We have fixed quite a few bugs and added some significant enhancements
since Apache Commons DBCP 2.3.0 was released, so I would like to release
Apache Commons DBCP 2.4.0.
Apache Commons DBCP 2.4.0 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/dbcp/2.4.0-RC1 (
12 matches
Mail list logo
