Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-11 Thread Bruno Kinoshita
[X] +1 Release these artifacts Built from tag with no errors, on Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0) Maven home: /opt/apache-maven-3.8.5 Java version: 17.0.6, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64 Default locale: en_US, platform encoding:

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-09 Thread Mark Thomas
On 05/05/2023 11:27, Mark Thomas wrote: Please review the release candidate and vote. This vote will close no sooner than 72 hours from now.   [X] +1 Release these artifacts   [ ] +0 OK, but...   [ ] -0 OK, but really should fix...   [ ] -1 I oppose this release because... Mark

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-09 Thread Gary Gregory
Can we get more PMC reviews please? Gary On Fri, May 5, 2023, 06:27 Mark Thomas wrote: > We have fixed a few bugs since Apache Commons Daemon 1.3.3 was released, > so I would like to release Apache Commons Daemon 1.3.4. > > Apache Commons Daemon 1.3.4 RC1 is available for review here: >

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-06 Thread Gary Gregory
+1 Based on the src zip files (plain and native): ASC OK, SHA512 OK. Building the plain sources with the default Maven build OK with 'mvn' using: Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8) Maven home: /usr/local/Cellar/maven/3.9.1/libexec Java version: 1.8.0_372, vendor:

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-06 Thread Mark Thomas
On 06/05/2023 16:15, Gary D. Gregory wrote: FYI I seem to be building fine for me using "Microsoft (R) C/C++ Optimizing Compiler Version 19.35.32217.1 for x64" but maybe there is a gotcha I am missing? See the "Release Builds" section of the README.txt file in src/native/windows Mark

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-06 Thread Mark Thomas
On 06/05/2023 16:12, Gary D. Gregory wrote: Note a blocker but I imagine not true for this release: In the README.txt for the Windows native apps: "Release builds are build with Mladen Turk's (mturk) Custom Microsoft Compiler Toolkit Compilation. This can be obtained from:

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-06 Thread Gary D. Gregory
FYI I seem to be building fine for me using "Microsoft (R) C/C++ Optimizing Compiler Version 19.35.32217.1 for x64" but maybe there is a gotcha I am missing? Gary On 2023/05/06 15:12:56 "Gary D. Gregory" wrote: > Note a blocker but I imagine not true for this release: In the README.txt for >

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-06 Thread Gary D. Gregory
Note a blocker but I imagine not true for this release: In the README.txt for the Windows native apps: "Release builds are build with Mladen Turk's (mturk) Custom Microsoft Compiler Toolkit Compilation. This can be obtained from: https://github.com/mturk/cmsc Version: 15.0.44" Is this true for

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-05 Thread Mark Thomas
On 05/05/2023 11:32, Gary Gregory wrote: Empty the sense that I can't tell what's been fixed. That is what the change log is for (which the release notes reference). Since the public site still shows 1.3.3, you'll want:

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-05 Thread Gary Gregory
Empty the sense that I can't tell what's been fixed. Gary On Fri, May 5, 2023, 06:31 Gary Gregory wrote: > The release notes are empty. > > Gary > > On Fri, May 5, 2023, 06:27 Mark Thomas wrote: > >> We have fixed a few bugs since Apache Commons Daemon 1.3.3 was released, >> so I would like

Re: [VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-05 Thread Gary Gregory
The release notes are empty. Gary On Fri, May 5, 2023, 06:27 Mark Thomas wrote: > We have fixed a few bugs since Apache Commons Daemon 1.3.3 was released, > so I would like to release Apache Commons Daemon 1.3.4. > > Apache Commons Daemon 1.3.4 RC1 is available for review here: >

[VOTE] Release Apache Commons Daemon 1.3.4 based on RC1

2023-05-05 Thread Mark Thomas
We have fixed a few bugs since Apache Commons Daemon 1.3.3 was released, so I would like to release Apache Commons Daemon 1.3.4. Apache Commons Daemon 1.3.4 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/daemon/1.3.4-RC1 (svn revision 61662) The Git tag