Re: [VOTE] Release Apache Commons Pool 2.6.0 based on RC1

2018-07-06 Thread Gary Gregory
pdated git master from cglib 3.2.6 to 3.2.7 for 2.6.1-SNAPSHOT. Gary > > > Thanks > > Bruno > > ________ > From: Gary Gregory > To: Commons Developers List > Sent: Wednesday, 4 July 2018 10:28 AM > Subject: [VOTE] Release Apache Commons Pool 2.6.0

Re: [VOTE] Release Apache Commons Pool 2.6.0 based on RC1

2018-07-06 Thread Gary Gregory
My +1. Always looking for more reviews ;-) Gary On Tue, Jul 3, 2018 at 4:27 PM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Pool 2.5.0 was released, so I would like to release > Apache Commons Pool 2.6.0. > > Apache Commons

Re: [VOTE] Release Apache Commons Pool 2.6.0 based on RC1

2018-07-06 Thread Bruno P. Kinoshita
f cglib (we are updating to 3.2.6) http://search.maven.org/#artifactdetails%7Ccglib%7Ccglib%7C3.2.7%7Cjar Thanks Bruno From: Gary Gregory To: Commons Developers List Sent: Wednesday, 4 July 2018 10:28 AM Subject: [VOTE] Release Apache Commons Pool 2.6.0 based

Re: [VOTE] Release Apache Commons Pool 2.6.0 based on RC1

2018-07-05 Thread Rob Tompkins
+1, builds/tests on java 7, 8, 10.0.1 site works on 7 and 8. Signatures, Rat ok. Agree with Oliver’s nits. -Rob > On Jul 4, 2018, at 3:51 PM, Oliver Heger wrote: > > Build works fine with Java 8 on Windows 10. Artifacts and site look good. > > +1 > > One minor point I noticed is that

Re: [VOTE] Release Apache Commons Pool 2.6.0 based on RC1

2018-07-04 Thread Gary Gregory
On Wed, Jul 4, 2018 at 1:51 PM Oliver Heger wrote: > Build works fine with Java 8 on Windows 10. Artifacts and site look good. > > +1 > Thank you for your review Oliver. > > One minor point I noticed is that the release notes say that "Version 2 > requires JDK level 1.6 or above", but the

Re: [VOTE] Release Apache Commons Pool 2.6.0 based on RC1

2018-07-04 Thread Oliver Heger
Build works fine with Java 8 on Windows 10. Artifacts and site look good. +1 One minor point I noticed is that the release notes say that "Version 2 requires JDK level 1.6 or above", but the minimum JDK for 2.6 is 1.7. There are also a few checkstyle errors that could be fixed with not too much

[VOTE] Release Apache Commons Pool 2.6.0 based on RC1

2018-07-03 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Pool 2.5.0 was released, so I would like to release Apache Commons Pool 2.6.0. Apache Commons Pool 2.6.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/pool/2.6.0-RC1