Re: [VOTE] Release DBCP 2.2 based on RC1

Fine with me. You should send a [VOTE][RESULT] thread. I'm happy to change my vote to -1 to if you want to make it official. Gary On Tue, Aug 2, 2016 at 12:52 PM, Matt Sicker wrote: > I'd like to cancel this release and start RC2 if there are no objections. > > On 2 August

Re: [VOTE] Release DBCP 2.2 based on RC1

I'd like to cancel this release and start RC2 if there are no objections. On 2 August 2016 at 14:41, Matt Sicker wrote: > Minor issue in the changelog: DBCP-452 has an "unknown" type due to a typo > in the word "type" in the xml. I'll fix that with DBCP-454. > > On 2 August

Re: [VOTE] Release DBCP 2.2 based on RC1

Minor issue in the changelog: DBCP-452 has an "unknown" type due to a typo in the word "type" in the xml. I'll fix that with DBCP-454. On 2 August 2016 at 13:48, Matt Sicker wrote: > Oh cool, I found an earlier issue I duplicated. >

Re: [VOTE] Release DBCP 2.2 based on RC1

Oh cool, I found an earlier issue I duplicated. https://issues.apache.org/jira/browse/DBCP-454 On 2 August 2016 at 13:01, Matt Sicker wrote: > I'm working on a fix for DBCP-465 (the fix is done, the test is still > being worked on as I've never used pax-exam before). With that

Re: [VOTE] Release DBCP 2.2 based on RC1

I'm working on a fix for DBCP-465 (the fix is done, the test is still being worked on as I've never used pax-exam before). With that in mind, I'm voting -1 (non-binding) for this release candidate. On 2 August 2016 at 11:51, Matt Sicker wrote: > I've created

Re: [VOTE] Release DBCP 2.2 based on RC1

I've created . Can we fix this and make a new release candidate, or is this release going to pass the vote technically? On 1 August 2016 at 17:53, Matt Sicker wrote: > It very well could be. The basic OSGi tests in log4j could

Re: [VOTE] Release DBCP 2.2 based on RC1

It very well could be. The basic OSGi tests in log4j could work here as this would have failed such a test. On 1 August 2016 at 16:13, Gary Gregory wrote: > On Mon, Aug 1, 2016 at 2:09 PM, Matt Sicker wrote: > > > There's something wrong with the OSGi

Re: [VOTE] Release DBCP 2.2 based on RC1

On Mon, Aug 1, 2016 at 2:09 PM, Matt Sicker wrote: > There's something wrong with the OSGi manifest. javax.transaction is > imported twice in the manifest and that causes an error at runtime. I need > to investigate further, but this could be a blocker. > Could this be added

Re: [VOTE] Release DBCP 2.2 based on RC1

There's something wrong with the OSGi manifest. javax.transaction is imported twice in the manifest and that causes an error at runtime. I need to investigate further, but this could be a blocker. On 1 August 2016 at 14:55, Oliver Heger wrote: > Build works fine

Re: [VOTE] Release DBCP 2.2 based on RC1

Build works fine with Java 1.7 and 1.8 on Windows 10. Artifacts and site look good. +1, great work! Oliver Am 31.07.2016 um 00:15 schrieb Matt Sicker: > We have fixed quite aWe have fixed quite a few bugs and added some > significant enhancements since DBCP 2.1.1 was released, so I would like

Re: [VOTE] Release DBCP 2.2 based on RC1

Looks like the sidebar on the site needs a link to the 2.2 javadocs. However, there is a link to the javadocs on the home page, so it's not inaccessible. On 31 July 2016 at 07:09, Benedikt Ritter wrote: > Hello Matt, > > good work pushing your first RC at Apache Commons! > >

Re: [VOTE] Release DBCP 2.2 based on RC1

Hello Matt, good work pushing your first RC at Apache Commons! - signs and hashes look good - website looks good - build works with Java 7 and Java 8 Minor nits: - release notes don't document minimum required Java version - release pom points to

Re: [VOTE] Release DBCP 2.2 based on RC1

+1 Tested with: Apache Maven 3.4.0-SNAPSHOT (90f26c279af9738735be8f84f60dcf21b6244e24; 2016-07-22T08:23:04-07:00) Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\.. Java version: 1.7.0_79, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_79\jre Default locale: en_US,

[VOTE] Release DBCP 2.2 based on RC1

We have fixed quite aWe have fixed quite a few bugs and added some significant enhancements since DBCP 2.1.1 was released, so I would like to release DBCP 2.2. This is my first release on Apache Commons, so please take a close look at everything as it's been almost two years since I've been an RM