Re: [collections] BloomFilter or BitSet functions?

2019-10-13 Thread Gilles Sadowski
Hello. Le dim. 13 oct. 2019 à 21:49, Claude Warren a écrit : > > I did some work on the BloomFiltersFunction idea and found that moving the > hamming distance and approximate log methods out of the BloomFilter > interface made implementation much easier and cleaner. In fact, all the > calls in

Re: [collections] BloomFilter or BitSet functions?

2019-10-13 Thread Claude Warren
I did some work on the BloomFiltersFunction idea and found that moving the hamming distance and approximate log methods out of the BloomFilter interface made implementation much easier and cleaner. In fact, all the calls in my code that is utilizing the proposed contribution got simpler. I now

Re: [collections] BloomFilter or BitSet functions?

2019-10-13 Thread Claude Warren
I believe the functions should be in a separate class as it increases the separation of concerns. The methods are used in Bloom Filter manipulation and analysis but are not specific to bloom filters. They are in fact specific to bit vectors. My original thought was to create a function class

Re: [collections] BloomFilter or BitSet functions?

2019-10-10 Thread Gilles Sadowski
Hello. Le lun. 7 oct. 2019 à 19:42, Claude Warren a écrit : > > As noted earlier I am preparing a contribution of Bloom Filter classes to > the collections module. As part of this submission there are several > methods that operate on BitSets that are used as part of Bloom Filter >

[collections] BloomFilter or BitSet functions?

2019-10-07 Thread Claude Warren
As noted earlier I am preparing a contribution of Bloom Filter classes to the collections module. As part of this submission there are several methods that operate on BitSets that are used as part of Bloom Filter manipulation and analysis. My question is, should these be contributed as Bloom