Re: [compress] Bugs fixed - review and release?

2009-04-28 Thread Christian Grobmeier
Oh, BTW, I don't see any other issues preventing the 1.0 release. thanks all, that was quick! I already read the releases wiki site and will dive into it a bit more now. I am quite sure I will need help :-) Cheers, Christian -

[compress] Bugs fixed - review and release?

2009-04-27 Thread Christian Grobmeier
Hi all, we have fixed all bugs we mentioned for 1.0 release. The API looks quite good for my eyes (even when Sebastian finds some stuff here and there :-)) and I would like to think about a release again. Is there anything speaking against this step? Anything we really need to do before

Re: [compress] Bugs fixed - review and release?

2009-04-27 Thread sebb
On 27/04/2009, Christian Grobmeier grobme...@gmail.com wrote: Hi all, we have fixed all bugs we mentioned for 1.0 release. The API looks quite good for my eyes (even when Sebastian finds some stuff here and there :-)) and I would like to think about a release again. Is there anything

Re: [compress] Bugs fixed - review and release?

2009-04-27 Thread Torsten Curdt
+1 on all of that cheers -- Torsten On Mon, Apr 27, 2009 at 17:23, sebb seb...@gmail.com wrote: On 27/04/2009, Christian Grobmeier grobme...@gmail.com wrote: Hi all,  we have fixed all bugs we mentioned for 1.0 release. The API looks  quite good  for my eyes (even when Sebastian finds some

Re: [compress] Bugs fixed - review and release?

2009-04-27 Thread Christian Grobmeier
The only minor issue I have is with finish() and close(). I think it is going to be annoying for users to have to call finish() separately from close(). I would prefer to see finish() being optional, i.e. close() should call it if necessary. But the code should check to make sure that

Re: [compress] Bugs fixed - review and release?

2009-04-27 Thread sebb
On 27/04/2009, Christian Grobmeier grobme...@gmail.com wrote: The only minor issue I have is with finish() and close(). I think it is going to be annoying for users to have to call finish() separately from close(). I would prefer to see finish() being optional, i.e. close() should

Re: [compress] Bugs fixed - review and release?

2009-04-27 Thread Christian Grobmeier
Just remembered - what about ZipArchiveInputStream.useUnicodeExtraFields? This field is currently unused - what are the plans for it? Maybe just add a JIRA so it is not overlooked? yes, definitly! I found before a few days and forgot about it agian. Will create ticket for it. I have update

Re: [compress] Bugs fixed - review and release?

2009-04-27 Thread sebb
On 27/04/2009, Christian Grobmeier grobme...@gmail.com wrote: Just remembered - what about ZipArchiveInputStream.useUnicodeExtraFields? This field is currently unused - what are the plans for it? Maybe just add a JIRA so it is not overlooked? yes, definitly! I found before a few days

Re: [compress] Bugs fixed - review and release?

2009-04-27 Thread sebb
On 27/04/2009, sebb seb...@gmail.com wrote: On 27/04/2009, Christian Grobmeier grobme...@gmail.com wrote: Just remembered - what about ZipArchiveInputStream.useUnicodeExtraFields? This field is currently unused - what are the plans for it? Maybe just add a JIRA so it is not

Re: [compress] Bugs fixed - review and release?

2009-04-27 Thread sebb
On 27/04/2009, sebb seb...@gmail.com wrote: On 27/04/2009, sebb seb...@gmail.com wrote: On 27/04/2009, Christian Grobmeier grobme...@gmail.com wrote: Just remembered - what about ZipArchiveInputStream.useUnicodeExtraFields? This field is currently unused - what are the plans

Re: [compress] Bugs fixed - review and release?

2009-04-27 Thread Stefan Bodewig
On 2009-04-27, sebb seb...@gmail.com wrote: Just remembered - what about ZipArchiveInputStream.useUnicodeExtraFields? This field is currently unused - what are the plans for it? It should never have been unimplemented at all 8-) This was the last piece I wanted to do while working on the code