Re: [compress] ZIP - encoding of file names - again

2009-02-19 Thread Stefan Bodewig
On 2009-02-18, Wolfgang Glas wolfgang.g...@ev-i.at wrote: Stefan Bodewig schrieb: Wolfgang, you may notice a few minor tweaks to your original code. Do you happen to have stand-alone tests for the Unicode extra fields anywhere? A rudimentary test is in my original patch as attached to

Re: [compress] ZIP - encoding of file names - again

2009-02-19 Thread Stefan Bodewig
On 2009-02-19, Stefan Bodewig bode...@apache.org wrote: On 2009-02-18, Wolfgang Glas wolfgang.g...@ev-i.at wrote: A rudimentary test is in my original patch as attached to SANDBOX-176. I have refactored this test to the current SVN revision an attached to this mail. Thanks, I've modified

Re: [compress] ZIP - encoding of file names - again

2009-02-19 Thread Stefan Bodewig
On 2009-02-18, Stefan Bodewig bode...@apache.org wrote: UTF-8 is now the default for ZipArchiveOutputStream and ZipFile, EFS support is not yet in. Now it is. I combined Wolfgang's patch for EFS with one by TAMURA Kent to Ant https://issues.apache.org/bugzilla/show_bug.cgi?id=45548 and

Re: [compress] ZIP - encoding of file names - again

2009-02-18 Thread Stefan Bodewig
I started to take some baby steps implementing it, in particular On 2009-02-13, Stefan Bodewig bode...@apache.org wrote: Currently I think the best default approach would be to use UTF-8 as the default encoding and set the EFS bit since this will create archives compatible with java.util.zip

Re: [compress] ZIP - encoding of file names - again

2009-02-18 Thread Wolfgang Glas
Stefan Bodewig schrieb: I started to take some baby steps implementing it, in particular On 2009-02-13, Stefan Bodewig bode...@apache.org wrote: Currently I think the best default approach would be to use UTF-8 as the default encoding and set the EFS bit since this will create archives

[compress] ZIP - encoding of file names - again

2009-02-13 Thread Stefan Bodewig
Let me try to capture the various threads in SANDBOX-176 and from this list into something we can draw conclusions from. First some background: == when I implemented the ZIP classes for Ant, I was working from InfoZIP's documentation of the format, not PKWARE's, I've now read

Re: [compress] ZIP - encoding of file names - again

2009-02-13 Thread Wolfgang Glas
Hi Stefan, My comments follow. Stefan Bodewig schrieb: Let me try to capture the various threads in SANDBOX-176 and from this list into something we can draw conclusions from. First some background: == [snip] Reading === Let's keep ZipArchiveInputStream out

Re: [compress] ZIP - encoding of file names - again

2009-02-13 Thread Stefan Bodewig
On 2009-02-13, Wolfgang Glas wolfgang.g...@ev-i.at wrote: Stefan Bodewig schrieb: Reading === The question is what ZipFile should assume as its default if neither the EFS nor extra fields are present. This can be controlled by setEncoding right now and defaults to the platform's