Re: [configuration] Checkstyle warning about double-checked locking in DynamicCombinedConfiguration

2012-07-30 Thread Oliver Heger
Am 29.07.2012 22:41, schrieb Ralph Goers: I used that specifically to avoid creating multiple combined configurations since it can be fairly expensive to create them. I looked into the guarantees that ConcurrentMap provides before I implemented that and included the comment since I knew it

Re: [configuration] Checkstyle warning about double-checked locking in DynamicCombinedConfiguration

2012-07-30 Thread sebb
On 30 July 2012 20:34, Oliver Heger oliver.he...@oliver-heger.de wrote: Am 29.07.2012 22:41, schrieb Ralph Goers: I used that specifically to avoid creating multiple combined configurations since it can be fairly expensive to create them. I looked into the guarantees that ConcurrentMap

Re: [configuration] Checkstyle warning about double-checked locking in DynamicCombinedConfiguration

2012-07-30 Thread Ralph Goers
On Jul 30, 2012, at 2:10 PM, sebb wrote: On 30 July 2012 20:34, Oliver Heger oliver.he...@oliver-heger.de wrote: Am 29.07.2012 22:41, schrieb Ralph Goers: I used that specifically to avoid creating multiple combined configurations since it can be fairly expensive to create them. I looked

Re: [configuration] Checkstyle warning about double-checked locking in DynamicCombinedConfiguration

2012-07-30 Thread sebb
On 30 July 2012 22:13, Ralph Goers ralph.go...@dslextreme.com wrote: On Jul 30, 2012, at 2:10 PM, sebb wrote: On 30 July 2012 20:34, Oliver Heger oliver.he...@oliver-heger.de wrote: Am 29.07.2012 22:41, schrieb Ralph Goers: I used that specifically to avoid creating multiple combined

Re: [configuration] Checkstyle warning about double-checked locking in DynamicCombinedConfiguration

2012-07-30 Thread Ralph Goers
On Jul 30, 2012, at 2:17 PM, sebb wrote: On 30 July 2012 22:13, Ralph Goers ralph.go...@dslextreme.com wrote: On Jul 30, 2012, at 2:10 PM, sebb wrote: On 30 July 2012 20:34, Oliver Heger oliver.he...@oliver-heger.de wrote: Am 29.07.2012 22:41, schrieb Ralph Goers: I used that

Re: [configuration] Checkstyle warning about double-checked locking in DynamicCombinedConfiguration

2012-07-30 Thread sebb
On 30 July 2012 22:49, Ralph Goers ralph.go...@dslextreme.com wrote: On Jul 30, 2012, at 2:17 PM, sebb wrote: On 30 July 2012 22:13, Ralph Goers ralph.go...@dslextreme.com wrote: On Jul 30, 2012, at 2:10 PM, sebb wrote: On 30 July 2012 20:34, Oliver Heger oliver.he...@oliver-heger.de

[configuration] Checkstyle warning about double-checked locking in DynamicCombinedConfiguration

2012-07-29 Thread Oliver Heger
There is a checkstyle warning about double-checked locking in method DynamicCombinedConfiguration.getCurrentConfig(). Indeed, the double-check locking idiom is used, however, there is a comment saying that this safe due to the usage of a ConcurrentMap. This may be true, but I wonder whether

Re: [configuration] Checkstyle warning about double-checked locking in DynamicCombinedConfiguration

2012-07-29 Thread Ralph Goers
I used that specifically to avoid creating multiple combined configurations since it can be fairly expensive to create them. I looked into the guarantees that ConcurrentMap provides before I implemented that and included the comment since I knew it would catch someone's eye. Ralph On Jul