The last time I tried to RM a Commons project, I had a lot of blockers. I'm
not sure if they were all resolved.
Anyways, I may have time to try that out tomorrow. Otherwise, most of this
week is taken up by a hackathon going on at work.
On 11 November 2017 at 14:57, Gary Gregory
I was able to build master commons-dbcp based on commons-pool2
master/2.5.0-SNAPSHOT. All tests pass in both builds :-)
Do you have time to push out a release commons-pool2 release? A branch for
2.4.4 or master for 2.5.0, either way would be OK with me.
Gary
On Fri, Nov 10, 2017 at 2:17 PM,
Oh, I may have missed that since it didn't follow the naming scheme of all
the other tags.
On 10 November 2017 at 13:33, Gary Gregory wrote:
> I mean "Hi Matt" !
>
> On Fri, Nov 10, 2017 at 12:32 PM, Gary Gregory
> wrote:
>
> > Hi Amtt,
> >
> >
Hi Amtt,
The tags are:
POOL_2.4.3
POOL_2.4.3-RC1
Gary
On Fri, Nov 10, 2017 at 10:40 AM, Matt Sicker wrote:
> Added in https://issues.apache.org/jira/browse/POOL-335
>
> There's no git tag for 2.4.3, so I can't really even find a way to backport
> the option as it is.
>
> On
Added in https://issues.apache.org/jira/browse/POOL-335
There's no git tag for 2.4.3, so I can't really even find a way to backport
the option as it is.
On 5 November 2017 at 22:01, Matt Sicker wrote:
> I probably can, yeah. Totally slipped my mind about this, though!
>
> On
I probably can, yeah. Totally slipped my mind about this, though!
On 5 November 2017 at 21:46, Gary Gregory wrote:
> Hi Matt,
>
> Any chance you get take a look this week?
>
> Gary
>
> On Tue, Oct 31, 2017 at 10:58 AM, Mark Thomas wrote:
>
> > On
Hi Matt,
Any chance you get take a look this week?
Gary
On Tue, Oct 31, 2017 at 10:58 AM, Mark Thomas wrote:
> On 31/10/17 14:44, Gary Gregory wrote:
> > On Tue, Oct 31, 2017 at 8:33 AM, Matt Sicker wrote:
> >
> >> On 31 October 2017 at 04:21, Mark Thomas
On 31/10/17 14:44, Gary Gregory wrote:
> On Tue, Oct 31, 2017 at 8:33 AM, Matt Sicker wrote:
>
>> On 31 October 2017 at 04:21, Mark Thomas wrote:
>>>
>>> If the methods are required then that makes 2.4.3 broken in my view. In
>>> which case we should wait for
On Tue, Oct 31, 2017 at 8:33 AM, Matt Sicker wrote:
> On 31 October 2017 at 04:21, Mark Thomas wrote:
> >
> > If the methods are required then that makes 2.4.3 broken in my view. In
> > which case we should wait for 2.4.4 before updating the version DBCP
> >
On 31 October 2017 at 04:21, Mark Thomas wrote:
>
> If the methods are required then that makes 2.4.3 broken in my view. In
> which case we should wait for 2.4.4 before updating the version DBCP
> depends on. I don't think we should adapt the test. The test is telling
> us
to add back the previous behaviour, which means the tests would be
fixed without my pull request anyway :)
Cheers
Bruno
From: Mark Thomas <ma...@apache.org>
To: Commons Developers List <dev@commons.apache.org>
Sent: Tuesday, 31 October 2017 10:21 PM
Subj
On 31/10/2017 00:54, Gary Gregory wrote:
> On Sun, Oct 29, 2017 at 2:09 AM, Mark Thomas wrote:
>
>> On 29 October 2017 03:54:40 GMT+00:00, "Bruno P. Kinoshita" <
>> brunodepau...@yahoo.com.br.INVALID> wrote:
>>> Hi Gary,
>>>
>>> Started the tests in Maven command line, found
look at the changes report for 2.4.3 but it wasn't there yet.
> >ps2: I'm currently looking at those trivial checkstyle issues that we
> >found during the vote thread. Going to send another pull request for
> >that today
> >
> >
> >
> >
&
Yes, thank you Matt. As mentioned previously on this thread, the missing
method information can make it fiendishly difficult to track resource leaks.
Gary
On Mon, Oct 30, 2017 at 10:50 AM, Matt Sicker wrote:
> Yes, I can look into this over the next couple days. I'd imagine
Yes, I can look into this over the next couple days. I'd imagine this
should be configurable whether you want just the class or if you need more
info for leakage detection.
On 30 October 2017 at 10:31, Gary Gregory wrote:
> Hi Matt,
>
> Can you provide a patch to add an
Hi Matt,
Can you provide a patch to add an option to restore the behavior from we
had in 2.4.2?
Gary
On Sun, Oct 29, 2017 at 2:32 PM, Matt Sicker wrote:
> It's been a while since I looked at that, but from what I can tell, if the
> method name needs to be tracked as well as
It's been a while since I looked at that, but from what I can tell, if the
method name needs to be tracked as well as the class name, then the
SecurityManager solution isn't practical at all. Pre Java 9 would need to
use a Throwable no matter what, while Java 9+ can use StackWalker.
On 29 October
On Oct 29, 2017 02:21, "Pascal Schumacher" wrote:
Am 29.10.2017 um 09:09 schrieb Mark Thomas:
> On 29 October 2017 03:54:40 GMT+00:00, "Bruno P. Kinoshita" <
> brunodepau...@yahoo.com.br.INVALID> wrote:
>
>> Hi Gary,
>>
>> Started the tests in Maven command line, found
anything. Not an important change anyway.
Thanks again
Bruno
From: Mark Thomas <ma...@apache.org>
To: Commons Developers List <dev@commons.apache.org>
Sent: Sunday, 29 October 2017 9:09 PM
Subject: Re: [dbcp] update to pool 2.4.3.
On 29 October 2017 03:
Am 29.10.2017 um 09:09 schrieb Mark Thomas:
On 29 October 2017 03:54:40 GMT+00:00, "Bruno P. Kinoshita"
wrote:
Hi Gary,
Started the tests in Maven command line, found which tests failed.
Executed the tests in Eclipse, found which class was related to the
>ps2: I'm currently looking at those trivial checkstyle issues that we
>found during the vote thread. Going to send another pull request for
>that today
>
>
>
>
>From: Gary Gregory <garydgreg...@gmail.com>
>To: Commons Developers L
for that today
From: Gary Gregory <garydgreg...@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Sent: Sunday, 29 October 2017 8:44 AM
Subject: [dbcp] update to pool 2.4.3.
Hi All,
After updating dbcp to 2.4.3 I am seeing two unit test fail
Hi All,
After updating dbcp to 2.4.3 I am seeing two unit test failures. I have to
step out for the day and I am hoping someone can help figure out what is
going on.
Gary
23 matches
Mail list logo