Re: svn commit: r1729274 [3/7] - in /commons/proper/dbcp/trunk/src: main/java/org/apache/commons/dbcp2/ main/java/org/apache/commons/dbcp2/cpdsadapter/ main/java/org/apache/commons/dbcp2/datasources/

2016-02-08 Thread Gary Gregory
On Feb 8, 2016 3:17 PM, "Emmanuel Bourg" wrote: > > Le 8/02/2016 23:51, Gary Gregory a écrit : > > > It's simpler to be consistent when using final IMO. The intent is the same: > > https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/ > > "The road to hell is

Re: [DBCP] BasicDataSource and Referenceable

2016-02-05 Thread Phil Steitz
On 2/4/16 5:25 PM, Gary Gregory wrote: > Hi All: > > Why does BasicDataSource not implement Referenceable? I vaguely remember asking that question some years ago and considering adding this. I don't see any technical reason why it could not. The InstanceKeyDataSources do.I suspect the

[DBCP] Unit test failure with stack logging

2016-02-04 Thread Gary Gregory
I get the following failures running trunk from Eclipse. Anyone else? java (9) org.apache.commons.dbcp2.TestBasicDataSource testMaxConnLifetimeExceeded(org.apache.commons.dbcp2.TestBasicDataSource) java.lang.NullPointerException at

[DBCP] BasicDataSource and Referenceable

2016-02-04 Thread Gary Gregory
Hi All: Why does BasicDataSource not implement Referenceable? Merci, Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in

Re: [DBCP] Plan for 2.2

2015-11-02 Thread Mark Thomas
On 01/11/2015 22:10, Phil Steitz wrote: > There are a few open issues that I would appreciate some feedback / > patches for so we can start rolling 2.2 RCs. > > DBCP-448: I am leaning toward the resolution that I suggested in > the ticket (basically have a config option that makes

Re: [DBCP] Plan for 2.2

2015-11-01 Thread Gary Gregory
On Sun, Nov 1, 2015 at 2:10 PM, Phil Steitz <phil.ste...@gmail.com> wrote: > There are a few open issues that I would appreciate some feedback / > patches for so we can start rolling 2.2 RCs. > > DBCP-448: I am leaning toward the resolution that I suggested in > the t

[DBCP] Plan for 2.2

2015-11-01 Thread Phil Steitz
There are a few open issues that I would appreciate some feedback / patches for so we can start rolling 2.2 RCs. DBCP-448: I am leaning toward the resolution that I suggested in the ticket (basically have a config option that makes the properties effectively write-only). Any better ideas? DBCP

Re: [dbcp][all] package-import specs for osgi

2015-08-19 Thread Phil Steitz
On 8/19/15 3:35 AM, Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: Can I get someone with a little more osgi and maven knowledge to have a look at DBCP-445? I would appreciate feedback on whether the suggested fix is a good idea and how to get maven to do it if it is. Thanks, Jörg! Now

Re: [dbcp][all] package-import specs for osgi

2015-08-19 Thread Jörg Schaible
Hi Phil, Phil Steitz wrote: On 8/19/15 3:35 AM, Jörg Schaible wrote: Hi Phil, Phil Steitz wrote: Can I get someone with a little more osgi and maven knowledge to have a look at DBCP-445? I would appreciate feedback on whether the suggested fix is a good idea and how to get maven to do

Re: [dbcp][all] package-import specs for osgi

2015-08-19 Thread Jörg Schaible
Hi Phil, Phil Steitz wrote: Can I get someone with a little more osgi and maven knowledge to have a look at DBCP-445? I would appreciate feedback on whether the suggested fix is a good idea and how to get maven to do it if it is. Here's at least the Maven part

[dbcp][all] package-import specs for osgi

2015-08-18 Thread Phil Steitz
Can I get someone with a little more osgi and maven knowledge to have a look at DBCP-445? I would appreciate feedback on whether the suggested fix is a good idea and how to get maven to do it if it is. Thanks! Phil

[ANNOUNCEMENT] Apache Commons DBCP 2.1.1 released

2015-08-07 Thread Phil Steitz
The Apache Commons Team is pleased to announce the release of Apache Commons DBCP 2.1.1. The Apache Commons DBCP open source software library implements database connection pooling. Version 2.1.1 is a patch release, including bug fixes only. Full details of all the changes in version 2.1.1 can

[RESULT] [VOTE] Release DBCP 2.1.1 based on RC1

2015-08-06 Thread Phil Steitz
This vote has passed, with binding +1 votes from Phil Steitz Gary Gregory Oliver Heger Luc Maisonobe Jörg Schaible Thanks! Phil On 8/2/15 10:09 PM, Phil Steitz wrote: This is a vote to release version 2.1.1 of Apache Commons DBCP based on RC1. Here is the release candidate: https

[VOTE] Release DBCP 2.1.1 based on RC1

2015-08-05 Thread Phil Steitz
Closes in about 12 hours - more review / votes welcome :) Phil On 8/2/15 10:09 PM, Phil Steitz wrote: This is a vote to release version 2.1.1 of Apache Commons DBCP based on RC1. Here is the release candidate: https://dist.apache.org/repos/dist/dev/commons/dbcp/ (r10048) Built from

Re: [VOTE] Release DBCP 2.1.1 based on RC1

2015-08-05 Thread Luc Maisonobe
Le 03/08/2015 07:09, Phil Steitz a écrit : This is a vote to release version 2.1.1 of Apache Commons DBCP based on RC1. Here is the release candidate: https://dist.apache.org/repos/dist/dev/commons/dbcp/ (r10048) Built from: https://svn.apache.org/repos/asf/commons/proper/dbcp/tags

Re: [VOTE] Release DBCP 2.1.1 based on RC1

2015-08-05 Thread Jörg Schaible
Phil Steitz wrote: This is a vote to release version 2.1.1 of Apache Commons DBCP based on RC1. Here is the release candidate: https://dist.apache.org/repos/dist/dev/commons/dbcp/ (r10048) Built from: https://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_2_1_1_RC1/ (r1693845

Re: [VOTE] Release DBCP 2.1.1 based on RC1

2015-08-03 Thread Gary Gregory
DBCP based on RC1. Here is the release candidate: https://dist.apache.org/repos/dist/dev/commons/dbcp/ (r10048) Built from: https://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_2_1_1_RC1/ (r1693845) Release notes: https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE

Re: [VOTE] Release DBCP 2.1.1 based on RC1

2015-08-03 Thread Phil Steitz
Here is my +1 Phil On 8/2/15 10:09 PM, Phil Steitz wrote: This is a vote to release version 2.1.1 of Apache Commons DBCP based on RC1. Here is the release candidate: https://dist.apache.org/repos/dist/dev/commons/dbcp/ (r10048) Built from: https://svn.apache.org/repos/asf/commons/proper

Re: [VOTE] Release DBCP 2.1.1 based on RC1

2015-08-03 Thread Oliver Heger
Maven and ant builds are successful with Java 1.7 and 1.8 on Windows 8.1. Artifacts and site look good. +1 Oliver Am 03.08.2015 um 07:09 schrieb Phil Steitz: This is a vote to release version 2.1.1 of Apache Commons DBCP based on RC1. Here is the release candidate: https://dist.apache.org

Re: [dbcp] aborting abandoned connections

2015-08-02 Thread Phil Steitz
On 7/27/15 1:42 PM, Bernd Eckenfels wrote: Hello, I was investigating the behavior of dbcp in regards to killing longrunning/hanging statements (specifically for the Oracle driver). Oracle driver synchronizes on the physical connection for some things like connection.close

[VOTE] Release DBCP 2.1.1 based on RC1

2015-08-02 Thread Phil Steitz
This is a vote to release version 2.1.1 of Apache Commons DBCP based on RC1. Here is the release candidate: https://dist.apache.org/repos/dist/dev/commons/dbcp/ (r10048) Built from: https://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_2_1_1_RC1/ (r1693845) Release notes: https

[dbcp] aborting abandoned connections

2015-07-27 Thread Bernd Eckenfels
Hello, I was investigating the behavior of dbcp in regards to killing longrunning/hanging statements (specifically for the Oracle driver). Oracle driver synchronizes on the physical connection for some things like connection.close() or statement.close() or .isClosed() or the vendor specific

[dbcp] 2.2 plan - feedback requested

2015-07-12 Thread Phil Steitz
There are a few decisions to make before we start rolling RCs for DBCP 2.2. I would appreciate feedback / patches for the following: DBCP-436 Seems a reasonable request but hard to implement and test. I would say either WONT_FIX or bump to 3.0. I am curious about how important this actually

Re: [dbcp] pick up new [pool]

2015-06-01 Thread Phil Steitz
On 6/1/15 8:43 AM, Gary Gregory wrote: Now that [pool] 2.4.1 is out, it would be nice to push a [dbcp] release to match it up. Gary Yes, to do this, we need a fix for DBCP-438 and a decision on DBCP-436. Phil

[dbcp] pick up new [pool]

2015-06-01 Thread Gary Gregory
Now that [pool] 2.4.1 is out, it would be nice to push a [dbcp] release to match it up. Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition http://www.manning.com/bauer3/ JUnit in Action, Second Edition http://www.manning.com/tahchiev

Re: [dbutils][dbcp] SQL states

2015-04-23 Thread Phil Steitz
for handling and generating SQL states in your apps? Do you know of a good FOSS code base out there that deals with this? Well, it ain't exactly OO-heavenly but as of 2.1, [dbcp] does deal with states, at least the ones that signal connection badness. See DBCP-427. Phil Merci! Gary

[dbutils][dbcp] SQL states

2015-04-22 Thread Gary Gregory
Hi All: JDBC's SQLException has a String SQLState field. I have a need for a formal OO SQLState class and I've started to hack up something very limited for the purpose our app. I feels hacky and less than satisfactory ATM. I wonder: What do you do for handling and generating SQL states in your

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-03-15 Thread Phil Steitz
On 1/3/15 4:26 PM, Thomas Neidhart wrote: On 01/03/2015 06:49 PM, Phil Steitz wrote: On 1/3/15 7:11 AM, Thomas Neidhart wrote: On 01/02/2015 10:45 PM, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-03-15 Thread Thomas Neidhart
/ extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing and / or presenting either of these. Is anyone else interested in working on a talk on either of these? Any suggestions on content? For [math] I have always wanted to do a high level

Re: [dbcp] dbcp, pool and SQLWarnings.

2015-03-03 Thread Phil Steitz
On Mar 1, 2015, at 2:24 PM, Антон Мацюк denixx.bay...@gmail.com wrote: Hi! I have a question about dbcp and pool. Last two weeks I have examined heapdumps of Tomcat instances that is used by my apps. There is situation with BoneCP - it have a LOT of SQLWarnings at each connection used

Re: [dbcp] dbcp, pool and SQLWarnings.

2015-03-03 Thread Phil Steitz
On 3/3/15 7:26 AM, Антон Мацюк wrote: I am talking about DBCP 1.4 now. I am not familiar with the internals of BoneCP; but DBCP has been optimized to reduce the calls to driver setXxx methods. See https://issues.apache.org/jira/browse/DBCP-102 https://issues.apache.org/jira/browse/DBCP-234

Re: [dbcp] dbcp, pool and SQLWarnings.

2015-03-03 Thread Антон Мацюк
I am talking about DBCP 1.4 now. 2015-03-03 15:42 GMT+02:00 Phil Steitz phil.ste...@gmail.com: On Mar 1, 2015, at 2:24 PM, Антон Мацюк denixx.bay...@gmail.com wrote: Hi! I have a question about dbcp and pool. Last two weeks I have examined heapdumps of Tomcat instances that is used

[dbcp] dbcp, pool and SQLWarnings.

2015-03-02 Thread Антон Мацюк
Hi! I have a question about dbcp and pool. Last two weeks I have examined heapdumps of Tomcat instances that is used by my apps. There is situation with BoneCP - it have a LOT of SQLWarnings at each connection used by it. With DBCP-app all is normal - there is no SQLWarnings. Apps are not the same

Re: [dbcp] dbcp, pool and SQLWarnings.

2015-03-02 Thread Phil Steitz
On 3/1/15 2:24 PM, Антон Мацюк wrote: Hi! I have a question about dbcp and pool. Last two weeks I have examined heapdumps of Tomcat instances that is used by my apps. There is situation with BoneCP - it have a LOT of SQLWarnings at each connection used by it. With DBCP-app all is normal

[ANNOUNCEMENT] Apache Commons DBCP 2.1 released

2015-02-24 Thread Phil Steitz
The Apache Commons Team is pleased to announce the release of Apache Commons DBCP 2.1. The Apache Commons DBCP open source software library implements database connection pooling. Version 2.1 is a minor release, including bug fixes and enhancements. Full details of all the changes in version

RESULT: [VOTE] Release DBCP 2.1 RC2 as 2.1

2015-02-23 Thread Phil Steitz
This vote has passed, with binding +1 votes from Thomas Neidhart Phil Steitz Oliver Heger and no other votes. Thanks to all who helped with this release. Phil On 2/19/15 10:02 PM, Phil Steitz wrote: Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added

Re: [VOTE] Release DBCP 2.1 RC2 as 2.1

2015-02-22 Thread Oliver Heger
version: 1.7.0_67, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_67\jre Default locale: de_DE, platform encoding: Cp1252 OS name: windows 8.1, version: 6.3, arch: amd64, family: windows Am 20.02.2015 um 06:02 schrieb Phil Steitz: Quite a few bugs have been fixed since DBCP 2.0.1

Re: [VOTE] Release DBCP 2.1 RC2 as 2.1

2015-02-21 Thread Thomas Neidhart
On 02/20/2015 06:02 AM, Phil Steitz wrote: Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. Changes since RC1: * Changed awkward boolean property getter names added in 2.1 * Made POM and javadoc changes to enable Java 8

Re: [VOTE] Release DBCP 2.1 RC2 as 2.1

2015-02-21 Thread Phil Steitz
On 2/19/15 10:02 PM, Phil Steitz wrote: Here is my +1 Phil Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. Changes since RC1: * Changed awkward boolean property getter names added in 2.1 * Made POM and javadoc changes

[VOTE] Release DBCP 2.1 RC2 as 2.1

2015-02-19 Thread Phil Steitz
Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. Changes since RC1: * Changed awkward boolean property getter names added in 2.1 * Made POM and javadoc changes to enable Java 8 build. * Made project URL more compact Thanks

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Thomas Neidhart
hmm, I do not know what I have seen yesterday, but the references to dbcp 2.x and pool 2.3 are already correct. I have updated the other 2 examples to use an h2 database as already outlined in the PoolingDataSourceExample. Thomas On Wed, Feb 18, 2015 at 1:13 AM, Phil Steitz phil.ste

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Emmanuel Bourg
Le 17/02/2015 16:50, Phil Steitz a écrit : That is just the site build, which is not essential to the release, IMO, so again not a blocker. Not only the site build, I got the same error with a simple 'mvn test'. Emmanuel Bourg

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Phil Steitz
On 2/18/15 6:30 AM, Emmanuel Bourg wrote: [X] +1 Release these artifacts Tested with OpenJDK 7 on Debian. The name of the isLogExpiredConnections() method in BasicDataSource and BasicDataSourceMXBean looks a bit inconsistent with the other methods returning a boolean. I would have picked

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Phil Steitz
On 2/18/15 6:52 AM, Emmanuel Bourg wrote: Le 18/02/2015 14:48, Phil Steitz a écrit : That is not good. What JDK and OS? That was with OpenJDK 8u40b22 on Debian Jessie. Thanks. I was just able to replicate. I need to get rid of the jacoco nonsense somehow. Will fix and reroll. Phil

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Thomas Neidhart
Sorry it was my mistake, I did not test the change with Java 8. The pom.xml is now fixed, I used the same override for jacoco as was used for commons-math 3.4 Thomas On Wed, Feb 18, 2015 at 3:24 PM, Thomas Neidhart thomas.neidh...@gmail.com wrote: I enabled jacoco a while a go, but if you

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Thomas Neidhart
I enabled jacoco a while a go, but if you would prefer cobertura we can easily change to it. Thomas On Wed, Feb 18, 2015 at 2:54 PM, Phil Steitz phil.ste...@gmail.com wrote: On 2/18/15 6:52 AM, Emmanuel Bourg wrote: Le 18/02/2015 14:48, Phil Steitz a écrit : That is not good. What JDK

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Phil Steitz
On 2/18/15 3:08 AM, Thomas Neidhart wrote: hmm, I do not know what I have seen yesterday, but the references to dbcp 2.x and pool 2.3 are already correct. Thanks. That was driving me crazy. Could be some funny svn mirror lag or something if you were hitting them from the web page instead

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Emmanuel Bourg
Le 18/02/2015 14:48, Phil Steitz a écrit : That is not good. What JDK and OS? That was with OpenJDK 8u40b22 on Debian Jessie. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Emmanuel Bourg
Le 18/02/2015 14:47, Phil Steitz a écrit : Good point. If you or others feel strongly that this is too ugly, I can change and re-roll. Any other opinions on this? Thanks for the review! On the same line I wonder if the isFastFailValidation() method would be better named

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Emmanuel Bourg
[X] +1 Release these artifacts Tested with OpenJDK 7 on Debian. The name of the isLogExpiredConnections() method in BasicDataSource and BasicDataSourceMXBean looks a bit inconsistent with the other methods returning a boolean. I would have picked getLogExpiredConnections (similar to the

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Phil Steitz
On 2/18/15 7:43 AM, Thomas Neidhart wrote: Sorry it was my mistake, I did not test the change with Java 8. The pom.xml is now fixed, I used the same override for jacoco as was used for commons-math 3.4 Thanks! Phil Thomas On Wed, Feb 18, 2015 at 3:24 PM, Thomas Neidhart

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Phil Steitz
On 2/18/15 5:05 AM, Emmanuel Bourg wrote: Le 17/02/2015 16:50, Phil Steitz a écrit : That is just the site build, which is not essential to the release, IMO, so again not a blocker. Not only the site build, I got the same error with a simple 'mvn test'. That is not good. What JDK and OS?

[CANCELLED]: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-18 Thread Phil Steitz
Due to problems with JDK 8 build... On 2/16/15 9:04 PM, Phil Steitz wrote: Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. The release is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-17 Thread Phil Steitz
On 2/17/15 2:29 PM, Thomas Neidhart wrote: On 02/17/2015 05:04 AM, Phil Steitz wrote: Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. The release is available for review here: https://dist.apache.org/repos/dist/dev

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-17 Thread Phil Steitz
Here is my +1 Phil On 2/16/15 9:04 PM, Phil Steitz wrote: Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. The release is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-17 Thread Phil Steitz
locale: en_US, platform encoding: UTF-8OS name: linux, version: 3.16.0-30-generic, arch: amd64, family: unix All tests passed. Comparing with http://commons.apache.org/proper/commons-dbcp/findbugs.html, looks like there is a new FindBugs bug: org.apache.commons.dbcp2

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-17 Thread Bruno P. Kinoshita
, version: 3.16.0-30-generic, arch: amd64, family: unix All tests passed. Comparing with http://commons.apache.org/proper/commons-dbcp/findbugs.html, looks like there is a new FindBugs bug: org.apache.commons.dbcp2.DelegatingConnection.prepareStatement(String) may return null, but is declared

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-17 Thread Phil Steitz
, vendor: Oracle Corporation Java home: c:\Program Files\Java\jdk1.7.0_67\jre Default locale: de_DE, platform encoding: Cp1252 OS name: windows 8.1, version: 6.3, arch: amd64, family: windows Am 17.02.2015 um 05:04 schrieb Phil Steitz: Quite a few bugs have been fixed since DBCP 2.0.1 and a few

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-17 Thread Oliver Heger
: windows 8.1, version: 6.3, arch: amd64, family: windows Am 17.02.2015 um 05:04 schrieb Phil Steitz: Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. The release is available for review here: https://dist.apache.org/repos

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-17 Thread Thomas Neidhart
On 02/17/2015 05:04 AM, Phil Steitz wrote: Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. The release is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031) The release was built

Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-17 Thread sebb
: 1bc7959577f0c1dc01480998f60494d46e403481) On 17 February 2015 at 04:04, Phil Steitz phil.ste...@gmail.com wrote: Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. The release is available for review here: https://dist.apache.org/repos/dist

[DBCP] tomcat / JNDI users - pls review DBCP-435 changes

2015-02-16 Thread Phil Steitz
I think the idea in this issue / patch is good - warn users when they are specifying obsolete or unknown properties in JNDI references. I tested with tc 8 trunk and apart from the formatting changes I put into the patch (and suppressed redundant stderr writes), output looks similar to what is in

Re: [DBCP] tomcat / JNDI users - pls review DBCP-435 changes

2015-02-16 Thread Mark Thomas
On 16/02/2015 20:28, Phil Steitz wrote: I think the idea in this issue / patch is good - warn users when they are specifying obsolete or unknown properties in JNDI references. I tested with tc 8 trunk and apart from the formatting changes I put into the patch (and suppressed redundant stderr

[VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1

2015-02-16 Thread Phil Steitz
Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. The release is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031) The release was built from this tag: http://svn.apache.org/viewvc/commons

[DBCP] Help getting a test for DBCP-433

2015-02-08 Thread Phil Steitz
The analysis and patch in DBCP-433 look correct to me. I am struggling, likely because of my lack of JEE-foo, to get a unit test that fails with current code and succeeds after the fix. Any help with this would be much appreciated. Thanks! Phil

Re: [DBCP] needless sync on getNumActive, getNumIdle?

2015-02-04 Thread sebb
On 4 February 2015 at 13:51, Phil Steitz phil.ste...@gmail.com wrote: I had to go around getNumIdle to avoid waiting on a this lock in the unit test I just committed. With pool 2 and volatile connectionPool instance, I don't think this sync is needed any more. Same with the sync on

[DBCP] needless sync on getNumActive, getNumIdle?

2015-02-04 Thread Phil Steitz
I had to go around getNumIdle to avoid waiting on a this lock in the unit test I just committed. With pool 2 and volatile connectionPool instance, I don't think this sync is needed any more. Same with the sync on getNumActive. Am I missing something here? Phil

Re: [DBCP] Getting ready to roll 2.1

2015-02-02 Thread Mark Thomas
On 31/01/2015 20:03, Phil Steitz wrote: I am about ready (at last) to start rolling RCs for DBCP 2.1. I just opened an issue [1] that I am on the fence about and would like feedback on. I am not sure, actually, that it is an improvement to force initial requests to queue waiting for the pool

[DBCP] Getting ready to roll 2.1

2015-01-31 Thread Phil Steitz
I am about ready (at last) to start rolling RCs for DBCP 2.1. I just opened an issue [1] that I am on the fence about and would like feedback on. I am not sure, actually, that it is an improvement to force initial requests to queue waiting for the pool to be pre-filled (what the patch now does

Re: svn commit: r1655299 - /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java

2015-01-28 Thread Phil Steitz
://svn.apache.org/r1655299 Log: Javadoc typo. Modified: commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java Modified: commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java URL: http://svn.apache.org/viewvc/commons/proper

Re: svn commit: r1655299 - /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java

2015-01-28 Thread Benedikt Ritter
/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java Modified: commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2

Re: Compiling and running examples [was [math][dbcp][pool] Apachecon NA (Austin))

2015-01-05 Thread Gilles
On Sun, 4 Jan 2015 14:20:53 +, sebb wrote: On 4 January 2015 at 12:58, Gilles gil...@harfang.homelinux.org wrote: Hello. On Sun, 04 Jan 2015 12:09:35 +0100, Luc Maisonobe wrote: Hi all, Le 04/01/2015 02:07, Gilles a écrit : It reminded me that I had yet to improve one toy example in

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-05 Thread sebb
, Gilles a écrit : On Fri, 02 Jan 2015 14:45:15 -0700, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing and / or presenting either

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-05 Thread Phil Steitz
wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing and / or presenting either of these. Is anyone else interested in working on a talk on either

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-04 Thread Luc Maisonobe
Hi all, Le 04/01/2015 02:07, Gilles a écrit : On Fri, 02 Jan 2015 14:45:15 -0700, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-04 Thread Gilles
Hello. On Sun, 04 Jan 2015 12:09:35 +0100, Luc Maisonobe wrote: Hi all, Le 04/01/2015 02:07, Gilles a écrit : On Fri, 02 Jan 2015 14:45:15 -0700, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try

Compiling and running examples [was [math][dbcp][pool] Apachecon NA (Austin))

2015-01-04 Thread sebb
On 4 January 2015 at 12:58, Gilles gil...@harfang.homelinux.org wrote: Hello. On Sun, 04 Jan 2015 12:09:35 +0100, Luc Maisonobe wrote: Hi all, Le 04/01/2015 02:07, Gilles a écrit : It reminded me that I had yet to improve one toy example in the

Re: [dbcp] Preparing 2.1

2015-01-04 Thread Thomas Neidhart
On 01/04/2015 01:28 AM, Phil Steitz wrote: There are just a few issues open for 2.1. I have DBCP-424 about done using the approach on the last comment on that ticket. Patches, comments or commits for DBCP-423, 427 are welcome. One other thing that would be nice to clean up for this release

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-04 Thread Phil Steitz
the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing and / or presenting either of these. Is anyone else interested in working on a talk on either of these? Any suggestions on content? For [math] I have always wanted to do a high level overview

Re: [dbcp] Preparing 2.1

2015-01-04 Thread Phil Steitz
On 1/4/15 2:15 PM, Thomas Neidhart wrote: On 01/04/2015 01:28 AM, Phil Steitz wrote: There are just a few issues open for 2.1. I have DBCP-424 about done using the approach on the last comment on that ticket. Patches, comments or commits for DBCP-423, 427 are welcome. One other thing

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-03 Thread Phil Steitz
On 1/3/15 7:11 AM, Thomas Neidhart wrote: On 01/02/2015 10:45 PM, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing and / or presenting

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-03 Thread Thomas Neidhart
On 01/02/2015 10:45 PM, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing and / or presenting either of these. Is anyone else interested

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-03 Thread Thomas Neidhart
On 01/03/2015 06:49 PM, Phil Steitz wrote: On 1/3/15 7:11 AM, Thomas Neidhart wrote: On 01/02/2015 10:45 PM, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have

[dbcp] Preparing 2.1

2015-01-03 Thread Phil Steitz
There are just a few issues open for 2.1. I have DBCP-424 about done using the approach on the last comment on that ticket. Patches, comments or commits for DBCP-423, 427 are welcome. One other thing that would be nice to clean up for this release if someone is motivated to do it is to change

Re: [math][dbcp][pool] Apachecon NA (Austin)

2015-01-03 Thread Gilles
On Fri, 02 Jan 2015 14:45:15 -0700, Phil Steitz wrote: I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing and / or presenting either of these. Is anyone else

[math][dbcp][pool] Apachecon NA (Austin)

2015-01-02 Thread Phil Steitz
I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing and / or presenting either of these. Is anyone else interested in working on a talk on either of these? Any

[dbcp] Javadoc {*link Foo}?

2014-07-20 Thread Gary Gregory
Is there something special being done with the funky format for Javadocs that look like {*link Foo} as opposed to {@link Foo}? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition http://www.manning.com/bauer3/ JUnit in Action, Second

Re: [dbcp] Javadoc {*link Foo}?

2014-07-20 Thread Benedikt Ritter
Try to build that with Java 8... it will tell you whether that's valid ;-) 2014-07-20 8:26 GMT+02:00 Gary Gregory garydgreg...@gmail.com: Is there something special being done with the funky format for Javadocs that look like {*link Foo} as opposed to {@link Foo}? Gary -- E-Mail:

Re: [dbcp] Javadoc {*link Foo}?

2014-07-20 Thread Gary Gregory
Javadoc 8 blows up left and right for this component, and I do not see complaints about *link. Gary On Sun, Jul 20, 2014 at 5:05 AM, Benedikt Ritter brit...@apache.org wrote: Try to build that with Java 8... it will tell you whether that's valid ;-) 2014-07-20 8:26 GMT+02:00 Gary Gregory

Re: [dbcp] Javadoc {*link Foo}?

2014-07-20 Thread Benedikt Ritter
I see no reason to treat dbcp special wrt JavaDoc. I'm fine with changing the links. Benedikt Send from my mobile device Am 20.07.2014 um 20:57 schrieb Gary Gregory garydgreg...@gmail.com: Javadoc 8 blows up left and right for this component, and I do not see complaints about *link

[continuum] BUILD FAILURE: Apache Commons DBCP - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

2014-07-16 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=34169projectId=297 Build statistics: State: Failed Previous Build: No previous build. Started at: Wed 16 Jul 2014 13:52:17 + Finished at: Wed 16 Jul 2014 13:52:26 + Total time: 9s Build

[ANNOUNCEMENT] Apache Commons DBCP 2.0.1 released

2014-05-24 Thread Phil Steitz
The Apache Commons Team is pleased to announce the release of Apache Commons DBCP 2.0.1. The Apache Commons DBCP open source software library implements database connection pooling. Version 2.0.1 is a patch release, including bug fixes only. Source and binary distributions are available

[RESULT] [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-21 Thread Phil Steitz
This vote has passed with binding +1 votes from Phil Steitz, Thomas Neidhart, Luc Maisonobe, Oliver Heger and Gary Gregory, a +0 vote from Bernd Eckenfels and no other votes. Phil On 5/18/14, 2:22 PM, Phil Steitz wrote: The problem with line endings in RC2 has been fixed. DBCP 2.0.1 RC3

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-19 Thread Luc Maisonobe
Le 18/05/2014 23:22, Phil Steitz a écrit : The problem with line endings in RC2 has been fixed. DBCP 2.0.1 RC3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379) Maven artifacts are here: https://repository.apache.org/content/repositories

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-19 Thread Thomas Neidhart
On 05/18/2014 11:22 PM, Phil Steitz wrote: The problem with line endings in RC2 has been fixed. DBCP 2.0.1 RC3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379) Maven artifacts are here: https://repository.apache.org/content/repositories

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-19 Thread Oliver Heger
- therefore, the ant build did not run out of the box. After adapting the properties, the build with ant was successful. Of course, not a blocker. So +1 Oliver Am 18.05.2014 23:22, schrieb Phil Steitz: The problem with line endings in RC2 has been fixed. DBCP 2.0.1 RC3 is available for review here

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-19 Thread Gary Gregory
, version: 6.1, arch: amd64, family: windows Still +1 Gary On Sun, May 18, 2014 at 5:22 PM, Phil Steitz phil.ste...@gmail.com wrote: The problem with line endings in RC2 has been fixed. DBCP 2.0.1 RC3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379

[VOTE] Release DBCP 2.0.1 based on RC3

2014-05-18 Thread Phil Steitz
The problem with line endings in RC2 has been fixed. DBCP 2.0.1 RC3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379) Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1031/ Details of changes since 2.0

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-18 Thread Bernd Eckenfels
in RC2 has been fixed. DBCP 2.0.1 RC3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379) Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1031/ Details of changes since 2.0 are in the release notes

Re: [VOTE] Release DBCP 2.0.1 based on RC3

2014-05-18 Thread Phil Steitz
phil.ste...@gmail.com: The problem with line endings in RC2 has been fixed. DBCP 2.0.1 RC3 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r5379) Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-1031/ Details

<    1   2   3   4   5   6   7   8   9   10   >