+1 everything looks good. Nits, coverage a tad low, cpd, pmd, todo’s
Send it
-Rob
> On Dec 3, 2023, at 11:33 AM, Gary Gregory wrote:
>
> We have fixed a few bugs and added some enhancements since Apache
> Commons BCEL 6.7.0 was released, so I would like to release Apache
> Commons BCEL
[ +1 ]
Built locally using: mvn -s "$HOME/.m2/commons-settings.xml" -P jacoco -P
japicmp clean package site
On: Darwin henrib-MBP16 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9
21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64
With: OpenJDK Runtime Environment (Zulu
Build instructions are rooted here:
https://commons.apache.org/releases/index.html
These could be partially out of date but do mention our release plug-in.
Gary
On Tue, Dec 5, 2023, 7:37 AM Elliotte Rusty Harold
wrote:
> OK, so bc means binary compatibility, not BCEL. That makes sense,
>
OK, so bc means binary compatibility, not BCEL. That makes sense,
though abbreviations are still confusing.
Not urgent, but it would be worth adding build and release
instructions to the repo some time. As is, I don't see any reference
to the commons release plugin in the BCEL repo or docs.
My +1
Gary
On Mon, Dec 4, 2023, 5:38 PM Bruno Kinoshita
wrote:
>[X] +1 Release these artifacts
>
> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: /opt/apache-maven-3.8.5
> Java version: 17.0.9, vendor: Private Build, runtime:
>
[X] +1 Release these artifacts
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/apache-maven-3.8.5
Java version: 17.0.9, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version:
Issues I opened marked resolved fixed: 287, 294, 295, 296, 297, 329, 330,
333, 334, 335, 340
Issue I opened that has fix available: 361
On Sun, Dec 3, 2023 at 9:10 AM Elliotte Rusty Harold
wrote:
> https://issues.apache.org/jira/projects/BCEL/issues/BCEL-337 looks
> like it's fixed and should
No, it should NOT be removed: It is used by the build/release plugins
to know which version to check for binary compatibility when the
default Maven goal runs the BC check and when the site report is
generated.
Gary
On Sun, Dec 3, 2023 at 12:13 PM Elliotte Rusty Harold
wrote:
>
> pom.xml has
pom.xml has this strange variable:
6.7.0
Is that supposed to be the commons bcel version? If so, update it to
6.8.0. However, it doesn't seem to be used anywhere so perhaps just
delete the line.
On Sun, Dec 3, 2023 at 4:33 PM Gary Gregory wrote:
>
> We have fixed a few bugs and added some
https://issues.apache.org/jira/projects/BCEL/issues/BCEL-337 looks
like it's fixed and should be closed prior to release. Might be worth
doing a quick pass through the issue tracker to see if there's
anything else in there that needs to be closed or addressed.
On Sun, Dec 3, 2023 at 4:33 PM Gary
10 matches
Mail list logo
