Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-04 Thread Henri Yandell
Both on the first question :) Not me on the second. On Mon, Sep 3, 2012 at 4:11 AM, James Carman ja...@carmanconsulting.com wrote: Cool as in that's great that we're getting contributions from folks via Github or cool as in it's cool to use patches via Github pull requests, since there's an

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-04 Thread James Carman
So, has the ASF said that github pull requests coming into our mailing lists will suffice as far as granting the ASF license? On Tue, Sep 4, 2012 at 10:50 AM, Henri Yandell flame...@gmail.com wrote: Both on the first question :) Not me on the second. On Mon, Sep 3, 2012 at 4:11 AM, James

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-04 Thread Gary Gregory
Note: Windows 8 is version 6.2 per http://msdn.microsoft.com/en-us/library/windows/desktop/hh848058%28v=vs.85%29.aspx Gary On Sat, Sep 1, 2012 at 8:19 PM, Olloth g...@git.apache.org wrote: GitHub user Olloth opened a pull request: https://github.com/apache/commons-lang/pull/2

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-04 Thread Gary Gregory
I just created the static independently from this pull request. Committed revision 1380679 as [LANG-817]. Gary On Sat, Sep 1, 2012 at 8:19 PM, Olloth g...@git.apache.org wrote: GitHub user Olloth opened a pull request: https://github.com/apache/commons-lang/pull/2 Update

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-03 Thread Henri Yandell
Cool to have a patch come in via github. Bear in mind there's nothing to suggest Olloth is on the mailing list. Hen On Sat, Sep 1, 2012 at 6:16 PM, James Carman ja...@carmanconsulting.com wrote: Can you submit a JIRA and attach a SVN patch please? On Sat, Sep 1, 2012 at 8:19 PM, Olloth

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-02 Thread Gary Gregory
The @since tag is wrong and there is no unit test. The feature is trivial so it is likely not worth going round on the patch and some one should just add the feature. Gary On Sep 1, 2012, at 20:19, Olloth g...@git.apache.org wrote: GitHub user Olloth opened a pull request:

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-01 Thread James Carman
Can you submit a JIRA and attach a SVN patch please? On Sat, Sep 1, 2012 at 8:19 PM, Olloth g...@git.apache.org wrote: GitHub user Olloth opened a pull request: https://github.com/apache/commons-lang/pull/2 Update src/main/java/org/apache/commons/lang3/SystemUtils.java Updated