Re: svn commit: r1648704 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ test/java/org/apache/commons/compress/archivers/zip/

2015-01-02 Thread Stefan Bodewig
On 2014-12-31, krosenv...@apache.org wrote: static ScatterGatherBackingStoreSupplier defaultSupplier = new DefaultSupplier(); This one could be instance variable (and made final when set in the constructor). I think this would be a cleaner approach to overriding the supplier that setting

Re: svn commit: r1648704 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ test/java/org/apache/commons/compress/archivers/zip/

2015-01-02 Thread Stefan Bodewig
On 2015-01-02, Kristian Rosenvold wrote: 2015-01-02 16:22 GMT+01:00 Stefan Bodewig bode...@apache.org: On 2014-12-31, krosenv...@apache.org wrote: ... all else fixed in r1649128.. I thought you'd need a way to override the ScatterGatherBackingStoreSupplier from Plexus, maybe I was wrong.