Re: svn commit: r750313 - /commons/sandbox/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java

2009-03-06 Thread sebb
On 06/03/2009, Stefan Bodewig bode...@apache.org wrote: On 2009-03-06, sebb seb...@gmail.com wrote: On 05/03/2009, bode...@apache.org bode...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=750313view=rev Log: make tests pass on Linux However, they now fail on Windows

Re: svn commit: r750313 - /commons/sandbox/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java

2009-03-06 Thread sebb
On 06/03/2009, Christian Grobmeier grobme...@gmail.com wrote: Could anybody using Eclipse please check whether the appended trivial patch causes problems there? Your patch works for me with Eclipse Ganymede and Mac OSX 10.5. Also on WinXP. The addUrl Method looks like not used anymore,

Re: svn commit: r750313 - /commons/sandbox/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java

2009-03-06 Thread Stefan Bodewig
On 2009-03-06, Christian Grobmeier grobme...@gmail.com wrote: Could anybody using Eclipse please check whether the appended trivial patch causes problems there? Your patch works for me with Eclipse Ganymede and Mac OSX 10.5. It should as long as your current working directory is set

Re: svn commit: r750313 - /commons/sandbox/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java

2009-03-06 Thread Stefan Bodewig
On 2009-03-06, sebb seb...@gmail.com wrote: On 06/03/2009, Stefan Bodewig bode...@apache.org wrote: On 2009-03-06, sebb seb...@gmail.com wrote: Adding back the .getClassLoader() stage improves matters, That really isn't supposed to make any difference, strange. Class.getResource() makes

Re: svn commit: r750313 - /commons/sandbox/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java

2009-03-05 Thread sebb
On 05/03/2009, bode...@apache.org bode...@apache.org wrote: Author: bodewig Date: Thu Mar 5 04:49:10 2009 New Revision: 750313 URL: http://svn.apache.org/viewvc?rev=750313view=rev Log: make tests pass on Linux However, they now fail on Windows (and compilation fails on Java 1.4/1.5,

Re: svn commit: r750313 - /commons/sandbox/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java

2009-03-05 Thread Stefan Bodewig
On 2009-03-06, sebb seb...@gmail.com wrote: On 05/03/2009, bode...@apache.org bode...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=750313view=rev Log: make tests pass on Linux However, they now fail on Windows (and compilation fails on Java 1.4/1.5, but I fixed that). Sorry

Re: svn commit: r750313 - /commons/sandbox/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java

2009-03-05 Thread Stefan Bodewig
On 2009-03-06, Stefan Bodewig bode...@apache.org wrote: On 2009-03-06, sebb seb...@gmail.com wrote: I'm not sure that getResource() is the correct method to use here. Well, it works great for files that don't contain spaces in their name 8-) Looking into AbstractTestCase it explicitly adds

Re: svn commit: r750313 - /commons/sandbox/compress/trunk/src/test/java/org/apache/commons/compress/AbstractTestCase.java

2009-03-05 Thread Christian Grobmeier
Could anybody using Eclipse please check whether the appended trivial patch causes problems there? Your patch works for me with Eclipse Ganymede and Mac OSX 10.5. The addUrl Method looks like not used anymore, it can be removed imho. It has appeared cause of the getClass.getResource approach.