Re: svn commit: r760000 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/ar/ArArchiveOutputStream.java test/java/org/apache/commons/compress/archivers/ArTestC

2009-03-31 Thread Stefan Bodewig
On 2009-03-30, sebb seb...@gmail.com wrote: On 30/03/2009, Stefan Bodewig bode...@apache.org wrote: On 2009-03-30, sebb seb...@gmail.com wrote: Might it not be better to throw an Exception if methods are called out of sequence? We are pretty inconsistent here. In general I agree it would

Re: svn commit: r760000 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/ar/ArArchiveOutputStream.java test/java/org/apache/commons/compress/archivers/ArTestC

2009-03-30 Thread sebb
On 30/03/2009, bode...@apache.org bode...@apache.org wrote: Author: bodewig Date: Mon Mar 30 15:07:54 2009 New Revision: 76 URL: http://svn.apache.org/viewvc?rev=76view=rev Log: make closeArchiveEntry a NOP if called repeatedly. This makes ArTestCase fail for all platforms

Re: svn commit: r760000 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/ar/ArArchiveOutputStream.java test/java/org/apache/commons/compress/archivers/ArTestC

2009-03-30 Thread Stefan Bodewig
On 2009-03-30, sebb seb...@gmail.com wrote: Might it not be better to throw an Exception if methods are called out of sequence? We are pretty inconsistent here. In general I agree it would be better to throw an exception, but we seem to swallow other errors in other classes. Stefan

Re: svn commit: r760000 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/ar/ArArchiveOutputStream.java test/java/org/apache/commons/compress/archivers/ArTestC

2009-03-30 Thread sebb
On 30/03/2009, Stefan Bodewig bode...@apache.org wrote: On 2009-03-30, sebb seb...@gmail.com wrote: Might it not be better to throw an Exception if methods are called out of sequence? We are pretty inconsistent here. In general I agree it would be better to throw an exception, but we