Re: [csv] type name consistency

2013-08-07 Thread Emmanuel Bourg
Le 07/08/2013 01:31, sebb a écrit : I quite like the idea of dropping the CSV prefix - the package name is csv so the CSV prefix is redundant. But if no-one else is keen, it's not a big deal. I don't think this is a good idea, the class names would become way too generic. This will clash

Re: [csv] type name consistency

2013-08-07 Thread Benedikt Ritter
2013/8/7 Emmanuel Bourg ebo...@apache.org Le 07/08/2013 01:31, sebb a écrit : I quite like the idea of dropping the CSV prefix - the package name is csv so the CSV prefix is redundant. But if no-one else is keen, it's not a big deal. I don't think this is a good idea, the class names

Re: [csv] type name consistency

2013-08-07 Thread Benedikt Ritter
2013/8/7 Gary Gregory garydgreg...@gmail.com I think we can be done unless other opinions come in... What about Quote? Do we want to move it to CSVFormat? Makes sense because it is really part of a CSVFormat. OTOH CSVFormat.Quote.ALL is more verbose then simply Quote.ALL G On Tue, Aug

[continuum] BUILD FAILURE: Apache Commons - Commons Monitoring (Sandbox) - Monitoring requires Java 1.6 for its JDBC module

2013-08-07 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=27251projectId=127 Build statistics: State: Failed Previous State: Failed Started at: Wed 7 Aug 2013 07:20:13 + Finished at: Wed 7 Aug 2013 07:20:24 + Total time: 11s Build Trigger: Schedule

[MONITORING] Contiuum build still fails (was: Re: [continuum] BUILD FAILURE: Apache Commons - Commons Monitoring (Sandbox) - Monitoring requires Java 1.6 for its JDBC module)

2013-08-07 Thread Benedikt Ritter
Hi, this still fails. Can one of you guys who is working on monitoring (Romain, Matt, Oliver, James?!) fix this? I see three options: - configure contiuum to use maven 3 - use a version of the shade plugin that doesn't require maven 3 - don't use shade Benedikt 2013/8/7 Continuum@vmbuild

Re: [MONITORING] Contiuum build still fails (was: Re: [continuum] BUILD FAILURE: Apache Commons - Commons Monitoring (Sandbox) - Monitoring requires Java 1.6 for its JDBC module)

2013-08-07 Thread Romain Manni-Bucau
Hi, i have no idea how continuum can be configured, is it hard to setup maven 3? *Romain Manni-Bucau* *Twitter: @rmannibucau https://twitter.com/rmannibucau* *Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/ *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github:

Re: [MONITORING] Contiuum build still fails (was: Re: [continuum] BUILD FAILURE: Apache Commons - Commons Monitoring (Sandbox) - Monitoring requires Java 1.6 for its JDBC module)

2013-08-07 Thread sebb
On 7 August 2013 08:33, Benedikt Ritter brit...@apache.org wrote: Hi, this still fails. Can one of you guys who is working on monitoring (Romain, Matt, Oliver, James?!) fix this? I see three options: - configure contiuum to use maven 3 - use a version of the shade plugin that doesn't

[IMAGING] Tidied up SNAPSHOTS

2013-08-07 Thread sebb
I've removed the spurious 1.1-SNAPSHOT version. This was generated by Continuum, so trunk must have been updated to 1.1-SNAPSHOT at one point. I suspect that was caused by the Maven Release plugin. I also removed 1.0-SNAPSHOT and regenerated it.

Re: [csv] final types

2013-08-07 Thread James Carman
What exactly does it hurt by leaving them non-final? It's not like we have to support folks doing stupid things. One user doing something silly doesn't impact other users either. I guess I don't understand the paranoia here. On Tuesday, August 6, 2013, Torsten Curdt wrote: I am also -0 to

Re: [csv] type name consistency

2013-08-07 Thread James Carman
I like Csv as opposed to CSV also. On Tuesday, August 6, 2013, Gary Gregory wrote: The class names in [csv] are (pp) means package private, others are public org.apache.commons.csv.Constants (pp) org.apache.commons.csv.CSVFormat org.apache.commons.csv.CSVLexer

[Parent] Build fails to run jacoco plugin

2013-08-07 Thread Gilles
Hi. In project [Math], the command mvn jacoco:check fails, with the following error: ---CUT--- [INFO] Scanning for projects... [INFO] [INFO] Building Commons Math [INFO]task-segment: [jacoco:check] [INFO]

Re: [csv] type name consistency

2013-08-07 Thread Gary Gregory
On Wed, Aug 7, 2013 at 2:45 AM, Benedikt Ritter brit...@apache.org wrote: 2013/8/7 Gary Gregory garydgreg...@gmail.com I think we can be done unless other opinions come in... What about Quote? Do we want to move it to CSVFormat? Makes sense because it is really part of a CSVFormat. OTOH

Re: [csv] final types

2013-08-07 Thread sebb
On 7 August 2013 13:11, James Carman ja...@carmanconsulting.com wrote: What exactly does it hurt by leaving them non-final? It's not like we have to support folks doing stupid things. One user doing something silly doesn't impact other users either. I guess I don't understand the paranoia

Re: [csv] type name consistency

2013-08-07 Thread sebb
On 7 August 2013 14:15, Gary Gregory garydgreg...@gmail.com wrote: On Wed, Aug 7, 2013 at 2:45 AM, Benedikt Ritter brit...@apache.org wrote: 2013/8/7 Gary Gregory garydgreg...@gmail.com I think we can be done unless other opinions come in... What about Quote? Do we want to move it to

Re: [csv] final types

2013-08-07 Thread James Carman
I'm still not convinced this is warranted, but I voted -0 On Wednesday, August 7, 2013, sebb wrote: On 7 August 2013 13:11, James Carman ja...@carmanconsulting.comjavascript:; wrote: What exactly does it hurt by leaving them non-final? It's not like we have to support folks doing

Re: svn commit: r1511316 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java test/java/org/apache/commons/compress/archivers/cpio/

2013-08-07 Thread sebb
On 7 August 2013 14:52, ebo...@apache.org wrote: Author: ebourg Date: Wed Aug 7 13:52:00 2013 New Revision: 1511316 URL: http://svn.apache.org/r1511316 Log: Changed the return type of CpioArchiveInputStream.getNextEntry() to avoid casting to CpioArchiveEntry -1 Surely that will cause

Re: svn commit: r1511316 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java test/java/org/apache/commons/compress/archivers/cpio/

2013-08-07 Thread Stefan Bodewig
On 2013-08-07, ebo...@apache.org wrote: Author: ebourg Date: Wed Aug 7 13:52:00 2013 New Revision: 1511316 URL: http://svn.apache.org/r1511316 Log: Changed the return type of CpioArchiveInputStream.getNextEntry() to avoid casting to CpioArchiveEntry please don't. Let's leave that for

Re: [csv] type name consistency

2013-08-07 Thread Gary Gregory
On Wed, Aug 7, 2013 at 10:39 AM, sebb seb...@gmail.com wrote: On 7 August 2013 14:15, Gary Gregory garydgreg...@gmail.com wrote: On Wed, Aug 7, 2013 at 2:45 AM, Benedikt Ritter brit...@apache.org wrote: 2013/8/7 Gary Gregory garydgreg...@gmail.com I think we can be done unless other

Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/ test/java/org/apache/co

2013-08-07 Thread Stefan Bodewig
On 2013-08-07, ebo...@apache.org wrote: -public BZip2CompressorInputStream(final InputStream in, - final boolean decompressConcatenated) -throws IOException { - +public BZip2CompressorInputStream(final InputStream in, final boolean

Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/ test/java/org/apache/co

2013-08-07 Thread Gary Gregory
On Wed, Aug 7, 2013 at 11:15 AM, Stefan Bodewig bode...@apache.org wrote: On 2013-08-07, ebo...@apache.org wrote: -public BZip2CompressorInputStream(final InputStream in, - final boolean decompressConcatenated) -throws IOException {

Re: svn commit: r1511326 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/dump/ main/java/org/apache/commons/compress/compressors/bzip2/ test/java/org/apache/co

2013-08-07 Thread Emmanuel Bourg
Le 07/08/2013 17:15, Stefan Bodewig a écrit : I'm not sure whether we have any policy on this, but so far I've tried to stick with 80 columns max. Maybe that's a sign of me being old fashioned, don't know :-) 80 columns is quite restrictive with today's wide screens and often cause excessive

Re: svn commit: r1511316 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java test/java/org/apache/commons/compress/archivers/cpio/

2013-08-07 Thread Emmanuel Bourg
Le 07/08/2013 16:41, sebb a écrit : -1 Surely that will cause API breakage? I don't think so, this is source and binary compatible, unless someone extended the class and overrode the method, which is very unlikely. I wrote a simple test and compiled it with Commons Compress 1.5:

[Math] Fluent API, inheritance and immutability

2013-08-07 Thread Gilles
Hi. It seems that each two of those concepts are at odds with the third one. E.g. you can have a fluent API and immutability, but this then prevents you from defining fluent API methods in a base class because immutability requires creating a new object (but the base class cannot know how to

Re: [Math] Fluent API, inheritance and immutability

2013-08-07 Thread Ted Dunning
This is often dealt with by using builder classes and not putting all the fluent methods on the objects being constructed. The other way to deal with this is to use a covariant return type. For instance, there is no guarantee that Pattern.compile returns any particular class other than that it

[VFS] RAM Provider review and questions

2013-08-07 Thread Bernd Eckenfels
Hello, I had a look at the VFS2 RAM Provider in 2.0 and have some questions comments: RamFileData.java #52 byte[] buffer - this is the actual content of the file, I would name it that way. Buffer sounds transient #62 CollectionRamFileData - this keeps references to all

[Math] Fluent API, inheritance and immutability

2013-08-07 Thread Evan Ward
Hi, As a grateful user of the library, I would prefer the Fluent API and immutability. I have implemented this pattern in some of my own projects and it makes the API very easy to use. Most of the time, when the interface is small, inheritance isn't really necessary and I just implement the

Re: [Math] Fluent API, inheritance and immutability

2013-08-07 Thread Gilles
On Wed, 7 Aug 2013 13:39:41 -0700, Ted Dunning wrote: This is often dealt with by using builder classes and not putting all the fluent methods on the objects being constructed. Builders seem fine when no inheritance is involved: all fields are duplicated (and mutable) in the builder, then an

Re: [Math] Fluent API, inheritance and immutability

2013-08-07 Thread Gilles
On Wed, 7 Aug 2013 18:04:39 -0400, Evan Ward wrote: Hi, As a grateful user of the library, I would prefer the Fluent API and immutability. I have implemented this pattern in some of my own projects and it makes the API very easy to use. Most of the time, when the interface is small,

Re: [VFS] RAM Provider review and questions

2013-08-07 Thread Gary Gregory
I created https://issues.apache.org/jira/browse/VFS-483 to track all of this. See the link for updates and status. Gary On Wed, Aug 7, 2013 at 5:36 PM, Bernd Eckenfels e...@zusammenkunft.netwrote: Hello, I had a look at the VFS2 RAM Provider in 2.0 and have some questions comments:

Re: [VFS] RAM Provider review and questions

2013-08-07 Thread Bernd Eckenfels
Am 08.08.2013, 03:49 Uhr, schrieb Gary Gregory garydgreg...@gmail.com: https://issues.apache.org/jira/browse/VFS-483 to track all of this. See the link for updates and status. Very cool thanks, I would also have files some, after discussion where a change makes sense. I filed this one here

[continuum] BUILD FAILURE: Apache Commons - Commons VFS -

2013-08-07 Thread Continuum@vmbuild
Local Maven 2 Build Definition (Java 1.6) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 129 X-Continuum-Project-Name: Commons VFS Online report :

Re: [pool] 2.0 factory interfaces WAS: Re: svn commit: r1506685 - in /commons/proper/pool/trunk/src: main/java/org/apache/commons/pool2/ main/java/org/apache/commons/pool2/impl/ test/java/org/apache/

2013-08-07 Thread Phil Steitz
On 8/4/13 9:27 AM, Phil Steitz wrote: On 8/4/13 7:24 AM, Mark Thomas wrote: On 03/08/2013 17:15, Phil Steitz wrote: On 7/30/13 9:16 AM, Phil Steitz wrote: I have started working on this. Should have something to commit at least for GOP in the next day or two. I am stuck on

Re: [VFS] RAM Provider review and questions

2013-08-07 Thread Gary Gregory
On Wed, Aug 7, 2013 at 10:02 PM, Bernd Eckenfels e...@zusammenkunft.netwrote: Am 08.08.2013, 03:49 Uhr, schrieb Gary Gregory garydgreg...@gmail.com: https://issues.apache.org/**jira/browse/VFS-483https://issues.apache.org/jira/browse/VFS-483 to track all of this. See the link for updates

[continuum] BUILD FAILURE: Apache Commons - Commons VFS -

2013-08-07 Thread Continuum@vmbuild
Local Maven 2 Build Definition (Java 1.6) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Continuum-Build-Host: vmbuild X-Continuum-Project-Id: 129 X-Continuum-Project-Name: Commons VFS Online report :

Re: [continuum] BUILD FAILURE: Apache Commons - Commons VFS -

2013-08-07 Thread Gary Gregory
Hi all, Is this a corrupted maven local cache issue? A maven 2 vs 3 issue? Gary On Aug 7, 2013, at 23:21, Continuum@vmbuild contin...@apache.org wrote: Local Maven 2 Build Definition (Java 1.6) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: