[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-cli/pull/16
  
The findbugs version used is not java 6 compatible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-cli/pull/16
  
The findbugs version used is not java 6 compatible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

[ameyjadiye]

Github user ameyjadiye commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/61#discussion_r130978503
  
--- Diff: pom.xml ---
@@ -171,6 +171,7 @@
   src/site/resources/download_lang.cgi
   
src/test/resources/stringEscapeUtilsTestData.txt
   
src/site/resources/release-notes/RELEASE-NOTES-*.txt
+  .travis.sh
--- End diff --

Sure, this was quick fix ;-) ... one more thing, do we need consent from 
jacoco using and modifying their file ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

[ameyjadiye]

Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-cli/pull/16
  
@PascalSchumacher , can you take a look at this ? seems only issue with 
findbug on  java6 build, rest seems Ok. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

[ameyjadiye]

Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-cli/pull/16
  
@PascalSchumacher , can you take a look at this ? seems only issue with 
findbug on  java6 build, rest seems Ok. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

[chtompki]

Github user chtompki commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/61#discussion_r130979086
  
--- Diff: pom.xml ---
@@ -171,6 +171,7 @@
   src/site/resources/download_lang.cgi
   
src/test/resources/stringEscapeUtilsTestData.txt
   
src/site/resources/release-notes/RELEASE-NOTES-*.txt
+  .travis.sh
--- End diff --

It looks like, with a quick read of their License.md, that we would 
minimally need to include their license at the end of ours, but I would have to 
defer to others for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/61
  
Also note that currently this script only compiles and runs test.  Rat, 
clirr, findbugs and javadoc are not executed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

[chtompki]

Github user chtompki commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/61#discussion_r130977723
  
--- Diff: pom.xml ---
@@ -171,6 +171,7 @@
   src/site/resources/download_lang.cgi
   
src/test/resources/stringEscapeUtilsTestData.txt
   
src/site/resources/release-notes/RELEASE-NOTES-*.txt
+  .travis.sh
--- End diff --

You could put an Apache License comment at the top of this file because it 
accommodates comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [all/travis-ci] Regarding using ibmjava on travis

[Amey Jadiye]

Hello All,

We need community opinion here as this change request can improve / affect
many other components in near future.

I have proposed the change in PR
https://github.com/apache/commons-text/pull/61 so the travis builds can
become more flexible and we will have more control over the different
flavours, versions and vendors of jdk we wants to use via travis build
process. I personally think that travis is very slow providing the
different versions of jdk ATM ... PR contains two files one is generic
.travis.sh which is generalised and .travis.yml which is commons-text
specific.

Some may feel script is complex [I don't think it is complex might be
because I worked on it ;-)] but once it become mature it will be pretty
stable and need no change, depending on components requirements each can
decide which jdk/vendor/version they want in their .travis.yml

For the sake of start and demo I have added wide verity of jdk in build
like java7, java8, java9, earyl access, eclipse compiler option, oraclejdk,
openjdk, ibm jdk etc and that can me made configurable easily so no
much maintenance needed once we are done with it, I'm expecting
improvements / suggestions from you guys to improve it more for the need of
commons.

Other thing I'm proposing is to have this script as .travis.parent.sh and
we can keep it somewhere centralised http location and wget it and execute
from .travis.sh so core logic will have to maintain at single place, change
will be only in respective .travis.yml.

what do you guys think ?

Regards,
Amey

On Fri, Jul 28, 2017 at 6:02 PM, Amey Jadiye  wrote:

> Thanks, I'm taking Commons Text as my test guineapig for jacoco style
> implementation , once confident in implementation we can move it to other
> components.
>
> Regards,
> Amey
>
> On Jul 28, 2017 5:39 PM, "Rob Tompkins"  wrote:
>
>>
>> > On Jul 27, 2017, at 4:10 PM, Amey Jadiye  wrote:
>> >
>> > Hi Rob,
>> >
>> > If this is still pending I would like to pickup this task. If docker is
>> not
>> > much  helpful OR we need to wait for it I think we should try what
>> jacoco
>> > did. what do you think ?
>>
>> Sure. That makes sense to me, especially since the Travis folks say that
>> they’ve got on the backlog to install the IBM JDKs on their build
>> environments.
>>
>> >
>> > Is it mandatory to use official java images ?Else I am also thinking to
>> > create my own ibmjdk8 image on top of given by IBM and have some tools
>> and
>> > scrips  ready in that so on fail it should return -1.
>>
>> I contributed to the official maven docker image to add the ibm jdk, but
>> I”m not sure how the build works out there. So I’m not sure it’s in docker
>> hub yet.
>>
>> >
>> > Not sure how much travis-ci be helpful here since I saw Pascal removed
>> > oraclejdk7 from .travis configuration because its not available. I'm not
>> > keeping much hopes on Travis  at this point as their provision on
>> different
>> > jdk images seems very slow to me .
>>
>> I think there was some flavour of issue with Java7 in that the image
>> wasn’t loading properly. It could be worth trying the jacoco approach to
>> see if that works.
>>
>>   -Rob
>>
>> >
>> > Regards,
>> > Amey
>> >
>> > On Sat, Jul 1, 2017, 6:43 PM Rob Tompkins  wrote:
>> >
>> >> Hello all,
>> >>
>> >> Pardon my disappearance for the last week or so. My day job has been a
>> >> little over consuming (c’est la vie). Regardless, I’ve been looking at
>> how
>> >> we can use the current appetite in the travis-ci community to push
>> them to
>> >> install ibmjava8 and ibmjava9 in this working thread:
>> >> https://github.com/travis-ci/travis-ci/issues/2682 <
>> >> https://github.com/travis-ci/travis-ci/issues/2682>. Hopefully we can
>> >> gain some traction there.
>> >>
>> >> Regardless, they seem to have far more idk’s installed in their build
>> >> environment than documented
>> >> https://github.com/travis-ci/travis-cookbooks/tree/master/co
>> okbooks/travis_java/recipes
>> >> <
>> >> https://github.com/travis-ci/travis-cookbooks/tree/master/co
>> okbooks/travis_java/recipes>.
>> >> Which, as Amey noted earlier, jacoco seems to be utilizing
>> >> https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23 <
>> >> https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23>.
>> >>
>> >> I’m not particularly looking for any responses to this email. I more
>> just
>> >> wanted to document my current research efforts here.
>> >>
>> >> Cheers,
>> >> -Rob
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>


-- 

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons JCS 2.2 based on RC1

[Thomas Vandahl]

On 02.08.17 15:32, Thomas Vandahl wrote:
>   [X] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
> 

Bye, Thomas


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

[chtompki]

Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/61
  
Personally I'm a +0 to +1 on this, but @PascalSchumacher has a very valid 
point. I try to subscribe to the thought that there should be a high bar to 
sacrificing simplicity. So, with that in mind, should we take this up to the 
dev list to get other folks opinions? That work for you guys?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[VOTE] Release Apache Commons JCS 2.2 based on RC1

[Thomas Vandahl]

I would like to release the [jcs] component to resolve some overdue bugs

Apache Commons JCS 2.2 RC1 is available for review at:
  https://dist.apache.org/repos/dist/dev/commons/jcs/ (r20728).

Maven artifacts are at:
  https://repository.apache.org/content/repositories/orgapachecommons-1256 .

The Subversion tag is:

https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2
(r1803806).

The release notes are at:

https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2/RELEASE-NOTES.txt
(r1803806).

The staged site is available as a tarball at

https://dist.apache.org/repos/dist/dev/commons/jcs/commons-jcs-site-2.2.tar.gz
(r20723).

Please review the release candidate and vote.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Bye, Thomas

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-io pull request #41: Missing Test Case for negative offset value

[ileontiuc]

GitHub user ileontiuc opened a pull request:

https://github.com/apache/commons-io/pull/41

Missing Test Case for negative offset value

The method copyLarge(InputStream input, InputStream output, int offset, 
buffer) copies the content of input into output. If offset is a positive 
number, it will skip a number of bytes from input equal to offset value. By 
performing mutation testing analysis we noticed that the copyLarge method was 
never tested for a negative value for offset. The added test call copyLarge 
with a negative value and check that the behavior is the same as for offset = 
0, where no bytes are skipped from input.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ileontiuc/commons-io patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-io/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit 86fb8a11d638ba385fca1a1bad4ea02d8ba0a83d
Author: Ioana Leontiuc 
Date:   2017-08-02T14:09:30Z

Missing Test Case for negative offset value

The method copyLarge(InputStream input, InputStream output, int offset, 
buffer) copies the content of input into output. If offset is a positive 
number, it will skip a number of bytes from input equal to offset value. By 
performing mutation testing analysis we noticed that the copyLarge method was 
never tested for a negative value for offset. The added test call copyLarge 
with a negative value and check that the behavior is the same as for offset = 
0, where no bytes are skipped from input.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons JCS 2.2 based on RC1

[Romain Manni-Bucau]

+1, thanks Thomas


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | JavaEE Factory


2017-08-02 15:35 GMT+02:00 Thomas Vandahl :

> On 02.08.17 15:32, Thomas Vandahl wrote:
> >   [X] +1 Release these artifacts
> >   [ ] +0 OK, but...
> >   [ ] -0 OK, but really should fix...
> >   [ ] -1 I oppose this release because...
> >
>
> Bye, Thomas
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[GitHub] commons-io pull request #41: Missing Test Case for negative offset value

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-io/pull/41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/61
  
+1 for moving this discussion to the mailing list


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org