[GitHub] commons-imaging issue #33: Imaging-209 PnmImageParser throws ImageWriteExcep...

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/33 Thank you **a lot** for including tests, and making the change so simple to be reviewed. No extra formatting, or any other change :-) Had a look at the code in Eclipse and also at the

Re: [Math][Numbers] Move Field, etc. to numbers?

2017-12-23 Thread Raymond DeCampo
What would you do with FieldElement and in particular FieldElement.getField()? On Fri, Dec 22, 2017 at 10:42 AM, Gilles wrote: > Hello. > > Sorry for not replying earlier (and the top-post). > > I've a bad feeling about "Field" and "FieldElement" as > they exist in

[ANNOUNCE] Apache Commons RDF 0.5.0 released

2017-12-23 Thread Sergio Fernández
The Apache Commons RDF team is pleased to announce the release of Apache Commons RDF 0.5.0. Commons RDF aims to provide a common library for RDF 1.1 that could be implemented by systems on the Java Virtual Machine. The Apache Commons RDF distribution includes bindings for different

[GitHub] commons-imaging issue #32: add test for DataReaderStripsTest::applyPredictor

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/32 Added an extra commit to include the license header. Thanks for your contribution @testingsavvy . Pull request merged. ---

[GitHub] commons-imaging pull request #32: add test for DataReaderStripsTest::applyPr...

2017-12-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-imaging/pull/32 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging issue #5: Proposal for a patch for Imaging-159 using a POJO

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/5 Looks like the code from the pull request and the code in the master branch have moved into too different directions, and it can't be updated any longer. @mgmechanics let me know if you

[GitHub] commons-imaging issue #30: add-tests

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/30 Looking good. I'm still just reluctant to add the new test dependency. So leaving it here for now until others have time to chime in. I'm updating merge requests now, merging what can

[GitHub] commons-imaging issue #4: IPTCParser now takes the raw bytes of an IPTCRecor...

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/4 I think from your description you have a valid use case for handling the encoding yourself, instead of letting the library use ISO-8859-1 only. I started to rebase the branch locally,

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-23 Thread Romain Manni-Bucau
Hi Jorg, It doesnt break IDE support but has some "dead" code from my understanding, no? Le 23 déc. 2017 02:33, "Jörg Schaible" a écrit : > Hi Gary, > > Am Fri, 22 Dec 2017 12:34:13 -0700 schrieb Gary Gregory: > > > Hi Jörg, > > > > Thank you for taking the time to

[GitHub] commons-imaging pull request #33: Imaging-209 PnmImageParser throws ImageWri...

2017-12-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-imaging/pull/33 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging issue #6: Imaging-167

2017-12-23 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-imaging/pull/6 Code looking good. Wonder if it would be feasible to add a test? What do you think @mgmechanics ? Not sure if worth/useful/possible to test that `Integer.MAX_VALUE`... Thanks for the

Re: [VOTE] Release Commons JCS 2.2.1 based on RC3

2017-12-23 Thread Jörg Schaible
Am Sat, 23 Dec 2017 09:06:41 +0100 schrieb Romain Manni-Bucau: > Hi Jorg, > > It doesnt break IDE support but has some "dead" code from my > understanding, > no? OK, I should have checked it myself. I got Oliver wrong and thought it contains only cruft, but the cruft is only additional ;-)

Re: [compress] release for Zstandard?

2017-12-23 Thread Stefan Bodewig
On 2017-12-22, Gary Gregory wrote: > When can we get a [compress] release? It would be nice to get Zstandard out > there. It's incomplete as it is read-only and adding write support would be as trivial as adding read-only support has been. It's only a matter of finding tme to do it. In addition

Re: [VOTE] Release Apache Commons DBCP 2.2.0 based on RC3

2017-12-23 Thread Rob Tompkins
I can do a validation in 2 hours from now. > On Dec 23, 2017, at 4:31 PM, Gary Gregory wrote: > > Thank you Sergio and Jörg! Anyone else? > > I am especially curious if anyone will encounter issues with randomly > failing tests/builds on various platforms. > > Gary >

Re: [VOTE] Release Apache Commons DBCP 2.2.0 based on RC3

2017-12-23 Thread Rob Tompkins
Mac OS X 10.13.2: Maven 3.5.0, java 1.8.0_152 - "mvn clean site” worked both times I ran it (granted I added "-Xmx4g -Xms1g"). Mac OS X 10.13.2: Maven 3.5.0, java 1.7.0_80 - "mvn clean site” works. Site looks appropriate, minor nits with the site you provided: (1) coverage seems low, (2) Some

Re: [VOTE] Release Apache Commons DBCP 2.2.0 based on RC3

2017-12-23 Thread Gary Gregory
Thank you Sergio and Jörg! Anyone else? I am especially curious if anyone will encounter issues with randomly failing tests/builds on various platforms. Gary On Fri, Dec 22, 2017 at 6:25 PM, Jörg Schaible wrote: > > +1 > > Works fine for me building from source with my

Re: [Math][Numbers] Move Field, etc. to numbers?

2017-12-23 Thread Gilles
On Sat, 23 Dec 2017 15:35:14 -0500, Raymond DeCampo wrote: What would you do with FieldElement and in particular FieldElement.getField()? I was thinking of a new interface to represent the "field" concept: ---CUT--- /** * @param Type of field element. */ public interface MathField { T

Re: [VOTE] Release Apache Commons DBCP 2.2.0 based on RC3

2017-12-23 Thread Gary Gregory
Great Rob, TY! Gary On Sat, Dec 23, 2017 at 4:15 PM, Rob Tompkins wrote: > I can do a validation in 2 hours from now. > > > On Dec 23, 2017, at 4:31 PM, Gary Gregory > wrote: > > > > Thank you Sergio and Jörg! Anyone else? > > > > I am especially