Re: [commons-lang] branch master updated: [LANG-1647] Add and ExceptionUtils.isChecked() and isUnchecked() #1069

2023-07-03 Thread Alex Herbert
On Mon, 3 Jul 2023 at 08:29, sebb wrote: > > Is null checked or unchecked? > > I think neither, so isUnchecked also needs to check for null. > > I wonder whether it might be better to throw NPE in both cases for null. > > It may be confusing for users if not checked != unchecked. > e.g. it is

Re: [commons-lang] branch master updated: [LANG-1647] Add and ExceptionUtils.isChecked() and isUnchecked() #1069

2023-07-03 Thread sebb
Is null checked or unchecked? I think neither, so isUnchecked also needs to check for null. I wonder whether it might be better to throw NPE in both cases for null. It may be confusing for users if not checked != unchecked. e.g. it is tempting to code: if (isChecked(t)) { } else { // must be

Re: [commons-lang] branch master updated: [LANG-1647] Add and ExceptionUtils.isChecked() and isUnchecked() #1069

2023-07-03 Thread Gilles Sadowski
Le lun. 3 juil. 2023 à 09:41, Alex Herbert a écrit : > > On Mon, 3 Jul 2023 at 08:29, sebb wrote: > > > > Is null checked or unchecked? > > > > I think neither, so isUnchecked also needs to check for null. > > > > I wonder whether it might be better to throw NPE in both cases for null. > > > >

Re: [commons-lang] branch master updated: [LANG-1647] Add and ExceptionUtils.isChecked() and isUnchecked() #1069

2023-07-03 Thread Dimitrios Efthymiou
yes. You are right. Closed On Mon, 3 Jul 2023 at 10:12, Gilles Sadowski wrote: > Le lun. 3 juil. 2023 à 09:41, Alex Herbert a > écrit : > > > > On Mon, 3 Jul 2023 at 08:29, sebb wrote: > > > > > > Is null checked or unchecked? > > > > > > I think neither, so isUnchecked also needs to check

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-07-03 Thread Gary Gregory
On Thu, Jun 29, 2023 at 5:08 PM Phil Steitz wrote: > > On Thu, Jun 29, 2023 at 11:39 AM Gary Gregory > wrote: > > > Great presentation in the video Elliotte. Thanks for sharing the link. > > > > +1 many thanks. > > Now back to our hero. Let me pretend to be one of the people in the > audience

Re: [commons-lang] branch master updated: --corrected the isUnchecked method to check for null (#1079)

2023-07-03 Thread Gilles Sadowski
Hi. IIUC, the discussion sparked by that new code is currently converging towards deletion: https://markmail.org/message/nlqtk6na6nvwtelo In any case, several arguments (confusing, unnecessary, useless) were mentioned so that this commit be reverted. A new thread should be started on the

[Pool] Toward version 2.12.0 and 3.0

2023-07-03 Thread Gary Gregory
Hi all, This is a switch from the 2.12.0 vote mail thread in order to discuss 3.0 and 2.x releases. I propose we switch master to 3.0 and create a branch called 2.x based and an old commit and release 2.12.0 from there. Gary

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-07-03 Thread Phil Steitz
On Mon, Jul 3, 2023 at 6:41 AM Gary Gregory wrote: > On Thu, Jun 29, 2023 at 5:08 PM Phil Steitz wrote: > > > > On Thu, Jun 29, 2023 at 11:39 AM Gary Gregory > > wrote: > > > > > Great presentation in the video Elliotte. Thanks for sharing the link. > > > > > > > +1 many thanks. > > > > Now

Re: [VOTE] Release Apache Commons Pool 2.12.0 based on RC1

2023-07-03 Thread Gary Gregory
Hi Phil, Starting a new mailing thread is a good idea at this point. I'll just mention: I really do not want to roll back code changes in master. If you want to pick a commit in the past and create a branch 2.x from that, it's fine with me, or tell me, and I'll be happy to create the branch. Then

Re: [Pool] Toward version 2.12.0 and 3.0

2023-07-03 Thread Phil Steitz
+1 Phil On Mon, Jul 3, 2023 at 9:41 AM Gary Gregory wrote: > Hi all, > > This is a switch from the 2.12.0 vote mail thread in order to discuss 3.0 > and 2.x releases. > > I propose we switch master to 3.0 and create a branch called 2.x based and > an old commit and release 2.12.0 from there. >

Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?

2023-07-03 Thread Dennis Kieselhorst
Hi Gary, what's blocking the 2.0.0-M1 release? Can I help implementing it? Best, Dennis - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org