[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed

2012-09-04 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-scxml-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-jelly-tags-sql (in module commons-jelly) failed

2012-09-04 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-jelly-tags-sql has an issue affecting its community integration.

Re: [all] Checkstyle and '+' should be on the previous line.

2012-09-04 Thread Mark Thomas
Gilles Sadowski gil...@harfang.homelinux.org wrote: If you do find it ridiculous, it is indeed only because of habit; others might be used to (and thus prefer) y - x Personally, I find: a = y - x; easier to read than: a = y - x; In the former I tend to miss that there isn't a ';' at

Re: [all] Checkstyle and '+' should be on the previous line.

2012-09-04 Thread Gilles Sadowski
Hi. If you do find it ridiculous, it is indeed only because of habit; others might be used to (and thus prefer) y - x Personally, I find: a = y - x; easier to read than: a = y - x; In the former I tend to miss that there isn't a ';' at the end of the line and that

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread Gilles Sadowski
Hi. FindBugs can give warnings like: Switch statement found in org.apache.commons.codec.binary.Base32.decode(byte[], int, int, BaseNCodec$Context) where default case is missing In this case for [codec], it looks like the code was carefully constructed and that no default clause is

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread Benedikt Ritter
Hi Gary, IMHO FindBugs is supposed to point you at code fragments that potentially could cause subtle bugs. If say that the code in codec is carefully constructed and everything is backed up by junit tests, I'd say a default clause is nosy and doesn't add anything. OTOH if you can not see that no

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread James Carman
Something like: throw new IllegalArgumentException(This should never happen because we are so smart we thought of every possibility in our case statement.); would suffice :) On Tue, Sep 4, 2012 at 9:02 AM, Benedikt Ritter benerit...@gmail.com wrote: Hi Gary, IMHO FindBugs is supposed to

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread Sébastien Brisard
Hello, 2012/9/4 James Carman ja...@carmanconsulting.com: Something like: throw new IllegalArgumentException(This should never happen because we are so smart we thought of every possibility in our case statement.); would suffice :) Not that it really matters, since this is never going to

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread Gary Gregory
On Tue, Sep 4, 2012 at 9:01 AM, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hi. FindBugs can give warnings like: Switch statement found in org.apache.commons.codec.binary.Base32.decode(byte[], int, int, BaseNCodec$Context) where default case is missing In this case for

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-04 Thread Henri Yandell
Both on the first question :) Not me on the second. On Mon, Sep 3, 2012 at 4:11 AM, James Carman ja...@carmanconsulting.com wrote: Cool as in that's great that we're getting contributions from folks via Github or cool as in it's cool to use patches via Github pull requests, since there's an

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-04 Thread James Carman
So, has the ASF said that github pull requests coming into our mailing lists will suffice as far as granting the ASF license? On Tue, Sep 4, 2012 at 10:50 AM, Henri Yandell flame...@gmail.com wrote: Both on the first question :) Not me on the second. On Mon, Sep 3, 2012 at 4:11 AM, James

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-04 Thread Gary Gregory
Note: Windows 8 is version 6.2 per http://msdn.microsoft.com/en-us/library/windows/desktop/hh848058%28v=vs.85%29.aspx Gary On Sat, Sep 1, 2012 at 8:19 PM, Olloth g...@git.apache.org wrote: GitHub user Olloth opened a pull request: https://github.com/apache/commons-lang/pull/2

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread James Carman
I wasn't necessarily saying that we should always use IllegalArgumentException (although it can be applicable if the thing being switched upon is an argument to the method). The idea was that we could throw an exception of some sort in our default clause. On Tue, Sep 4, 2012 at 10:44 AM,

Re: commons-lang pull request: Update src/main/java/org/apache/commons/lang3/Sy...

2012-09-04 Thread Gary Gregory
I just created the static independently from this pull request. Committed revision 1380679 as [LANG-817]. Gary On Sat, Sep 1, 2012 at 8:19 PM, Olloth g...@git.apache.org wrote: GitHub user Olloth opened a pull request: https://github.com/apache/commons-lang/pull/2 Update

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread Sébastien Brisard
Sorry James, you misunderstood me. My point was just that Bloch seems to be consistently using the same exception, namely AssertionError, but that I'd rather use IllegalStateException. Of course, in some cases IllegalArgumentException would make sense. S 2012/9/4 James Carman

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread Gilles Sadowski
FindBugs can give warnings like: Switch statement found in org.apache.commons.codec.binary.Base32.decode(byte[], int, int, BaseNCodec$Context) where default case is missing In this case for [codec], it looks like the code was carefully constructed and that no default

Re: [math] UnexpectedNegativeIntegerException

2012-09-04 Thread Gilles Sadowski
Hello. I realize I'm a little late to the party here, Late or early; these issues pop up again after while... :-) so if I'm asking or suggesting things that are naive just let me know straight up, and I'll try to educate myself better. There are ideas that sound good we experiment with

Re: [all] FindBugs' Switch statement found in class.method where default case is missing

2012-09-04 Thread Liviu Tudor
Hi guys, I am looking at this from a different perspective: the same check can be performed using checkstyle (http://checkstyle.sourceforge.net/config_coding.html#MissingSwitchDefault) as well as FindBugs. So if this is a valid case where there is no need for a default branch, we could perhaps

[GUMP@vmgump]: Project commons-dbcp (in module commons-dbcp-1.x) failed

2012-09-04 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-dbcp has an issue affecting its community integration. This issue

[GUMP@vmgump]: Project commons-dbcp2 (in module apache-commons) failed

2012-09-04 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-dbcp2 has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-exec-test (in module apache-commons) failed

2012-09-04 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-exec-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-digester3 (in module apache-commons) failed

2012-09-04 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-digester3 has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-chain2 (in module apache-commons) failed

2012-09-04 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-chain2 has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2012-09-04 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-dbutils (in module apache-commons) failed

2012-09-04 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-dbutils has an issue affecting its community integration. This

[math] IllegalStateException thrown by Kurtosis increment and clear methods

2012-09-04 Thread Phil Steitz
Slugging my way through the MATH-854 changes for the stats package, I have found an anomaly that I would like to fix. When a Kurtosis instance is constructed using an external moment, increment and clear methods do not behave as no-ops as they do for Variance, SecondMoment and the other moment