Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-06 Thread Oliver Heger

Hi Benedikt,

Am 05.11.2012 21:04, schrieb Benedikt Ritter:

2012/11/5 Benedikt Ritter benerit...@gmail.com


Hi Oliver,


2012/11/5 ohe...@apache.org

Author: oheger

Date: Mon Nov  5 17:29:01 2012
New Revision: 1405889

URL: http://svn.apache.org/viewvc?rev=1405889view=rev
Log:
Initial version of an immutable configuration interface.

Added:

commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/ImmutableConfiguration.java
   (with props)
Modified:

commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java

Modified:
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
URL:
http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java?rev=1405889r1=1405888r2=1405889view=diff

==
---
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
(original)
+++
commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
Mon Nov  5 17:29:01 2012
@@ -17,11 +17,6 @@

  package org.apache.commons.configuration;

-import java.math.BigDecimal;
-import java.math.BigInteger;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Properties;

  /**
   * pThe main Configuration interface./p
@@ -54,7 +49,7 @@ import java.util.Properties;
   * @author Commons Configuration team
   * @version $Id$
   */
-public interface Configuration
+public interface Configuration extends ImmutableConfiguration



A Configuration IS_A ImmutableConfiguration sounds rather akward. The
JavaDoc of ImmutableConfiguration says The main interface for accessing
configuration data in a read-only fashion. Maybe ImmutableConfiguration
should be renamed to ReadOnlyConfiguration?

Regards,
Benedikt



Looking at the code base, there is no class that implements
ImmutableConfiguration directly and Configuration is the only interface
that extends ImmutableConfiguration. So maybe the two can be merged
together?


The ImmutableConfiguration interface has just been extracted from 
Configuration in order to implement the feature of immutable 
configurations. It contains all methods that do not manipulate the 
configuration. A full-blown configuration extends this functionality by 
additional update operations.


It is true that currently all concrete Configuration implementations 
support the extended interface with update operations. However, 
ImmutableConfiguration is implemented by dynamic proxies which provide 
an immutable view on an arbitrary Configuration object.


Regarding the name: I am open for suggestions. ReadOnlyConfiguration, 
ImmutableConfiguration, UnmodifiableConfiguration,... Maybe a native 
speaker can comment?


Oliver



Benedikt






  {
  /**
   * Return a decorator Configuration containing every key from the
current
@@ -90,24 +85,6 @@ public interface Configuration
  Configuration subset(String prefix);

  /**
- * Check if the configuration is empty.
- *
- * @return {@code true} if the configuration contains no property,
- * {@code false} otherwise.
- */
-boolean isEmpty();
-
-/**
- * Check if the configuration contains the specified key.
- *
- * @param key the key whose presence in this configuration is to be
tested
- *
- * @return {@code true} if the configuration contains a value for
this
- * key, {@code false} otherwise
- */
-boolean containsKey(String key);
-
-/**
   * Add a property to the configuration. If it already exists then
the value
   * stated here will be added to the configuration entry. For
example, if
   * the property:
@@ -147,452 +124,4 @@ public interface Configuration
   * Remove all properties from the configuration.
   */
  void clear();
-
-/**
- * Gets a property from the configuration. This is the most basic get
- * method for retrieving values of properties. In a typical
implementation
- * of the {@code Configuration} interface the other get methods (that
- * return specific data types) will internally make use of this
method. On
- * this level variable substitution is not yet performed. The
returned
- * object is an internal representation of the property value for
the passed
- * in key. It is owned by the {@code Configuration} object. So a
caller
- * should not modify this object. It cannot be guaranteed that this
object
- * will stay constant over time (i.e. further update operations on
the
- * configuration may change its internal state).
- *
- * @param key property to retrieve
- * @return the value to which this configuration maps the specified
key, or
- * null if the configuration contains no mapping for this
key.
- */
-Object getProperty(String key);

Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-06 Thread Benedikt Ritter
Hi Jörg,

specialization between two concpets in the oo paradigm has the semantics of
a is-a-relationship. So if Configuration extends ImmutableConfiguration
that means (at least for me) that a Configuration is a
ImmutableConfiguration.
That's what I meant with my first comment.

About merging the two:
If there is no class that implements ImmutableConfiguration and no
interface other then Configuration that extends it. What is the point of
having it in the first place?
For example the two could be merged together and a class
AbstractImmutableConfiguration could implement the merged Interface (let's
call it Configuration). That class would throw
UnsupportedOperationException if one of the write methods is called.
This would be like the definition of Collection.add(E o). Subclasses may
implement the add operation but can also chose not to.

Benedikt


2012/11/5 Jörg Schaible joerg.schai...@gmx.de

 Benedikt Ritter wrote:

  2012/11/5 Benedikt Ritter benerit...@gmail.com
 
  Hi Oliver,
 
 
  2012/11/5 ohe...@apache.org
 
  Author: oheger
  Date: Mon Nov  5 17:29:01 2012
  New Revision: 1405889
 
  URL: http://svn.apache.org/viewvc?rev=1405889view=rev
  Log:
  Initial version of an immutable configuration interface.
 
  Added:
 
 

 commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/ImmutableConfiguration.java
(with props)
  Modified:
 
 

 commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
 
  Modified:
 

 commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
  URL:
 

 http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java?rev=1405889r1=1405888r2=1405889view=diff
 
 

 ==
  ---
 

 commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
  (original)
  +++
 

 commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java
  Mon Nov  5 17:29:01 2012
  @@ -17,11 +17,6 @@
 
   package org.apache.commons.configuration;
 
  -import java.math.BigDecimal;
  -import java.math.BigInteger;
  -import java.util.Iterator;
  -import java.util.List;
  -import java.util.Properties;
 
   /**
* pThe main Configuration interface./p
  @@ -54,7 +49,7 @@ import java.util.Properties;
* @author Commons Configuration team
* @version $Id$
*/
  -public interface Configuration
  +public interface Configuration extends ImmutableConfiguration
 
 
  A Configuration IS_A ImmutableConfiguration sounds rather akward. The
  JavaDoc of ImmutableConfiguration says The main interface for accessing
  configuration data in a read-only fashion. Maybe ImmutableConfiguration
  should be renamed to ReadOnlyConfiguration?
 
  Regards,
  Benedikt
 
 
  Looking at the code base, there is no class that implements
  ImmutableConfiguration directly and Configuration is the only interface
  that extends ImmutableConfiguration. So maybe the two can be merged
  together?

 And why do YOU think, that an immutable and a mutable Configuration is the
 same thing? Sorry, your comments do not make any sense to me!

 - Jörg


 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org




Re: [lang] Time for 3.2?

2012-11-06 Thread Duncan Jones
On 6 November 2012 02:02, Gary Gregory garydgreg...@gmail.com wrote:
 Hi All:

 I just committed a fix for [lang] and realized it's been a YEAR since 3.1!
 Wow, time flies.

 Are we ready for a release?

 Does anyone have anything they'd like to contribute?

 Gary

If anyone has the time to review it, I'd happily see the
DifferenceBuilder classes included in the release
(https://issues.apache.org/jira/browse/LANG-637).

I've also submitted a patch for
https://issues.apache.org/jira/browse/LANG-757, which handles HTML
escapes without semi-colons. Not sure if anyone has had a chance to
review that yet.

Duncan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-06 Thread Benedikt Ritter
Hi Oliver,

thanks for the clarification. I see where you are going with the design.
What do you think of my proposal to implement the configuration interfaces
like the java collections framework? I can think of
Configurations.unmodifiableConfiguration(Configuration config).

Benedikt


2012/11/6 Oliver Heger oliver.he...@oliver-heger.de

 Hi Benedikt,

 Am 05.11.2012 21:04, schrieb Benedikt Ritter:

  2012/11/5 Benedikt Ritter benerit...@gmail.com

  Hi Oliver,


 2012/11/5 ohe...@apache.org

 Author: oheger

 Date: Mon Nov  5 17:29:01 2012
 New Revision: 1405889

 URL: 
 http://svn.apache.org/viewvc?**rev=1405889view=revhttp://svn.apache.org/viewvc?rev=1405889view=rev
 Log:
 Initial version of an immutable configuration interface.

 Added:

 commons/proper/configuration/**trunk/src/main/java/org/**
 apache/commons/configuration/**ImmutableConfiguration.java
(with props)
 Modified:

 commons/proper/configuration/**trunk/src/main/java/org/**
 apache/commons/configuration/**Configuration.java

 Modified:
 commons/proper/configuration/**trunk/src/main/java/org/**
 apache/commons/configuration/**Configuration.java
 URL:
 http://svn.apache.org/viewvc/**commons/proper/configuration/**
 trunk/src/main/java/org/**apache/commons/configuration/**
 Configuration.java?rev=**1405889r1=1405888r2=1405889**view=diffhttp://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java?rev=1405889r1=1405888r2=1405889view=diff

 ==**==**
 ==
 ---
 commons/proper/configuration/**trunk/src/main/java/org/**
 apache/commons/configuration/**Configuration.java
 (original)
 +++
 commons/proper/configuration/**trunk/src/main/java/org/**
 apache/commons/configuration/**Configuration.java
 Mon Nov  5 17:29:01 2012
 @@ -17,11 +17,6 @@

   package org.apache.commons.**configuration;

 -import java.math.BigDecimal;
 -import java.math.BigInteger;
 -import java.util.Iterator;
 -import java.util.List;
 -import java.util.Properties;

   /**
* pThe main Configuration interface./p
 @@ -54,7 +49,7 @@ import java.util.Properties;
* @author Commons Configuration team
* @version $Id$
*/
 -public interface Configuration
 +public interface Configuration extends ImmutableConfiguration


 A Configuration IS_A ImmutableConfiguration sounds rather akward. The
 JavaDoc of ImmutableConfiguration says The main interface for accessing
 configuration data in a read-only fashion. Maybe ImmutableConfiguration
 should be renamed to ReadOnlyConfiguration?

 Regards,
 Benedikt


 Looking at the code base, there is no class that implements
 ImmutableConfiguration directly and Configuration is the only interface
 that extends ImmutableConfiguration. So maybe the two can be merged
 together?


 The ImmutableConfiguration interface has just been extracted from
 Configuration in order to implement the feature of immutable
 configurations. It contains all methods that do not manipulate the
 configuration. A full-blown configuration extends this functionality by
 additional update operations.

 It is true that currently all concrete Configuration implementations
 support the extended interface with update operations. However,
 ImmutableConfiguration is implemented by dynamic proxies which provide an
 immutable view on an arbitrary Configuration object.

 Regarding the name: I am open for suggestions. ReadOnlyConfiguration,
 ImmutableConfiguration, UnmodifiableConfiguration,... Maybe a native
 speaker can comment?

 Oliver



 Benedikt




{
   /**
* Return a decorator Configuration containing every key from the
 current
 @@ -90,24 +85,6 @@ public interface Configuration
   Configuration subset(String prefix);

   /**
 - * Check if the configuration is empty.
 - *
 - * @return {@code true} if the configuration contains no property,
 - * {@code false} otherwise.
 - */
 -boolean isEmpty();
 -
 -/**
 - * Check if the configuration contains the specified key.
 - *
 - * @param key the key whose presence in this configuration is to be
 tested
 - *
 - * @return {@code true} if the configuration contains a value for
 this
 - * key, {@code false} otherwise
 - */
 -boolean containsKey(String key);
 -
 -/**
* Add a property to the configuration. If it already exists then
 the value
* stated here will be added to the configuration entry. For
 example, if
* the property:
 @@ -147,452 +124,4 @@ public interface Configuration
* Remove all properties from the configuration.
*/
   void clear();
 -
 -/**
 - * Gets a property from the configuration. This is the most basic
 get
 - * method for retrieving values of properties. In a typical
 implementation
 - * of the {@code Configuration} interface the other get methods
 (that
 - * return specific data types) will internally 

[GUMP@vmgump]: Project commons-digester3 (in module apache-commons) failed

2012-11-06 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-digester3 has an issue affecting its community integration.
This issue affects 2 projects,
 and has been outstanding for 172 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-digester3 :  XML to Java Object Configuration
- commons-digester3-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-digester3/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-digester3-*[0-9T].jar] identifier set to 
project name
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/digester/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/apache-commons/digester/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-digester3/gump_work/build_apache-commons_commons-digester3.html
Work Name: build_apache-commons_commons-digester3 (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 min 1 sec
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings 
/srv/gump/public/workspace/apache-commons/digester/gump_mvn_settings.xml 
package 
[Working Directory: /srv/gump/public/workspace/apache-commons/digester]
M2_HOME: /opt/maven2
-
[INFO] [remote-resources:process {execution: default}]
[INFO] [buildnumber:create {execution: default}]
[INFO] Checking for local modifications: skipped.
[INFO] Updating project files from SCM: skipped.
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor  svn 
--non-interactive info
[INFO] Working directory: 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor
[INFO] Storing buildNumber: ?? at timestamp: 1352198206358
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor  svn 
--non-interactive info
[INFO] Working directory: 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor
[INFO] Storing buildScmBranch: UNKNOWN_BRANCH
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] Copying 2 resources to META-INF
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 5 source files to 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/target/classes
[INFO] [bundle:manifest {execution: bundle-manifest}]
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/src/test/resources
[INFO] Copying 0 resource to META-INF
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 3 source files to 
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/target/test-classes
@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern=rss/channel)
@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern=rss/channel/image)
@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern=rss/channel/item)

[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] error: Impossible to generate class 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule: 
Attempt to recreate a file for type 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule
[ERROR] error: Impossible to generate class 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule: 
Attempt to recreate a file for type 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule
[INFO] 2 errors 
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure

error: Impossible to generate class 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule: 
Attempt to recreate a file for type 
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule

[GUMP@vmgump]: Project commons-chain2 (in module apache-commons) failed

2012-11-06 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-chain2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 189 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-chain2 :  GoF Chain of Responsibility pattern


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-chain2-*[0-9T].jar] identifier set to project 
name
 -DEBUG- Sole pom output [pom.xml] identifier set to project name
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/chain/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/chain/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/gump_work/build_apache-commons_commons-chain2.html
Work Name: build_apache-commons_commons-chain2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 min 2 secs
Command Line: /opt/maven2/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/chain/gump_mvn_settings.xml package 
[Working Directory: /srv/gump/public/workspace/apache-commons/chain]
M2_HOME: /opt/maven2
-
[INFO] Building war: 
/srv/gump/public/workspace/apache-commons/chain/apps/cookbook-examples/target/chain-cookbook-examples-2.0-SNAPSHOT.war
[INFO] 
[INFO] Building Apache Commons Chain :: Distribution Packages
[INFO]task-segment: [package]
[INFO] 
[INFO] snapshot org.apache.commons:commons-chain2-configuration:2.0-SNAPSHOT: 
checking for updates from apache.snapshots
Downloading: 
http://localhost:8192/repo/m2-snapshot-repository/org/apache/commons/commons-chain2-configuration/2.0-SNAPSHOT/commons-chain2-configuration-2.0-SNAPSHOT.pom
[INFO] Unable to find resource 
'org.apache.commons:commons-chain2-configuration:pom:2.0-SNAPSHOT' in 
repository apache.snapshots (http://repository.apache.org/snapshots)
Downloading: 
http://localhost:8192/repo/m2-snapshot-repository/org/apache/commons/commons-chain2-configuration/2.0-SNAPSHOT/commons-chain2-configuration-2.0-SNAPSHOT.jar
[INFO] Unable to find resource 
'org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT' in 
repository apache.snapshots (http://repository.apache.org/snapshots)
[INFO] 
[ERROR] BUILD ERROR
[INFO] 
[INFO] Failed to resolve artifact.

Missing:
--
1) org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT

  Try downloading the file manually from the project website.

  Then, install it using the command: 
  mvn install:install-file -DgroupId=org.apache.commons 
-DartifactId=commons-chain2-configuration -Dversion=2.0-SNAPSHOT 
-Dpackaging=jar -Dfile=/path/to/file

  Alternatively, if you host your own repository you can deploy the file there: 
  mvn deploy:deploy-file -DgroupId=org.apache.commons 
-DartifactId=commons-chain2-configuration -Dversion=2.0-SNAPSHOT 
-Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]

  Path to dependency: 
1) org.apache.commons:commons-chain2:pom:2.0-SNAPSHOT
2) org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT

--
1 required artifact is missing.

for artifact: 
  org.apache.commons:commons-chain2:pom:2.0-SNAPSHOT

from the specified remote repositories:
  gump-central (http://localhost:8192/maven2),
  gump-apache.snapshots (http://localhost:8192/repo/m2-snapshot-repository)



[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] 
[INFO] Total time: 1 minute 
[INFO] Finished at: Tue Nov 06 11:47:32 UTC 2012
[INFO] Final Memory: 114M/241M
[INFO] 
-

To subscribe to this information via syndicated feeds:
- RSS: 
http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/rss.xml
- Atom: 

[continuum] BUILD FAILURE: Apache Commons - Apache Commons Digester - Build using Java 1.6

2012-11-06 Thread Continuum@vmbuild
Online report : 
http://vmbuild.apache.org/continuum/buildResult.action?buildId=25179projectId=75

Build statistics:
  State: Failed
  Previous State: Failed
  Started at: Tue 6 Nov 2012 12:20:02 +
  Finished at: Tue 6 Nov 2012 12:21:31 +
  Total time: 1m 29s
  Build Trigger: Schedule
  Build Number: 165
  Exit code: 1
  Building machine hostname: vmbuild
  Operating system : Linux(unknown)
  Java Home version : 
  java version 1.6.0_30
  Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
  Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

  Builder version :
  Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+)
  Java version: 1.6.0_30
  Java home: /usr/lib/jvm/jdk1.6.0_30/jre
  Default locale: en_US, platform encoding: ANSI_X3.4-1968
  OS name: linux version: 2.6.32-41-server arch: amd64 Family: 
unix


SCM Changes:

Changed: simonetripodi @ Tue 6 Nov 2012 11:48:36 +
Comment: [DIGESTER-174] Inner List Annotation has wrong @Target for most of the 
predefined annotation rules
Files changed:
  
/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/annotations/rules/BeanPropertySetter.java
 ( 1406102 )
  
/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/annotations/rules/CallMethod.java
 ( 1406102 )
  
/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/annotations/rules/CallParam.java
 ( 1406102 )
  
/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/annotations/rules/PathCallParam.java
 ( 1406102 )
  
/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/annotations/rules/SetProperty.java
 ( 1406102 )
  
/commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/annotations/rules/SetTop.java
 ( 1406102 )
  /commons/proper/digester/trunk/src/changes/changes.xml ( 1406102 )


Dependencies Changes:

No dependencies changed



Build Definition:

POM filename: pom.xml
Goals: clean deploy   
Arguments: --batch-mode -Pjava-1.6 -Dgpg.skip -Prelease
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: COMMONS_SCHEDULE
Profile Name: Maven 2.2.1
Description: Build using Java 1.6


Test Summary:

Tests: 211
Failures: 0
Errors: 0
Success Rate: 100
Total time: 3.2880003





-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2012-11-06 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-proxy-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 3 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-proxy-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -WARNING- Overriding Maven settings: 
[/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml]
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/proxy/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/proxy/target/surefire-reports



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/gump_work/build_apache-commons_commons-proxy-test.html
Work Name: build_apache-commons_commons-proxy-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 16 secs
Command Line: /opt/maven2/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml test 
[Working Directory: /srv/gump/public/workspace/apache-commons/proxy]
M2_HOME: /opt/maven2
-
Running org.apache.commons.proxy.factory.util.TestMethodSignature
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec

Results :

Tests in error: 
  
testSerialization(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter)
  
testMethodInvocationImplementation(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter)
  
testMethodInterception(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter)
  testInvalidHandlerName(org.apache.commons.proxy.invoker.TestXmlRpcInvoker)
  
testMethodInvocation(org.apache.commons.proxy.invoker.TestInvocationHandlerAdapter)
  
testInterceptorEquals(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerEquals(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorWithSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerWithSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testProxiesWithClashingFinalMethodInSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorHashCode(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerHashCode(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testBooleanInterceptorParameter(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testChangingArguments(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testCreateInterceptorProxy(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptingProxyClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptingProxySerializable(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorProxyWithCheckedException(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInterceptorProxyWithUncheckedException(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerProxy(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerProxyClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testInvokerProxySerializable(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testMethodInvocationClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testMethodInvocationDuplicateMethods(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testMethodInvocationImplementation(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  
testWithNonAccessibleTargetType(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory)
  testCreateNullObject(org.apache.commons.proxy.TestProxyUtils)
  testCreateNullObjectWithClassLoader(org.apache.commons.proxy.TestProxyUtils)

Tests run: 179, Failures: 0, Errors: 28, Skipped: 0

[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] There 

[GUMP@vmgump]: Project commons-dbutils (in module apache-commons) failed

2012-11-06 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-dbutils has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 167 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-dbutils :  Commons DbUtils


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-dbutils/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole jar output [commons-dbutils-*[0-9T].jar] identifier set to 
project name
 -INFO- Optional dependency mockito failed with reason build failed
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/dbutils/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/dbutils/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/dbutils/target/surefire-reports
 -WARNING- No directory 
[/srv/gump/public/workspace/apache-commons/dbutils/target/surefire-reports]
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbutils/gump_work/build_apache-commons_commons-dbutils.html
Work Name: build_apache-commons_commons-dbutils (Type: Build)
Work ended in a state of : Failed
Elapsed: 21 secs
Command Line: /opt/maven2/bin/mvn --batch-mode --settings 
/srv/gump/public/workspace/apache-commons/dbutils/gump_mvn_settings.xml package 
[Working Directory: /srv/gump/public/workspace/apache-commons/dbutils]
M2_HOME: /opt/maven2
-
1K downloaded  (mockito-core-1.9.0.pom)
Downloading: 
http://localhost:8192/maven2/org/hamcrest/hamcrest-all/1.1/hamcrest-all-1.1.pom
479b downloaded  (hamcrest-all-1.1.pom)
Downloading: 
http://localhost:8192/maven2/org/mockito/mockito-core/1.9.0/mockito-core-1.9.0.jar
Downloading: 
http://localhost:8192/maven2/org/hamcrest/hamcrest-all/1.1/hamcrest-all-1.1.jar
273K downloaded  (hamcrest-all-1.1.jar)
1381K downloaded  (mockito-core-1.9.0.jar)
[INFO] [antrun:run {execution: javadoc.resources}]
[INFO] Executing tasks

main:
 [copy] Copying 2 files to 
/srv/gump/public/workspace/apache-commons/dbutils/target/apidocs/META-INF
[INFO] Executed tasks
[WARNING] The parameter expression: 'project.build.resources' used in mojo: 
'process' has been deprecated. Use 'project.resources' instead.
[INFO] [remote-resources:process {execution: default}]
[INFO] [buildnumber:create {execution: default}]
[INFO] Checking for local modifications: skipped.
[INFO] Updating project files from SCM: skipped.
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/dbutils  svn --non-interactive info
[INFO] Working directory: /srv/gump/public/workspace/apache-commons/dbutils
[INFO] Storing buildNumber: ?? at timestamp: 1352205125186
[INFO] Executing: /bin/sh -c cd 
/srv/gump/public/workspace/apache-commons/dbutils  svn --non-interactive info
[INFO] Working directory: /srv/gump/public/workspace/apache-commons/dbutils
[INFO] Storing buildScmBranch: UNKNOWN_BRANCH
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/apache-commons/dbutils/src/main/resources
[INFO] Copying 2 resources to META-INF
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 29 source files to 
/srv/gump/public/workspace/apache-commons/dbutils/target/classes
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/srv/gump/public/workspace/apache-commons/dbutils/src/main/java/org/apache/commons/dbutils/DbUtils.java:[334,25]
 error: DriverProxy is not abstract and does not override abstract method 
getParentLogger() in Driver
[INFO] 1 error
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
/srv/gump/public/workspace/apache-commons/dbutils/src/main/java/org/apache/commons/dbutils/DbUtils.java:[334,25]
 error: DriverProxy is not abstract and does not override abstract method 
getParentLogger() in Driver

[INFO] 
[INFO] For more information, run Maven 

[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed

2012-11-06 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project commons-scxml-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 172 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-scxml-test :  Apache Commons


Full details are available at:

http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -WARNING- Overriding Maven settings: 
[/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml]
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/scxml/pom.xml
 -INFO- Project Reports in: 
/srv/gump/public/workspace/apache-commons/scxml/target/surefire-reports



The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/gump_work/build_apache-commons_commons-scxml-test.html
Work Name: build_apache-commons_commons-scxml-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 26 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -Dsimplelog.defaultlog=info 
--settings 
/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml test 
[Working Directory: /srv/gump/public/workspace/apache-commons/scxml]
M2_HOME: /opt/maven2
-
[INFO] SimpleSCXMLListener - /s2/s2.1/e1.2
[INFO] SimpleSCXMLListener - /s2/s2.1/e1.2
[INFO] SimpleSCXMLListener - /s2/s2.1
[INFO] SimpleSCXMLListener - /s2
[INFO] SimpleSCXMLListener - transition (event = s2.1.done, cond = null, from = 
/s2, to = /s3)
[INFO] SimpleSCXMLListener - /s3
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.211 sec
Running org.apache.commons.scxml.issues.Issue64Test
[INFO] SCXMLSemantics - null: Begin transition bug test ...
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SCXMLSemantics - null: somedata
[INFO] SCXMLSemantics - null: *somedata
[INFO] SimpleSCXMLListener - transition (event = show.bug, cond = null, from = 
/tranbug, to = /end)
[INFO] SimpleSCXMLListener - /end
[WARN] SCXMLParser - Ignoring element misplaced in namespace 
http://www.w3.org/2005/07/scxml; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:30:21
 and digester match scxml/datamodel/misplaced
[WARN] SCXMLParser - Ignoring element foo in namespace 
http://www.w3.org/2005/07/scxml; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:36:19
 and digester match scxml/state/onentry/foo
[WARN] SCXMLParser - Ignoring element bar in namespace 
http://my.foo.example/; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:37:22
 and digester match scxml/state/onentry/bar
[WARN] SCXMLParser - Ignoring element datamodel in namespace 
http://www.w3.org/2005/07/scxml; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:41:21
 and digester match scxml/state/transition/datamodel
[WARN] SCXMLParser - Ignoring element data in namespace 
http://www.w3.org/2005/07/scxml; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:42:41
 and digester match scxml/state/transition/datamodel/data
[WARN] SCXMLParser - Ignoring element baz in namespace 
http://my.foo.example/; at 
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:49:14
 and digester match scxml/baz
[INFO] SCXMLSemantics - null: Begin transition bug test ...
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SCXMLSemantics - null: null
[WARN] SimpleErrorReporter - EXPRESSION_ERROR (eval(''*' + dummy'):null): 
[INFO] SimpleSCXMLListener - transition (event = show.bug, cond = null, from = 
/tranbug, to = /end)
[INFO] SimpleSCXMLListener - /end
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.072 sec

Results :

Failed tests: 
  testCustomActionCallbacks(org.apache.commons.scxml.model.CustomActionTest)

Tests run: 229, Failures: 1, Errors: 0, Skipped: 0

[INFO] 
[ERROR] BUILD FAILURE
[INFO] 

Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-06 Thread Oliver Heger

Am 06.11.2012 09:57, schrieb Benedikt Ritter:

Hi Oliver,

thanks for the clarification. I see where you are going with the design.
What do you think of my proposal to implement the configuration interfaces
like the java collections framework? I can think of
Configurations.unmodifiableConfiguration(Configuration config).


Such a method already exists in ConfigurationUtils, however it is based 
on the dynamic proxy approach. This has the advantage that you only have 
a stripped-down interface in hand which does not allow you to call an 
unsupported method.


Oliver



Benedikt


2012/11/6 Oliver Heger oliver.he...@oliver-heger.de


Hi Benedikt,

Am 05.11.2012 21:04, schrieb Benedikt Ritter:

  2012/11/5 Benedikt Ritter benerit...@gmail.com


  Hi Oliver,



2012/11/5 ohe...@apache.org

Author: oheger


Date: Mon Nov  5 17:29:01 2012
New Revision: 1405889

URL: 
http://svn.apache.org/viewvc?**rev=1405889view=revhttp://svn.apache.org/viewvc?rev=1405889view=rev
Log:
Initial version of an immutable configuration interface.

Added:

commons/proper/configuration/**trunk/src/main/java/org/**
apache/commons/configuration/**ImmutableConfiguration.java
(with props)
Modified:

commons/proper/configuration/**trunk/src/main/java/org/**
apache/commons/configuration/**Configuration.java

Modified:
commons/proper/configuration/**trunk/src/main/java/org/**
apache/commons/configuration/**Configuration.java
URL:
http://svn.apache.org/viewvc/**commons/proper/configuration/**
trunk/src/main/java/org/**apache/commons/configuration/**
Configuration.java?rev=**1405889r1=1405888r2=1405889**view=diffhttp://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java?rev=1405889r1=1405888r2=1405889view=diff

==**==**
==
---
commons/proper/configuration/**trunk/src/main/java/org/**
apache/commons/configuration/**Configuration.java
(original)
+++
commons/proper/configuration/**trunk/src/main/java/org/**
apache/commons/configuration/**Configuration.java
Mon Nov  5 17:29:01 2012
@@ -17,11 +17,6 @@

   package org.apache.commons.**configuration;

-import java.math.BigDecimal;
-import java.math.BigInteger;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Properties;

   /**
* pThe main Configuration interface./p
@@ -54,7 +49,7 @@ import java.util.Properties;
* @author Commons Configuration team
* @version $Id$
*/
-public interface Configuration
+public interface Configuration extends ImmutableConfiguration



A Configuration IS_A ImmutableConfiguration sounds rather akward. The
JavaDoc of ImmutableConfiguration says The main interface for accessing
configuration data in a read-only fashion. Maybe ImmutableConfiguration
should be renamed to ReadOnlyConfiguration?

Regards,
Benedikt



Looking at the code base, there is no class that implements
ImmutableConfiguration directly and Configuration is the only interface
that extends ImmutableConfiguration. So maybe the two can be merged
together?



The ImmutableConfiguration interface has just been extracted from
Configuration in order to implement the feature of immutable
configurations. It contains all methods that do not manipulate the
configuration. A full-blown configuration extends this functionality by
additional update operations.

It is true that currently all concrete Configuration implementations
support the extended interface with update operations. However,
ImmutableConfiguration is implemented by dynamic proxies which provide an
immutable view on an arbitrary Configuration object.

Regarding the name: I am open for suggestions. ReadOnlyConfiguration,
ImmutableConfiguration, UnmodifiableConfiguration,... Maybe a native
speaker can comment?

Oliver




Benedikt





{

   /**
* Return a decorator Configuration containing every key from the
current
@@ -90,24 +85,6 @@ public interface Configuration
   Configuration subset(String prefix);

   /**
- * Check if the configuration is empty.
- *
- * @return {@code true} if the configuration contains no property,
- * {@code false} otherwise.
- */
-boolean isEmpty();
-
-/**
- * Check if the configuration contains the specified key.
- *
- * @param key the key whose presence in this configuration is to be
tested
- *
- * @return {@code true} if the configuration contains a value for
this
- * key, {@code false} otherwise
- */
-boolean containsKey(String key);
-
-/**
* Add a property to the configuration. If it already exists then
the value
* stated here will be added to the configuration entry. For
example, if
* the property:
@@ -147,452 +124,4 @@ public interface Configuration
* Remove all properties from the configuration.
*/
   void clear();
-
-/**
- * Gets a property from the configuration. This is the most basic

Re: svn commit: r1405889 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: Configuration.java ImmutableConfiguration.java

2012-11-06 Thread Benedikt Ritter
2012/11/6 Oliver Heger oliver.he...@oliver-heger.de

 Am 06.11.2012 09:57, schrieb Benedikt Ritter:

  Hi Oliver,

 thanks for the clarification. I see where you are going with the design.
 What do you think of my proposal to implement the configuration interfaces
 like the java collections framework? I can think of
 Configurations.**unmodifiableConfiguration(**Configuration config).


 Such a method already exists in ConfigurationUtils, however it is based on
 the dynamic proxy approach. This has the advantage that you only have a
 stripped-down interface in hand which does not allow you to call an
 unsupported method.


Hi Oliver,

okay, now I get why Configuration has to extend ImmutableConfiguration.

thanks!
Benedikt


 Oliver


 Benedikt


 2012/11/6 Oliver Heger oliver.he...@oliver-heger.de

  Hi Benedikt,

 Am 05.11.2012 21:04, schrieb Benedikt Ritter:

   2012/11/5 Benedikt Ritter benerit...@gmail.com


   Hi Oliver,



 2012/11/5 ohe...@apache.org

 Author: oheger

  Date: Mon Nov  5 17:29:01 2012
 New Revision: 1405889

 URL: 
 http://svn.apache.org/viewvc?rev=1405889view=revhttp://svn.apache.org/viewvc?**rev=1405889view=rev
 http://**svn.apache.org/viewvc?rev=**1405889view=revhttp://svn.apache.org/viewvc?rev=1405889view=rev
 

 Log:
 Initial version of an immutable configuration interface.

 Added:

 commons/proper/configuration/trunk/src/main/java/org/**
 apache/commons/configuration/ImmutableConfiguration.java
 (with props)
 Modified:

 commons/proper/configuration/trunk/src/main/java/org/**
 apache/commons/configuration/Configuration.java

 Modified:
 commons/proper/configuration/trunk/src/main/java/org/**
 apache/commons/configuration/Configuration.java
 URL:
 http://svn.apache.org/viewvc/commons/proper/configuration/http://svn.apache.org/viewvc/**commons/proper/configuration/**
 trunk/src/main/java/org/apache/commons/configuration/
 Configuration.java?rev=1405889r1=1405888r2=1405889**
 **view=diffhttp://svn.apache.**org/viewvc/commons/proper/**
 configuration/trunk/src/main/**java/org/apache/commons/**
 configuration/Configuration.**java?rev=1405889r1=1405888**
 r2=1405889view=diffhttp://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/Configuration.java?rev=1405889r1=1405888r2=1405889view=diff
 

 ==**==**
 ==
 ---
 commons/proper/configuration/trunk/src/main/java/org/**
 apache/commons/configuration/Configuration.java
 (original)
 +++
 commons/proper/configuration/trunk/src/main/java/org/**
 apache/commons/configuration/Configuration.java

 Mon Nov  5 17:29:01 2012
 @@ -17,11 +17,6 @@

package org.apache.commons.configuration;


 -import java.math.BigDecimal;
 -import java.math.BigInteger;
 -import java.util.Iterator;
 -import java.util.List;
 -import java.util.Properties;

/**
 * pThe main Configuration interface./p
 @@ -54,7 +49,7 @@ import java.util.Properties;
 * @author Commons Configuration team
 * @version $Id$
 */
 -public interface Configuration
 +public interface Configuration extends ImmutableConfiguration


  A Configuration IS_A ImmutableConfiguration sounds rather akward. The
 JavaDoc of ImmutableConfiguration says The main interface for
 accessing
 configuration data in a read-only fashion. Maybe
 ImmutableConfiguration
 should be renamed to ReadOnlyConfiguration?

 Regards,
 Benedikt


  Looking at the code base, there is no class that implements
 ImmutableConfiguration directly and Configuration is the only interface
 that extends ImmutableConfiguration. So maybe the two can be merged
 together?


 The ImmutableConfiguration interface has just been extracted from
 Configuration in order to implement the feature of immutable
 configurations. It contains all methods that do not manipulate the
 configuration. A full-blown configuration extends this functionality by
 additional update operations.

 It is true that currently all concrete Configuration implementations
 support the extended interface with update operations. However,
 ImmutableConfiguration is implemented by dynamic proxies which provide an
 immutable view on an arbitrary Configuration object.

 Regarding the name: I am open for suggestions. ReadOnlyConfiguration,
 ImmutableConfiguration, UnmodifiableConfiguration,... Maybe a native
 speaker can comment?

 Oliver



  Benedikt




 {

/**
 * Return a decorator Configuration containing every key from
 the
 current
 @@ -90,24 +85,6 @@ public interface Configuration
Configuration subset(String prefix);

/**
 - * Check if the configuration is empty.
 - *
 - * @return {@code true} if the configuration contains no
 property,
 - * {@code false} otherwise.
 - */
 -boolean isEmpty();
 -
 -/**
 - * Check if the configuration contains the specified key.
 - *
 - * 

[continuum] BUILD FAILURE: Apache Commons - Commons IO -

2012-11-06 Thread Continuum@vmbuild
  Build using Java 1.6
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 83
X-Continuum-Project-Name: Commons IO

Online report : 
http://vmbuild.apache.org/continuum/buildResult.action?buildId=25182projectId=83

Build statistics:
  State: Failed
  Previous State: Ok
  Started at: Tue 6 Nov 2012 17:20:17 +
  Finished at: Tue 6 Nov 2012 17:22:13 +
  Total time: 1m 56s
  Build Trigger: Schedule
  Build Number: 301
  Exit code: 1
  Building machine hostname: vmbuild
  Operating system : Linux(unknown)
  Java Home version : 
  java version 1.6.0_30
  Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
  Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

  Builder version :
  Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+)
  Java version: 1.6.0_30
  Java home: /usr/lib/jvm/jdk1.6.0_30/jre
  Default locale: en_US, platform encoding: ANSI_X3.4-1968
  OS name: linux version: 2.6.32-41-server arch: amd64 Family: 
unix


SCM Changes:

Changed: sebb @ Tue 6 Nov 2012 16:38:22 +
Comment: Javadoc
Files changed:
  /commons/proper/io/trunk/src/main/java/org/apache/commons/io/IOUtils.java ( 
1406212 )

Changed: sebb @ Tue 6 Nov 2012 17:02:39 +
Comment: IO-356 CharSequenceInputStream#reset() behaves incorrectly in case 
when buffer size is not dividable by data size
Add test case showing the issue
Files changed:
  
/commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java
 ( 1406222 )


Dependencies Changes:

No dependencies changed



Build Definition:

POM filename: pom.xml
Goals: clean deploy   
Arguments: --batch-mode -Pjava-1.6 -Dgpg.skip -Prelease
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: COMMONS_SCHEDULE
Profile Name: Maven 2.2.1
Description: Build using Java 1.6


Test Summary:

Tests: 984
Failures: 1
Errors: 0
Success Rate: 99
Total time: 66.7


Test Failures:


CharSequenceInputStreamTest
testIO_356 :
  bufferSize=10 dataSize=13
  bufferSize=10 dataSize=13: arrays first differed at element [0]; 
expected:65 but was:78
at 
org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:52)
at org.junit.Assert.internalArrayEquals(Assert.java:416)
at org.junit.Assert.assertArrayEquals(Assert.java:202)
at 
org.apache.commons.io.input.CharSequenceInputStreamTest.testIO_356(CharSequenceInputStreamTest.java:184)
at 
org.apache.commons.io.input.CharSequenceInputStreamTest.testIO_356(CharSequenceInputStreamTest.java:191)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
at 

[continuum] BUILD FAILURE: Apache Commons - Commons IO -

2012-11-06 Thread Continuum@vmbuild
  Build using Java 1.6
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 83
X-Continuum-Project-Name: Commons IO

Online report : 
http://vmbuild.apache.org/continuum/buildResult.action?buildId=25184projectId=83

Build statistics:
  State: Failed
  Previous State: Failed
  Started at: Tue 6 Nov 2012 18:23:22 +
  Finished at: Tue 6 Nov 2012 18:25:07 +
  Total time: 1m 44s
  Build Trigger: Schedule
  Build Number: 301
  Exit code: 1
  Building machine hostname: vmbuild
  Operating system : Linux(unknown)
  Java Home version : 
  java version 1.6.0_30
  Java(TM) SE Runtime Environment (build 1.6.0_30-b12)
  Java HotSpot(TM) 64-Bit Server VM (build 20.5-b03, mixed mode)

  Builder version :
  Apache Maven 2.2.1 (r801777; 2009-08-06 19:16:01+)
  Java version: 1.6.0_30
  Java home: /usr/lib/jvm/jdk1.6.0_30/jre
  Default locale: en_US, platform encoding: ANSI_X3.4-1968
  OS name: linux version: 2.6.32-41-server arch: amd64 Family: 
unix


SCM Changes:

Changed: sebb @ Tue 6 Nov 2012 17:31:16 +
Comment: IO-356 CharSequenceInputStream#reset() behaves incorrectly in case 
when buffer size is not dividable by data size
Extend the test case
Files changed:
  
/commons/proper/io/trunk/src/test/java/org/apache/commons/io/input/CharSequenceInputStreamTest.java
 ( 1406237 )


Dependencies Changes:

No dependencies changed



Build Definition:

POM filename: pom.xml
Goals: clean deploy   
Arguments: --batch-mode -Pjava-1.6 -Dgpg.skip -Prelease
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: COMMONS_SCHEDULE
Profile Name: Maven 2.2.1
Description: Build using Java 1.6


Test Summary:

Tests: 984
Failures: 1
Errors: 0
Success Rate: 99
Total time: 65.97398


Test Failures:


CharSequenceInputStreamTest
testIO_356 :
  bufferSize=10 dataSize=13
  bufferSize=10 dataSize=13: arrays first differed at element [0]; 
expected:65 but was:78
at 
org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:52)
at org.junit.Assert.internalArrayEquals(Assert.java:416)
at org.junit.Assert.assertArrayEquals(Assert.java:202)
at 
org.apache.commons.io.input.CharSequenceInputStreamTest.testIO_356(CharSequenceInputStreamTest.java:184)
at 
org.apache.commons.io.input.CharSequenceInputStreamTest.testIO_356(CharSequenceInputStreamTest.java:191)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
at 

Re: [lang] Time for 3.2?

2012-11-06 Thread Gary Gregory
On Tue, Nov 6, 2012 at 3:25 AM, Duncan Jones dun...@wortharead.com wrote:

 On 6 November 2012 02:02, Gary Gregory garydgreg...@gmail.com wrote:
  Hi All:
 
  I just committed a fix for [lang] and realized it's been a YEAR since
 3.1!
  Wow, time flies.
 
  Are we ready for a release?
 
  Does anyone have anything they'd like to contribute?
 
  Gary

 If anyone has the time to review it, I'd happily see the
 DifferenceBuilder classes included in the release
 (https://issues.apache.org/jira/browse/LANG-637).


I've not looked at this one. I'd prefer releasing soon, and again later
with possibly this new feature.


 I've also submitted a patch for
 https://issues.apache.org/jira/browse/LANG-757, which handles HTML
 escapes without semi-colons. Not sure if anyone has had a chance to
 review that yet.


I think Sebb started a discussion on this one.

Gary


 Duncan

 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org




-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory