Romain Manni-Bucau wrote:
Hi
I have two main point to discuss regarding the logging:
1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a
if (boolean) complexity and not go through the logging framework which can
imply several layers (filter, appender, handler,
Online report :
https://continuum-ci.apache.org/continuum/buildResult.action?buildId=31793projectId=65
Build statistics:
State: Failed
Previous State: Failed
Started at: Mon 2 Jun 2014 06:20:06 +
Finished at: Mon 2 Jun 2014 06:21:38 +
Total time: 1m 32s
Build Trigger:
Well because [logging] was longly broken in a not flat classloading
environment (didnt check last release but almost all logging facade got
this issue at a point) and because almost nothing in TomEE stacks uses it,
it is not as integrated as log4j, slf4j or JUL (which is the default). Main
issue I
On Mon, Jun 2, 2014 at 1:20 AM, Romain Manni-Bucau rmannibu...@gmail.com
wrote:
Well ATM log4j2 doesnt work well, didnt get time to dig into it but tested
last week for another topic and lost all my shutdown messages (guess
cleanup is called too early).
Please to check out trunk and give us
@Gary: same with trunk. Here what I do (we can move it to another thread
since that's 100% log4j2 related): unzip
apache-tomee-1.7.0-SNAPSHOT-webprofile.zip cd
apache-tomee-webprofile-1.7.0-SNAPSHOT/ rm conf/logging.properties
echo 'openejb.log.factory=log4j'conf/system.properties cp
Could you please create a log4j 2 Jira for this? There might be one already
though. I have seen discussions about this area on the log4j dev ML.
Gary
div Original message /divdivFrom: Romain Manni-Bucau
rmannibu...@gmail.com /divdivDate:06/02/2014 08:31 (GMT-05:00)
done: https://issues.apache.org/jira/browse/LOG4J2-658
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-06-02 14:51 GMT+02:00 Gary Gregory garydgreg...@gmail.com:
On 6/1/14, 12:26 PM, Romain Manni-Bucau wrote:
Hi
I have two main point to discuss regarding the logging:
1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if
(boolean) complexity and not go through the logging framework which can
imply several layers (filter,
On 6/1/14, 6:01 PM, Bernd Eckenfels wrote:
Am Sun, 1 Jun 2014 23:43:10 +0100
schrieb sebb seb...@gmail.com:
On 1 June 2014 20:19, Romain Manni-Bucau rmannibu...@gmail.com
wrote:
well it is for sure thread safe. Not sure I get why final and synch
would be mandatory in this particular case
actually these logs are really debug log not intended to be activated in
prod excepted if there is a big issue (@thomas: if you can confirm it would
be great).
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
First about immutabilit thread safety etc: we can use final if it ends the
topic, it was not cause first version was a field and not a constant and
serializable but now it can be final.
Then about isDebugEnabled: overhead is quite important compared to a simple
boolean test. Most of the time it
On 2 June 2014 02:01, Bernd Eckenfels e...@zusammenkunft.net wrote:
Am Sun, 1 Jun 2014 23:43:10 +0100
schrieb sebb seb...@gmail.com:
On 1 June 2014 20:19, Romain Manni-Bucau rmannibu...@gmail.com
wrote:
well it is for sure thread safe. Not sure I get why final and synch
would be mandatory
On 2 June 2014 16:11, Romain Manni-Bucau rmannibu...@gmail.com wrote:
First about immutabilit thread safety etc: we can use final if it ends the
topic, it was not cause first version was a field and not a constant and
serializable but now it can be final.
Then about isDebugEnabled: overhead
Ideally needs to be uploaded to dist/ area as well.
On 2 June 2014 06:56, ebo...@apache.org wrote:
Author: ebourg
Date: Mon Jun 2 05:56:51 2014
New Revision: 1599092
URL: http://svn.apache.org/r1599092
Log:
Fixed a typo in the release notes
Modified:
On 02.06.14 17:02, Romain Manni-Bucau wrote:
actually these logs are really debug log not intended to be activated in
prod excepted if there is a big issue (@thomas: if you can confirm it would
be great).
Yes, logging is for debugging purposes mostly. But if you remove them:
how would you do
On 01.06.14 21:26, Romain Manni-Bucau wrote:
Hi
I have two main point to discuss regarding the logging:
1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if
(boolean) complexity and not go through the logging framework which can
imply several layers (filter, appender,
Am 02.06.2014 19:16, schrieb sebb:
Ideally needs to be uploaded to dist/ area as well.
Done
Oliver
On 2 June 2014 06:56, ebo...@apache.org wrote:
Author: ebourg
Date: Mon Jun 2 05:56:51 2014
New Revision: 1599092
URL: http://svn.apache.org/r1599092
Log:
Fixed a typo in the release
@Thomas: never said [logging] is bad and JUL is better. Sorry if I was not
clear. All logging facades don't handle very well EE case for several good
or bad reasons. [logging] is as good as slf4j for it (even better out of
the box IIRC). JUL is far to be perfect but is in the JVM (so no
18 matches
Mail list logo
