Re: [math] javadoc unbalanced code

2012-03-09 Thread Gilles Sadowski
On Fri, Mar 09, 2012 at 11:50:15AM +0100, Benedikt Ritter wrote: Thanks for the patch Dennis! Feel free create a JIRA ticket [1] for this issue, where you can attach your patch (and maybe more ;). One little suggestion for improvement: According to [2] {@code } should be used in instead of

Re: [math] LaguerreSolver.ComplexSolver is private; functionality lost in 3.0

2012-03-11 Thread Gilles Sadowski
On Sat, Mar 10, 2012 at 07:15:14PM -0600, Lance Finney wrote: We used LaguerreSolver.solveAll() in version 2.1, but we never upgraded to 2.2. As such, we didn't notice that it was deprecated in that release. Now that 3.0 is out, we want to upgrade, but that method has been completely

Re: [MATH] Does website really need Javadoc for versions prior to 2.2?

2012-03-13 Thread Gilles Sadowski
On Mon, Mar 12, 2012 at 08:22:27PM +0100, Luc Maisonobe wrote: Le 12/03/2012 16:50, sebb a écrit : In addition to Javadoc for 3.0 and 2.2, the website still offers the following: Javadoc (2.1 release) Javadoc (2.0 release) Javadoc (1.2 release) Javadoc (1.1 release) Javadoc (1.0

Re: [ALL] Commons Parent reports

2012-03-13 Thread Gilles Sadowski
On Tue, Mar 13, 2012 at 01:39:40PM +0100, Torsten Curdt wrote: I find checkstyle to be not very useful. It's more hassle than it's worth. It's like pointing fingers instead of helping. If you want to foster a certain code style provide eclipse and intellij formatter settings instead - that's

Re: [ALL] Commons Parent reports

2012-03-13 Thread Gilles Sadowski
On Tue, Mar 13, 2012 at 02:27:32PM +0100, Torsten Curdt wrote: CheckStyle reports should be checked regularly. Only doing so just before a release indeed leads to a lot of tedious work, because coders did not respect the basic, agreed on, style. I guess we are disagreeing here. I didn't

Re: [ALL] Commons Parent reports

2012-03-13 Thread Gilles Sadowski
On Tue, Mar 13, 2012 at 03:08:01PM +0100, Christian Grobmeier wrote: +1 on the mentioned plugins, except: -1 on checkstyle. I dont see a benefit in making checkstyle default. If somebody wants to use that tool, he can. What checkstyle-style would be the default? Sun conventions or maven

Re: [ALL] Commons Parent reports

2012-03-13 Thread Gilles Sadowski
Hi. [...] The tools are there, but you have to tell people that they _must_ use them. Commons has already enough rules and process. As long as the releases are have clean code I wouldn't be too anal about the commits in between. I think that the main disagreement is here. Source code

Re: [ALL] Commons Parent reports

2012-03-13 Thread Gilles Sadowski
Hi. [...] The tools are there, but you have to tell people that they _must_ use them. Commons has already enough rules and process. As long as the releases are have clean code I wouldn't be too anal about the commits in between. I think that the main disagreement is

Re: [ALL] Commons Parent reports

2012-03-13 Thread Gilles Sadowski
On Tue, Mar 13, 2012 at 05:23:06PM +0100, Emmanuel Bourg wrote: I'd like to see less reports by default. Most of them are only useful for checking a release candidate by the commons devs, otherwise it just clutters the sites with useless information for a general usage. The most important

Re: [ALL] Commons Parent reports

2012-03-14 Thread Gilles Sadowski
On Tue, Mar 13, 2012 at 01:52:32PM -0400, Gary Gregory wrote: On Mar 13, 2012, at 12:40, Gilles Sadowski gil...@harfang.homelinux.org wrote: [...] The tools are there, but you have to tell people that they _must_ use them. Commons has already enough rules and process. As long

Re: [ALL] Commons Parent reports

2012-03-14 Thread Gilles Sadowski
On Tue, Mar 13, 2012 at 01:59:25PM -0400, Gary Gregory wrote: On Mar 13, 2012, at 12:40, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hi. [...] The tools are there, but you have to tell people that they _must_ use them. Commons has already enough rules and process

Re: [ALL] Commons Parent reports

2012-03-14 Thread Gilles Sadowski
On Tue, Mar 13, 2012 at 06:37:21PM +0100, Emmanuel Bourg wrote: Le 13/03/2012 17:52, Gilles Sadowski a écrit : What about the Useful for the developer category? They are useful at release time only, then they become quickly outdated as the code evolves after the release. If I want

Re: [math] Commons-Math 3.1?

2012-03-18 Thread Gilles Sadowski
On Sun, Mar 18, 2012 at 10:35:51AM +0100, Sébastien Brisard wrote: Dear all, We should also close the Jira issues that have been solved as of 3.0. For newcomers, our policy on JIRA issues is that we mark them as resolved when the fix is available in the subversion repository, and we

Re: [math] linear regression output in human readable format.

2012-03-18 Thread Gilles Sadowski
Hi. I was looking forward to use apache math, but I have found a serious limitation in apache-math2x and apache-math3x ; which have stopped me from using apache math, according to me it is very important aspect and should have been there, or I am missing something. When we do linear

[Math] Release mini-howto

2012-03-18 Thread Gilles Sadowski
Hi. In the course of the latest release process, I've taken notes about what to do to make things work for a release manager newbie. Thus, there is a small text file with the step-by-step description, and two minimal maven config files. I'd like to create new directories in trunk to home these

Re: [Math] Release mini-howto

2012-03-18 Thread Gilles Sadowski
On Sun, Mar 18, 2012 at 09:36:30PM +0100, Christian Grobmeier wrote: On Sun, Mar 18, 2012 at 8:42 PM, Gary Gregory garydgreg...@gmail.com wrote: That's what the wiki is for no? You could make a page for [math] like http://wiki.apache.org/commons/UsingNexus I've tried to use that one, and

Re: [Math] Release mini-howto

2012-03-19 Thread Gilles Sadowski
Hello. Le 19/03/2012 01:01, Christian Grobmeier a écrit : On Mon, Mar 19, 2012 at 12:25 AM, Gilles Sadowski gil...@harfang.homelinux.org wrote: Not to forget the grandfather of release guides: http://commons.apache.org/releases/release.html I've just had a brief look at that one; I

Re: [continuum] BUILD FAILURE: Apache Commons - Commons IO - Default Maven 2 Build Definition (Java 1.5)

2012-03-20 Thread Gilles Sadowski
On Tue, Mar 20, 2012 at 10:47:52AM +, sebb wrote: On 20 March 2012 07:40, Jörg Schaible joerg.schai...@scalaris.com wrote: Gary Gregory wrote: What is this all about? [ERROR] BUILD ERROR [INFO] [ [INFO]

Re: [math]:Complex types

2012-03-26 Thread Gilles Sadowski
Hello. Interesting article about value types in the JVM with relevance to better support for Complex numbers (something I've long wished for) https://blogs.oracle.com/jrose/entry/value_types_in_the_vm Perhaps there is a role for the Commons Math project in item 2 of his section More

Re: [math] Improvement: Interpreter for mathematical expressions

2012-03-27 Thread Gilles Sadowski
Hello. it would be nice to have an interpreter for mathematical expressions so that functions may be defined at runtime. Example for f(x): ExpInter ei = new ExpInter(); ei.setFunction(ln(3*sin(2*x)+3)); // Plot the function: for (double x=0.0;x3.0;x+=0.1) { y = ei(x);

Re: [math] Improvement: Interpreter for mathematical expressions

2012-03-27 Thread Gilles Sadowski
On Tue, Mar 27, 2012 at 12:53:25PM +0200, Detlef Günther wrote: Hi Thomas, congrace may be used by writing a wrapper Expression to UnivarteFunction: import org.apache.commons.math3.analysis.UnivariateFunction; import de.congrace.exp4j.Calculable; import

Re: Commons-Math release schedule

2012-03-27 Thread Gilles Sadowski
Hello. [...] But one question I would like to ask is what is the process for arranging for a new release of Commons-Math. I ask because we have 6-month release schedule for our mathematical and utility library, which makes use of Commons Math, and we would like to see whether we can

Re: Commons-Math release schedule

2012-03-27 Thread Gilles Sadowski
Hi. I am -1 to publishing any sort of release schedule to which we would be held accountable. I was speaking for Commons Math. IMHO, it is a disservice to the project to have releases more than 12 months apart, as it has just been the case. This gives the feeling that the code is stable and in

Re: Commons-Math release schedule

2012-03-28 Thread Gilles Sadowski
Hi Luc. I have to agree with James here. However, if the mysterious team-who-wishes-to-contribute is dead set on 6 month release cycles, it is certainly within their power to make sure 4.5 months ahead of time that every open JIRA issue has a patch attached, and to nag the team

Re: [math] Release notes for 3.1?

2012-03-28 Thread Gilles Sadowski
Hi. in preparation for 3.1, should we start the release notes anew? Yes. I created the new release XML tag at the top of the file (revision 1306242). Gilles - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

[Math] changes HTML report

2012-03-28 Thread Gilles Sadowski
Hello. [I think that this had already been reported earlier by Thomas.] The HTML page generated from the changes.xml file does not seem to be produced anymore (it used to be in target/site as a result from executing mvn site). This probably happened following the move of the file from site/xdoc

[Math] On-demand cobertura report

2012-03-28 Thread Gilles Sadowski
Hello. Please disable the default running of cobertura in mvn site. It is unbearably slow: e.g. on my machine, FastMathTest takes 1,544 seconds (that's a comma there; i.e. ~25 minutes!). If on-demand disable/enable switches are not (yet) available from maven's command-line options, could we have

Re: [Math] On-demand cobertura report

2012-03-28 Thread Gilles Sadowski
Hello. Please disable the default running of cobertura in mvn site. It is unbearably slow: e.g. on my machine, FastMathTest takes 1,544 seconds (that's a comma there; i.e. ~25 minutes!). If on-demand disable/enable switches are not (yet) available from maven's command-line options,

Re: [math] Release notes for 3.1?

2012-03-28 Thread Gilles Sadowski
Hello Sébastien. Yes. I created the new release XML tag at the top of the file (revision 1306242). Gilles I must have missed something. I don't see which file you are referring to. As for me, I was referring to the file called RELEASE-NOTES.txt, but maybe this file is

Re: [math] Gamma Distribution Algorithm

2012-03-29 Thread Gilles Sadowski
Hi. Have you looked at the nextGamma in org.apache.commons.math.random? It should be much faster than using the inversion method. Whenever there is a specific (thus faster) implementation (in RandomDataImpl), it should be called from the sample method of the corresponding distribution class.

Re: [math] Refactoring the matrix and vector interfaces

2012-03-29 Thread Gilles Sadowski
Hello. as agreed, I've started a JIRA ticket on this long-standing issue (see MATH-765). This ticket is really meant as a summary of the discussions which should take place on the mailing list, so please refrain from adding comments (unless absolutely necessary). Children tickets will be

Re: [math] Refactoring the matrix and vector interfaces

2012-03-30 Thread Gilles Sadowski
Hello. Although it is nice to work on a new design, I now have a problem with the issue as a whole: Where are the people (and applications) that need this? At least four persons made suggestions/comments on what was maybe wrong or could be improved, but they either are not active

[Math] Broken links in userguide

2012-04-11 Thread Gilles Sadowski
Hi. There were some wrong links in the user guide in file analysis.xml (fixed in r1324680). What is the policy to update the site, i.e. to post a corrected version of the user guide? Thanks, Gilles P.S. Thanks for the settings.xml snippet that allows to skip things in the maven run!

[Math] Question about AbstractLeastSquaresOptimizer code

2012-04-18 Thread Gilles Sadowski
Hi. In AbstractLeastSquaresOptimizer (package optimization.general), the method guessParametersErrors is defined as: ---CUT--- public double[] guessParametersErrors() { if (rows = cols) { throw new NumberIsTooSmallException(LocalizedFormats.NO_DEGREES_OF_FREEDOM,

Re: [math] Introduction

2012-04-20 Thread Gilles Sadowski
Hi. I have been using commons-math for approximately six months, and also been a reading member of the dev mailing list for some time. My background is from math, but I have been doing java development since I have started working for about a year ago. I really like the library, even though

Re: [Math] Question about AbstractLeastSquaresOptimizer code

2012-04-23 Thread Gilles Sadowski
On Wed, Apr 18, 2012 at 07:23:04PM +0200, Luc Maisonobe wrote: Le 18/04/2012 14:21, Gilles Sadowski a écrit : Hi. In AbstractLeastSquaresOptimizer (package optimization.general), the method guessParametersErrors is defined as: ---CUT--- public double[] guessParametersErrors

[Math] maven: Problem with clirr

2012-04-24 Thread Gilles Sadowski
Hi. Clirr now fails the build on error: ---CUT--- [ERROR] Unable to find information in class org.apache.commons.math3.linear.SymmLQ referring back to nested class org.apache.commons.math3.linear.SymmLQ$SymmLQEvent [ERROR] Unable to find information in class

[Math] Javadoc warning

2012-04-24 Thread Gilles Sadowski
Referring to this change in Precision.java: ---CUT--- r1328492 | luc | 2012-04-20 22:15:11 +0200 (Fri, 20 Apr 2012) | 6 lines Added a workaround for an OpenJDK issue on sparc solaris. The compiler has issues with very small double constants, despite they are perfectly legal Java and

Re: [Math] maven: Problem with clirr

2012-04-25 Thread Gilles Sadowski
On Wed, Apr 25, 2012 at 12:53:46AM +0100, sebb wrote: On 24 April 2012 22:19, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hi. Clirr now fails the build on error: ---CUT--- [ERROR] Unable to find information in class org.apache.commons.math3.linear.SymmLQ referring back

Re: [Math] maven: Problem with clirr

2012-04-25 Thread Gilles Sadowski
Hi. Clirr now fails the build on error: ---CUT--- [ERROR] Unable to find information in class [org.apache.commons.math3.linear.SymmLQ referring back to nested class [org.apache.commons.math3.linear.SymmLQ$SymmLQEvent ERROR] Unable to [find information in class

Re: [Math] Question about AbstractLeastSquaresOptimizer code

2012-04-25 Thread Gilles Sadowski
Hi. looking at various references, it seems that the definition of the error as errors[i] = FastMath.sqrt(covar[i][i]) * c; or errors[i] = FastMath.sqrt(covar[i][i]); is a matter of convention. I'm no statistician, but I gathered that the first expression is what is called Asymptotic

Re: [Math] maven: Problem with clirr

2012-04-25 Thread Gilles Sadowski
Hi. Does anyone have an idea of what can cause this? Have you tried Maven 221? No. Have you tried mvn clean clirr:clirr ? That was the trick. Thanks. Sorry; I still have a hard time understanding when the clean becomes a necessary step! In the meantime, I'd be glad to be able

Re: [Math] maven: Problem with clirr

2012-04-25 Thread Gilles Sadowski
On Wed, Apr 25, 2012 at 04:00:30PM +0200, Sébastien Brisard wrote: Have you tried Maven 221? I'm using maven 2.2.1, and no such error occurs! I do get a report, with a lot of complaints regarding the geometry package. Have you tried mvn clean clirr:clirr ? In the meantime, I'd

Re: [Math] Question about AbstractLeastSquaresOptimizer code

2012-04-25 Thread Gilles Sadowski
On Wed, Apr 25, 2012 at 03:46:58PM +0200, Sébastien Brisard wrote: Hi Gillles, Can we then agree that the current naming is not really clear? Since we are not allowed to readily remove this method, the best solution would be to update the Javadoc to make it clear what is done there, i.e.

Re: [Math] Question about AbstractLeastSquaresOptimizer code

2012-04-26 Thread Gilles Sadowski
On Wed, Apr 25, 2012 at 05:56:32PM +0200, Sébastien Brisard wrote: 2012/4/25 Gilles Sadowski gil...@harfang.homelinux.org: On Wed, Apr 25, 2012 at 03:46:58PM +0200, Sébastien Brisard wrote: Hi Gillles, Can we then agree that the current naming is not really clear? Since we

Re: [Math] maven: Problem with clirr

2012-04-26 Thread Gilles Sadowski
Hi. [...] Here the stack trace from maven output: ---CUT--- [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.0:site (default-site) on project commons-math3: Execution default-site of goal org.apache.maven.plugins:maven-site-plugin:3.0:site failed: 780 -

[Math] Nightly builds disabled?

2012-04-27 Thread Gilles Sadowski
Hi. I've just noticed that https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-math/ does not contain the 3.1 snapshot. Are they somewhere else? Or is the feature disabled? If so, how to have it on again? Thanks, Gilles

Re: [Math] Nightly builds disabled?

2012-04-27 Thread Gilles Sadowski
On Fri, Apr 27, 2012 at 03:52:05PM +0100, sebb wrote: On 27 April 2012 15:42, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hi. I've just noticed that  https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-math/ does not contain the 3.1 snapshot

Re: [math] Deprecating

2012-05-03 Thread Gilles Sadowski
Hello. in this thread, http://mail-archives.apache.org/mod_mbox/commons-dev/201204.mbox/%3C20120418122114.GB32074%40dusk.harfang.homelinux.org%3E I suggested that we deprecate guessParametersErrors() and replace it with getParametersStandardDeviation(), since the implemented formula seems to

Re: [math] Deprecating guessParametersErrors

2012-05-04 Thread Gilles Sadowski
Hello. I'm obviously missing something in my litterature review. I did a new MC simulation, with a much smaller number of observation points (namely 3, to fit a straight line!!!). It turns out that the formula you are advocating for is the best estimate of the standard deviation of the

Re: [math] Deprecating guessParametersErrors

2012-05-04 Thread Gilles Sadowski
[...] For clarity's sake (design-wise), I propose to remove the guessParametersErrors method, and add a getSigma (as syntactic sugar). I'm OK with that. As a first step, we deprecate it, and stipulate in the javadoc that getSigma() should be used instead. We emphasize that both methods

Re: [Math] Serializable (again)

2012-05-08 Thread Gilles Sadowski
Hello. There is another complaint about some class not being Serializable:   https://issues.apache.org/jira/browse/MATH-787 I don't want to argue all over again. We should probably add a section in the user guide stating the policy with regards to this issue. The problem is that

Re: [Math] Serializable (again)

2012-05-08 Thread Gilles Sadowski
On Tue, May 08, 2012 at 12:51:28PM +0200, Thomas Neidhart wrote: On Tue, May 8, 2012 at 12:24 PM, Gilles Sadowski gil...@harfang.homelinux.org wrote: I am in favor of this second option: add Serializable were needed upon request. +1 +1 In this case, the request seems

Re: [Math] Serializable (again)

2012-05-08 Thread Gilles Sadowski
On Tue, May 08, 2012 at 01:22:38PM +0200, Sébastien Brisard wrote: Hello, 2012/5/8 Thomas Neidhart thomas.neidh...@gmail.com: On Tue, May 8, 2012 at 12:24 PM, Gilles Sadowski gil...@harfang.homelinux.org wrote: I am in favor of this second option: add Serializable were needed upon

Re: [Math] Serializable (again)

2012-05-08 Thread Gilles Sadowski
On Tue, May 08, 2012 at 08:43:53PM +0200, Thomas Neidhart wrote: On 05/08/2012 01:44 PM, Gilles Sadowski wrote: Sorry to correct you: It was removed because it was not implemented properly. As a matter of principle, it is better to not support something rather to give a false sense

Re: [Math] Serializable (again)

2012-05-08 Thread Gilles Sadowski
On Tue, May 08, 2012 at 02:55:47PM -0400, James Carman wrote: I don't know that you want to get into supporting long-term serialization support. I would say CM should support transient serialization (if that makes any sense), such as marshalling/unmarshalling. If you guarantee long-term

Re: [math] Exposing the Lanczos approximation in o.a.c.m3.special.Gamma?

2012-05-08 Thread Gilles Sadowski
I've spent quite some time on MATH-753 [1], and I think I now have a satisfactory solution. The problem was to overcome the overflows which arise when computing the density of the Gamma distribution for large values of the argument and/or the scale parameter. As I initially feared,

Re: [math] Exposing the Lanczos approximation in o.a.c.m3.special.Gamma?

2012-05-09 Thread Gilles Sadowski
Hello. the patch for the proposed modification has been attached to the MATH-753 ticket. Thanks for your comments! What I have seen in the patch, you remove duplicated code by using the already existing lanczos function, and create an additional function for the constant. I guess just

Re: [math] Exposing the Lanczos approximation in o.a.c.m3.special.Gamma?

2012-05-09 Thread Gilles Sadowski
the patch for the proposed modification has been attached to the MATH-753 ticket. Thanks for your comments! What I have seen in the patch, you remove duplicated code by using the already existing lanczos function, and create an additional function for the constant. In fact, I've

Re: [Math] Serializable (again)

2012-05-09 Thread Gilles Sadowski
On Wed, May 09, 2012 at 07:03:58AM -0400, James Carman wrote: On Wed, May 9, 2012 at 3:03 AM, Luc Maisonobe luc.maison...@free.fr wrote: Is there such a thing as short-term serialization? Yes, of course, and this what many people need. This is what James called marshalling/unmarshalling.

Re: [Math] Serializable (again)

2012-05-12 Thread Gilles Sadowski
[...] I have tried to set up a clean serialization process for the classes that needs it, starting with the PointValuePair class as requested in [MATH-787]. It turns out several previous choices completely prevent this to be done. At the beginning, we had a PointCostPair

Re: [Math] Serializable (again)

2012-05-13 Thread Gilles Sadowski
[...] Hmm, a PointValuePair is not a Pair... That's an original view. :-) ^^^ I am not sure whether this was an attempt at humor or not. See . My point is not that PointValuePair is not a pair (without

Re: [Math] Serializable (again)

2012-05-15 Thread Gilles Sadowski
Hello. as I am also interested in short term serialization just for moving objects between a distributed virtual machines and not in long term serialization, I would support the discussion up to now. To express our intentions we could make an interface, say public interface

Re: [Math] Serializable (again)

2012-05-15 Thread Gilles Sadowski
On Tue, May 15, 2012 at 12:50:15PM +0200, Axel wrote: Hi In my opinion for more advanced uses it makes sense to use tools like Googles protocol-buffers for serialization: http://developers.google.com/protocol-buffers/docs/javatutorial This is indeed one possibility (which by the way shows

Re: [Math] Serializable (again)

2012-05-22 Thread Gilles Sadowski
On Sun, May 20, 2012 at 09:40:25PM +0200, Heinz Kredel wrote: Am Dienstag 15 Mai 2012, 23:25:46 schrieb Gilles Sadowski: Hello. as I am also interested in short term serialization just for moving objects between a distributed virtual machines and not in long term serialization, I

Re: svn commit: r1343163 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/ test/java/org/apache/commons/math3/linear/

2012-05-28 Thread Gilles Sadowski
Hi Sébastien. [...] Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/RealVector.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/RealVector.java?rev=1343163r1=1343162r2=1343163view=diff

Re: svn commit: r1343163 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/ test/java/org/apache/commons/math3/linear/

2012-05-28 Thread Gilles Sadowski
Hi. [...] +    protected void checkIndices(final int start, final int end) { +        final int dim = getDimension(); +        if ((start 0) || (start = dim)) { +            throw new OutOfRangeException(LocalizedFormats.INDEX, +                                          

Re: svn commit: r1343163 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/ test/java/org/apache/commons/math3/linear/

2012-05-28 Thread Gilles Sadowski
Hello. Why do you call valueOf? I have to say I do not like implicit conversions, that's why I tend to always use Integer.valueOf and the likes. Why? However, if you think that it leads to less readable code, I'm OK with your way of seeing things. Good! ;-) Gilles

Re: svn commit: r1343293 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/RealVector.java

2012-05-28 Thread Gilles Sadowski
On Mon, May 28, 2012 at 04:58:33PM +0100, sebb wrote: On 28 May 2012 16:39, celes...@apache.org wrote: Author: celestin Date: Mon May 28 15:39:57 2012 New Revision: 1343293 URL: http://svn.apache.org/viewvc?rev=1343293view=rev Log: Removed explicit conversion from int to Integer.

Re: svn commit: r1343293 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/RealVector.java

2012-05-28 Thread Gilles Sadowski
That's true we didn't. However (see my last message), this is really of little consequence, and I didn't really want to get into a new to-serialize-or-not-to-serialize-that-s-the-question endless debate. I was the one who initially defended explicit conversion as opposed to autoboxing, so

Re: svn commit: r1343163 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/ test/java/org/apache/commons/math3/linear/

2012-05-28 Thread Gilles Sadowski
Hi. That was the initial reason why I moved from C++ to Java ten years ago: too many things happened behind my back. Arguably a lot more happens so with Java! Gilles [...] - To unsubscribe, e-mail:

Re: svn commit: r1343616 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/geometry/partitioning/utilities/OrderedTuple.java

2012-05-29 Thread Gilles Sadowski
Hi. [...] --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/geometry/partitioning/utilities/OrderedTuple.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/geometry/partitioning/utilities/OrderedTuple.java Tue May 29 09:14:37

[Math] About MATH-798

2012-06-01 Thread Gilles Sadowski
Hi. I think that PolynomialFitter class deserves to be deleted. It looks like a bad use of inheritance because it cannot prevent bad usage of its base class's fit methods (where a user can provide a parametric function argument that is not a polynomial). Issue 798 could be solved by providing

Re: [Math] About MATH-798

2012-06-01 Thread Gilles Sadowski
Hello. Do you know the rationale behind the (very) small values for DEFAULT_RELATIVE_THRESHOLD (set to 100 * Precision.EPSILON) DEFAULT_ABSOLUTE_THRESHOLD (set to 100 * Precision.SAFE_MIN) in AbstractConvergenceChecker? [I created this class as part of a refactoring, but the values were carried

[Math] HarmonicFitter and GaussianFitter

2012-06-08 Thread Gilles Sadowski
Hi. I'm a bit annoyed that HarmonicFitter and GaussianFitter suffer from the same design flaw as PolynomialFitter, namely that it is possible to call the non-overridden fit with an argument that is not of the right type (i.e. HarmonicOscillator.Parametric and Gaussian.Parametric, respectively).

Re: [Math] HarmonicFitter and GaussianFitter

2012-06-09 Thread Gilles Sadowski
Hello. [...] Then, we could keep PolynomialFitter. OK for this change? OK. Luc Sounds good to me! Could you please have a look at PolynomialFitter? I'm not sure that it is useful to select the degree of the polynomial at construction, as it is currently done. Is there a

Re: svn commit: r1348721 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/OpenMapRealVector.java test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

2012-06-11 Thread Gilles Sadowski
Hello. Date: Mon Jun 11 05:52:16 2012 New Revision: 1348721 URL: http://svn.apache.org/viewvc?rev=1348721view=rev Log: MATH-803: - modified OpenMapRealVector.ebeMultiply() and ebeDivide() to handle special cases 0d * NaN, 0d * Infinity, 0d / 0d and 0d / NaN. - added implementation

Re: svn commit: r1348721 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/OpenMapRealVector.java test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

2012-06-11 Thread Gilles Sadowski
Hello Sébastien. +        /* +         * MATH-803: it is not sufficient to loop through non zero entries of +         * this only. Indeed, if this[i] = 0d and v[i] = 0d, then +         * this[i] / v[i] = NaN, and not 0d. +         */ +        final int n = getDimension(); +      

Re: svn commit: r1348721 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/OpenMapRealVector.java test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

2012-06-11 Thread Gilles Sadowski
Hi. +         * MATH-803: it is not sufficient to loop through non zero entries of +         * this only. Indeed, if this[i] = 0d and v[i] = 0d, then +         * this[i] / v[i] = NaN, and not 0d. +         */ +        final int n = getDimension(); +        for (int i = 0; i

Re: svn commit: r1348721 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/OpenMapRealVector.java test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

2012-06-12 Thread Gilles Sadowski
Hello. [...] I agree. This does not solve the whole issue, however, because if the default entry is zero, its sign is lost, and {finite value} / {zero} is of undetermined sign. Any idea regarding this point? I guess that we could also keep a flag for the sign. Do you mean

Re: svn commit: r1348721 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/OpenMapRealVector.java test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

2012-06-12 Thread Gilles Sadowski
On Tue, Jun 12, 2012 at 01:14:40PM +0200, Sébastien Brisard wrote: 2012/6/12 Gilles Sadowski gil...@harfang.homelinux.org: Hello. [...] I agree. This does not solve the whole issue, however, because if the default entry is zero, its sign is lost, and {finite value} / {zero

[Math] How to use a class from the test source tree?

2012-06-12 Thread Gilles Sadowski
Hi. Is there a way for an application to depend on the classes defined in the test subtree of the code repository? Best, Gilles - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [Math] How to use a class from the test source tree?

2012-06-13 Thread Gilles Sadowski
Hi. Is there a way for an application to depend on the classes defined in the test subtree of the code repository? If the component releases the test jar, then it should be possible. It seems that it's not released as a JAR (probably only in the zip/tar and source archive). But if

[Math] How to select a specific JDK ?

2012-06-13 Thread Gilles Sadowski
Hello. Are there command-line switches that will select a specific JDK? I.e. I have several of them installed: $ ls -l /usr/lib/jvm total 36 lrwxrwxrwx 1 root root 24 Dec 17 11:04 default-java - java-1.6.0-openjdk-amd64 lrwxrwxrwx 1 root root 18 Jan 5 18:27 java-1.5.0-gcj -

Re: [Math] How to select a specific JDK ?

2012-06-13 Thread Gilles Sadowski
JAVA_HOME (another environment variable, but specific to the task at hand). On Wed, Jun 13, 2012 at 12:19 PM, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hello. Are there command-line switches that will select a specific JDK? I.e. I have several of them installed: $ ls -l /usr/lib

Re: [Math] How to use a class from the test source tree?

2012-06-13 Thread Gilles Sadowski
On Wed, Jun 13, 2012 at 12:34:51PM +0200, Benedikt Ritter wrote: Hi, 2012/6/13 Gilles Sadowski gil...@harfang.homelinux.org: Hi. Is there a way for an application to depend on the classes defined in the test subtree of the code repository? If the component releases the test

Re: [Math] How to select a specific JDK ?

2012-06-13 Thread Gilles Sadowski
. With ant, all that's needed is to define JAVA_HOME (another environment variable, but specific to the task at hand). On Wed, Jun 13, 2012 at 12:19 PM, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hello. Are there command-line switches that will select a specific

Re: [Math] How to select a specific JDK ?

2012-06-13 Thread Gilles Sadowski
is to check that the unit tests pass independently of the javac and java versions. Best regards, Gilles 2012/6/13 Gilles Sadowski gil...@harfang.homelinux.org Hello. With maven, you can configure the compiler to compile in the version you want. Add this to the pom.xml

Re: [Math] How to select a specific JDK ?

2012-06-13 Thread Gilles Sadowski
(windoze vs. linux, jdk7 vs. jdk6, etc.) On Wed, Jun 13, 2012 at 10:47 AM, Gilles Sadowski gil...@harfang.homelinux.org wrote:   On Wed, Jun 13, 2012 at 03:05:13PM +0200, Xavier Detant wrote:   The byte code generated by the compiler is totally independent from the JVM   that will be used

Re: [Math] How to select a specific JDK ?

2012-06-13 Thread Gilles Sadowski
purpose is not continuous integration; just, at some point in time, be able to compile and run the tests with different JDK versions/vendors (and expecting the same output). Best regards, Gilles On Wed, Jun 13, 2012 at 10:47 AM, Gilles Sadowski gil...@harfang.homelinux.org wrote: On Wed, Jun 13

Re: [Math] How to select a specific JDK ?

2012-06-13 Thread Gilles Sadowski
, you should use a dedicated tool as Jenkins (I don't know if continuum can do that). If you want, you can use profiles in Maven to switch easily the versions to use ( http://maven.apache.org/guides/introduction/introduction-to-profiles.html). 2012/6/13 Gilles Sadowski gil

Re: [Math] How to select a specific JDK ?

2012-06-13 Thread Gilles Sadowski
On Wed, Jun 13, 2012 at 06:59:05PM +0200, Jörg Schaible wrote: Gilles Sadowski wrote: On Wed, Jun 13, 2012 at 03:05:13PM +0200, Xavier Detant wrote: The byte code generated by the compiler is totally independent from the JVM that will be used to run it. Totally independent? Compiling

Re: [Math] How to select a specific JDK ?

2012-06-13 Thread Gilles Sadowski
Hello. [...] The following: I should be able to do all combinations, i.e.:  1. Compile with javac 1.6 and run with java 1.6  2. Compile with javac 1.7 and run with java 1.7 is achieved by those respective commands: $ JAVA_1_6_HOME=/usr/lib/jvm/java-6-sun mvn -X -Pjava-1.6 clean

Re: [Math] How to select a specific JDK ?

2012-06-14 Thread Gilles Sadowski
On Thu, Jun 14, 2012 at 05:31:23PM +0100, sebb wrote: On 14 June 2012 02:15, Gilles Sadowski gil...@harfang.homelinux.org wrote: Hello. [...] The following: I should be able to do all combinations, i.e.:  1. Compile with javac 1.6 and run with java 1.6  2. Compile

Re: svn commit: r1348721 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/OpenMapRealVector.java test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

2012-06-15 Thread Gilles Sadowski
Hi. [...] I fully agree. We could also opt for a less correct, but more efficient solution: we do not store the sign of zero, and return NaN each time v / zero occurs. The result should be NaN anyway, because its sign is undecidable. This specificity would be clearly stated in the

Re: svn commit: r1348721 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/OpenMapRealVector.java test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

2012-06-15 Thread Gilles Sadowski
Hi. [...] I fully agree. We could also opt for a less correct, but more efficient solution: we do not store the sign of zero, and return NaN each time v / zero occurs. The result should be NaN anyway, because its sign is undecidable. This specificity would be clearly stated in

Re: svn commit: r1348721 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/OpenMapRealVector.java test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

2012-06-16 Thread Gilles Sadowski
[...] Maybe that we could also impose that it is forbidden to divide by a sparse vector whose default value is zero. This will avoid a check on all entries (at the expense of forbidding legitimate divisions, when all the entries have a non-default value; but then one would

Re: svn commit: r1353140 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/Incrementor.java

2012-06-23 Thread Gilles Sadowski
Hello. On Sat, Jun 23, 2012 at 03:09:15PM -, celes...@apache.org wrote: Author: celestin Date: Sat Jun 23 15:09:14 2012 New Revision: 1353140 Either I don't understand this change, or I don't agree with it. URL: http://svn.apache.org/viewvc?rev=1353140view=rev Log: In

Re: svn commit: r1353140 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/Incrementor.java

2012-06-23 Thread Gilles Sadowski
Hi Sébastien. Author: celestin Date: Sat Jun 23 15:09:14 2012 New Revision: 1353140 Either I don't understand this change, or I don't agree with it. URL: http://svn.apache.org/viewvc?rev=1353140view=rev Log: In o.a.c.m3.Incrementor, modified constructor to allow for null

Re: svn commit: r1353386 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util: Incrementor.java IterationManager.java

2012-06-25 Thread Gilles Sadowski
Hello Sébastien. /** @@ -66,22 +72,16 @@ public class Incrementor { * counter exhaustion. * * @param max Maximal count. - * @param cb Function to be called when the maximal count has been reached - * (can be {@code null}). + * @param cb Function to be

  1   2   3   4   5   6   7   8   9   10   >