[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.
Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/61#discussion_r130978503 --- Diff: pom.xml --- @@ -171,6 +171,7 @@ src/site/resources/download_lang.cgi src/test/resources/stringEscapeUtilsTestData.txt src/site/resources/release-notes/RELEASE-NOTES-*.txt + .travis.sh --- End diff -- Sure, this was quick fix ;-) ... one more thing, do we need consent from jacoco using and modifying their file ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-cli/pull/16 @PascalSchumacher , can you take a look at this ? seems only issue with findbug on java6 build, rest seems Ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-cli/pull/16 @PascalSchumacher , can you take a look at this ? seems only issue with findbug on java6 build, rest seems Ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/61 Added flexible Travis-ci build script. This enables ua to use any jdk against our code and not keeps us dependency on Travis to provide jdk You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-text travis-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 4af7ca425032c40ba71e23da0664d38a2d307576 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-29T14:49:17Z added jacoco style travis build commit 2bd09c827b2b1297b6b8fd4c85a7d4587b7bb1da Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-29T14:55:11Z modified permission to executable file commit 935be51655f57dcefe2ffd7dc15758cd12cc3047 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-29T15:00:47Z removed java6 option commit cba4a1e8740f60c760d31f501882f539b3cca055 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-29T18:30:17Z added ibm java 8 commit f8fc754cedb19dd28e90a5673944d2a024356368 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-29T18:55:55Z print system info commit 4147b1bc07c4863bec07f3f4fcc8d04fe91281e8 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-29T19:17:43Z install ibmjdk8 to ./ commit 796cc3a927c757aae15bd8710ad32c56387273fc Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-29T19:22:05Z install ibmjdk8 to ./ commit 8827c044cf237b7a95d53d61cbc62a01e80639c9 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-30T11:22:17Z check space on travis box commit 111678e8679ec8d3fa73ebaf93b74a29eccdfd88 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-30T11:27:04Z use trusty for build commit e92323096cfd3fed7e0980144b31f98575fdd387 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-07-30T11:39:06Z back to precise plus sudo truewq commit 44c36828b5b335ee1df09d28a477ab9c88079157 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-08-01T19:28:34Z using 64 bit edition --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.
Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/61#discussion_r131239555 --- Diff: pom.xml --- @@ -171,6 +171,7 @@ src/site/resources/download_lang.cgi src/test/resources/stringEscapeUtilsTestData.txt src/site/resources/release-notes/RELEASE-NOTES-*.txt + .travis.sh --- End diff -- which part of their license shall I add ? content of their ```License.md``` ? seems like they distribut code with eclipse license. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.
Github user ameyjadiye closed the pull request at: https://github.com/apache/commons-text/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #61: Added flexible Travis-ci build script.
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/61 Because of low interest of community adapting this change i'm closing this pull request. http://markmail.org/message/mn2or73hqsz6oxo2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #49: TEXT-89: UTF-32 support for WordUtils.initials using...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/49 @arunvinudss , can you please rename PR saying character processing switched with codepoints and change commit comment as well, that you can do with ```rebase``` or ```git commit --amend``` and then force push. with this we can accept and close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #49: TEXT-89: UTF-32 support for WordUtils.initials using...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/49 probably just because utf-32 it could be confusing, @ecki can explain more. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #49: TEXT-89: UTF-32 support for WordUtils.initials using...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/49 For detailed explanation. https://www.joelonsoftware.com/2003/10/08/the-absolute-minimum-every-software-developer-absolutely-positively-must-know-about-unicode-and-character-sets-no-excuses/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #49: TEXT-89: UTF-32 support for WordUtils.initials using...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/49 @chtompki , this PR looks good, shall we merge it ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/48 ```isDelimiter``` is simply the method to identify if codePoint or char is present in given second parameter which is array. ofcource if array is empty it means first param is not present in array and should return false, I think overall behaviour of ```capitalizeFully``` is correct now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/55 Yeah, will see if we can simplify API in 2.x . I need opinion on the method I have given in this PR, According to me it's good addition to existing API but go through JIRA discussion once. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #49: TEXT-89: WordUtils.initials support for UTF-16 surro...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/49 @arunvinudss , amend commit comment as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #49: TEXT-89: WordUtils.initials support for UTF-16 surro...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/49 @chtompki , @PascalSchumacher this seems good to me for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #56: add-some-Unit Tests
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/56 @PascalSchumacher I just enabled in my local, seems very cumbersome task to me at this point. ``` [INFO] There are 2551 checkstyle errors. . . . [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 41.252 s [INFO] Finished at: 2017-07-18T23:18:57+05:30 [INFO] Final Memory: 36M/621M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.13:check (default-cli) on project commons-text: You have 2551 Checkstyle violations. -> [Help 1] . . . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/57 @chtompki , I think whichever items are piled up for 2.x are not too critical, we should wait for 2.x release. If we are releasing some major improvement or fix we can release all queued items in that. ATM I don't see anything. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #57: TEXT-98: Remove isDelimiter and use HashSets ...
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/57#discussion_r129102692
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -747,45 +750,29 @@ public static boolean containsAllWords(final
CharSequence word, final CharSequen
return true;
}
-
//---
+//
---
/**
- * Is the character a delimiter.
+ *
+ * Converts an array of delimiters to a hash set of code points. Code
point of space(32) is added as the default
+ * value if delimiters is null. The generated hash set provides O(1)
lookup time.
+ *
*
- * @param ch the character to check
- * @param delimiters the delimiters
- * @return true if it is a delimiter
+ * @param delimiters set of characters to determine capitalization,
null means whitespace
+ * @return Set
*/
-public static boolean isDelimiter(final char ch, final char[]
delimiters) {
-if (delimiters == null) {
-return Character.isWhitespace(ch);
-}
-for (final char delimiter : delimiters) {
-if (ch == delimiter) {
-return true;
+private static Set generateDelimiterSet(final char[]
delimiters) {
+Set delimiterHashSet = new HashSet<>();
+if (delimiters == null || delimiters.length == 0) {
+if (delimiters == null) {
+delimiterHashSet.add(Character.codePointAt(new char[] {'
'}, 0));
}
+return delimiterHashSet;
}
-return false;
-}
- //---
-/**
- * Is the codePoint a delimiter.
- *
- * @param codePoint the codePint to check
- * @param delimiters the delimiters
- * @return true if it is a delimiter
- */
-public static boolean isDelimiter(final int codePoint, final char[]
delimiters) {
--- End diff --
Rather removing we should keep this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #57: TEXT-98: Remove isDelimiter and use HashSets ...
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/57#discussion_r129102634
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -747,45 +750,29 @@ public static boolean containsAllWords(final
CharSequence word, final CharSequen
return true;
}
-
//---
+//
---
/**
- * Is the character a delimiter.
+ *
+ * Converts an array of delimiters to a hash set of code points. Code
point of space(32) is added as the default
+ * value if delimiters is null. The generated hash set provides O(1)
lookup time.
+ *
*
- * @param ch the character to check
- * @param delimiters the delimiters
- * @return true if it is a delimiter
+ * @param delimiters set of characters to determine capitalization,
null means whitespace
+ * @return Set
*/
-public static boolean isDelimiter(final char ch, final char[]
delimiters) {
--- End diff --
Rather removing we should keep this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/57 @arunvinudss , just addition to @PascalSchumacher comment , at this point we don't know other than Commons text who else having dependancy on `isDelimiter` so better we can make it depricated and we can remove code all together in 2.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #55: TEXT-97: RandomStringGenerator able to pass m...
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/55
TEXT-97: RandomStringGenerator able to pass multiple ranges to
.withinRange()
*.withinRange()* now able to accept multiple ranges.
Ex.
```
final char [][] pairs = {{'a','z'},{'0','9'}};
RandomStringGenerator generator = new
RandomStringGenerator.Builder().withinRange(pairs).build();
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameyjadiye/commons-text TEXT-97
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-text/pull/55.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #55
commit beb0b4615a94420cc86595c1f060711dd999af91
Author: Amey Jadiye <ameyjad...@gmail.com>
Date: 2017-07-01T14:55:35Z
RandomStringGenerator able to pass multiple ranges to .withinRange()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/48 I think we are good to merge this as per discussion here [TEXT-88](https://issues.apache.org/jira/browse/TEXT-88) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/55 @chtompki , @PascalSchumacher , can you please express your opinion on this , please check JIRA for detail discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #59: add oraclejdk9 to travis configuration
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/59 @chtompki , I'm testing same on my Commons Text fork , that shell file need a bit modification for Commons , will raise PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli pull request #16: added findbug and checkstyle support while bui...
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-cli/pull/16 added findbug and checkstyle support while building You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-cli master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-cli/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit d6dcadb6d7c8a25996a0e71ec482c419ae963ea0 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-08-01T18:45:47Z added findbug and checkstyle support while building --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/44 Hi @britter, there is no issue even in checkstyle with my changes, above Travis build failed because there was some trailing space issue in master and which you have already fixed. merging this will pass everything clean *OR* you want me to do some dummy commit so Travis will trigger again and clear error on this PR ? I don't think that's needed though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 Hi @garydgregory , I think removing ``` test ``` is not good idea, better we can have ```verify``` along with ```test``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121062216 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk + script: - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc + - docker run -v `pwd`:/work ibmcom/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work && apt-get install -y maven && mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc" --- End diff -- thanks @britter for pointing this out. fixed now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #48: TEXT-88: Fixed issue with empty delimiters ar...
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/48 TEXT-88: Fixed issue with empty delimiters array with capitalizeFully You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-text TEXT-88 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 commit 0dd69e060be13c596316e878da2c3591b722c015 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-06-12T17:56:46Z TEXT-88: Fixed issue with empty delimiters array with capitalizeFully --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/52 Cool, seems clean now :+1: thanks Pascal. Trick will be certainly beneficial in future to me ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/52 @PascalSchumacher This seems nice trick , but somehow didn't worked for me and ended up just pushing latest commit, can you try this once ? I have given you write access for exact this repository. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #52: Test: Improved testcase coverage for StrBuilder
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/52 Fixed all the code as suggested, Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/54 TEXT-93: RandomStringGenerator accepts a list of valid characters Added selectFrom feature : ``` selectFromList(char[] chars) selectFromList(List charList) ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-text TEXT-93 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit 278f1e0fb553fc2d2d6f5563d9e61899776cd80d Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-06-22T21:18:11Z TEXT-93: RandomStringGenerator accepts a list of valid characters --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...
Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/54#discussion_r123877950 --- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java --- @@ -76,23 +78,29 @@ private final TextRandomProvider random; /** + * The source of provided charachters. + */ +private final List characterList; + +/** * Constructs the generator. - * - * @param minimumCodePoint + * @param minimumCodePoint *smallest allowed code point (inclusive) * @param maximumCodePoint *largest allowed code point (inclusive) * @param inclusivePredicates - *filters for code points - * @param random - *source of randomness + *filters for code points --- End diff -- yeah, seems like IntelliJ did this unknowingly, fixed it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #54: TEXT-93: RandomStringGenerator accepts a list of val...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/54 As per discussion here[TEXT-93](https://issues.apache.org/jira/browse/TEXT-93) we are good to merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/44 @britter , please review and accept this PR. Travis build on this is because previous commit in master , by merging this won't make any issue in master. Tested on local before creating PR. With this comment we can test if activity goes to dev ml. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/44 Hi @garydgregory , Its already discussed here [LANG-564](https://issues.apache.org/jira/browse/LANG-564) and [TEXT-80](https://issues.apache.org/jira/browse/TEXT-80) and all seems agree on changing the code, according to discussion code proposed in this PR will improve the API. As this is moved from commons lang, version of ```StrLookup``` will soon be deprecated. so no cross module impact I see for now and yes whoever using text 1.0, 1.1 will need to change code very minimal. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/44 Hi @chtompki , since commons-text is relatively new there are very [low usage](https://mvnrepository.com/artifact/org.apache.commons/commons-text), ```clirr:check``` is also passed whoever is using it and wants to bump version needs minor change in their code, but its ok we can park it till 2.X release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/45 Added IBM Jdk8 build support to travis-ci configuration You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-text travis-ibmjdk8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/45.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #45 commit 4774bb19f318ee15232f4d5f3cc08245eb9b9b3a Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-06-08T19:50:27Z adding ibmjdk8 support to commons-text commit 90b5426b33476d091b19eb50de8d352a2295b8c7 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-06-08T19:59:59Z assume yes for all apt-get install --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 Hi @PascalSchumacher , where did you see build is failing ? I see all builds passed given in your link https://travis-ci.org/apache/commons-text/jobs/243003865, Yes ibmjdk8 is running after each build , that's how Travis handling it , but its ok over the cost of not checking code with ibmjdk8 And if build fails it do mark build as failed i did verified that because maven return exit code as -1 which all the way go to Travis to mark RED. At this point all (openjdk7, oraclejdk7, oraclejdk7, ibmjdk8*3) = 6 builds as passing . I see some exception on findbug library and that's not issue with Commons Text code but in findbug code and that's because they might not have considered ibmjdk8 for their build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #52: Test: Improved testcase coverage for StrBuild...
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/52 Test: Improved testcase coverage for StrBuilder added some missing flows to testcases plus some nice formatting for easy understanding. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-text test-StrBuilder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit 06e8b3dd06ee2f86490b2e94359d29d2fe04786c Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-06-15T20:15:10Z test: Improved testcase coverage for StrBuilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 @chtompki, I think we are good to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #42: TEXT-83: Deprecate CsvTranslators from from commons ...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/42 Hi @chtompki, do we expect anything more to be done here ? as per @garydgregory it looks good to be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/44 Lets park this for 2.X release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121184938 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk --- End diff -- Hi @chtompki , I just [compared](https://www.diffchecker.com/y4s7vOx6) them and found both Dockerfile belongs to same repository, I took the one from master. Official belongs to some past commit. I prefer to go with official ``` library/ibmjava:8-sdk ``` though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 Created one image containing maven with ibmjava8, same can be pushed to apache dockerhub repo https://hub.docker.com/r/ameyjadiye/ibmjava8/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Github user ameyjadiye commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121188654 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install: + - docker pull ibmcom/ibmjava:8-sdk + script: - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc + - docker run -v `pwd`:/work ibmcom/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work && apt-get install -y maven && mvn" --- End diff -- Hi @britter @garydgregory @chtompki Flashed a though, can we use our own image for this ? we can build it from ```library/ibmjava:8-sdk```. Rather doing ```apt-get update``` and ```apt-get install -y maven``` again and again on fly we can just build our own with below Dockerfile on [Dockerhub](https://hub.docker.com), I also found we have [apache account](https://hub.docker.com/u/apache/) so it will be easy to publish it there. same can be reused by some other project in apache. _(that's why commons is made for anyway :blush: )_ ``` from library/ibmjava:8-sdk RUN apt-get update RUN apt-get install -y maven ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/62 @chtompki , can you take a look if this looks good ? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-cli/pull/16 @chtompki , is this not accepted ? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-cli/pull/16 @chtompki , is this not accepted ? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-cli/pull/16 Thanks @PascalSchumacher --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-cli issue #16: added findbug and checkstyle support while building
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-cli/pull/16 Thanks @PascalSchumacher --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/55 @chtompki , If possible can you review and accept this ? I need this for TEXT-101. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/55 @chtompki , I'm sorry for such short note, 2.x was for making .builder() static, PR seems ok for accepting in 1.2 release, you might want to go though jira as well. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #62: TEXT-101: Moved RandomStringUtils to Commons-...
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/62 TEXT-101: Moved RandomStringUtils to Commons-text Moved **RandomStringUtils** from lang to text along with changed core logic which is using **RandomStringGenerator** internally, Test cases are copied from commons-lang for making sure its working as it's working in commons-lang. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ameyjadiye/commons-text TEXT-101 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit aebacbabaa3debae909081cbd55475f6f108d141 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-09-06T20:40:11Z copied RandomStringGenerator required code from master commit e45738f00417ac0dcae1784c7904dc6fc156ae32 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-09-06T20:41:51Z TEXT-101 : Moved RandomStringUtils from lang to text with improved core logic commit 00011e92477ca610a313c40ed749512e5443ffa2 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-09-06T20:43:33Z added Amey's email id --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/62 @chtompki , can you please take look at this PR ? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/62 Hi @chtompki , do you see more places to improvement or its good now ? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #66: Adding validation for pair
GitHub user ameyjadiye opened a pull request: https://github.com/apache/commons-text/pull/66 Adding validation for pair adding validation of pairs where each pair must contain only 2 char min and max. You can merge this pull request into a Git repository by running: $ git pull https://github.com/codeinventory/commons-text master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit 99409ac1450dfeb1210d28ae80fb97eab6251406 Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-09-30T09:27:48Z adding validation for pair commit 0fd044f4b88bfb5055c53dc84463831a0c42972d Author: Amey Jadiye <ameyjad...@gmail.com> Date: 2017-09-30T09:30:18Z added amey's mail id --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #62: TEXT-101: Moved RandomStringUtils to Commons-...
Github user ameyjadiye closed the pull request at: https://github.com/apache/commons-text/pull/62 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/62 As per discussion on Dev ML we are undoing deprecation of RandomStringUtils in Lang and discarding this solution. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #62: TEXT-101: Moved RandomStringUtils to Commons-...
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/62#discussion_r140843601
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java
---
@@ -324,6 +324,40 @@ public Builder withinRange(final int minimumCodePoint,
final int maximumCodePoin
/**
*
+ * Specifies the array of minimum and maximum char allowed in the
+ * generated string.
+ *
+ *
+ * For example:
+ *
+ * {@code
+ * char [][] pairs = {{'0','9'}};
+ * char [][] pairs = {{'a','z'}};
+ * char [][] pairs = {{'a','z'},{'0','9'}};
+ * }
+ *
+ *
+ * @param pairs array of charachters array, expected is to pass
min, max pairs through this arg.
+ * @return {@code this}, to allow method chaining.
+ */
+public Builder withinRange(final char[] ... pairs) {
+characterList = new ArrayList();
+for (char[] pair : pairs) {
+final int minimumCodePoint = pair[0];
+final int maximumCodePoint = pair[1];
--- End diff --
I think we should put that for better exception handling, also check of
```minimumCodePoint < maximumCodePoint ```, thanks
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/62 @chtompki , I think all were thinking to deprecate it from lang and so we did. and due to more requests for ```RandomStringUtils``` we came up with the plan to move it also I think since ```RandomStringUtils``` is texty thing so belongs to commons-text and not lang. In same mail trail you will see _"Grey area" should favour small components._ you should check this old mail trail as well http://markmail.org/message/bwyhvppr5s4waedp --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
