Re: Maven bugs when building Sanselan
On 2012-03-02 17:54, sebb wrote: On 2 March 2012 05:28, Damjan Jovanovic damjan@gmail.com wrote: On Thu, Mar 1, 2012 at 11:37 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I am unable to reproduce this error using current trunk of Sanselan. Are you using some local modifications to your pom.xml that specifies which artifact Clirr should compare against? All I get is this: [INFO] Unable to find a previous version of the project in the repository [INFO] Not generating Clirr report as there is no previous version of the library to compare against Clirr doesn't find the 0.97 release because the groupId and artifactId for it were different. It breaks for me because I somehow have Sanselan 0.98 (a version that was never released) in my ~/.m2 directory. But there is still a Clirr bug here which will affect future releases even if it doesn't affect this one. I will attach the minimum set of Sanselan 0.98 files needed to reproduce this bug to the bug report. I don't think applies here, but I have seen Clirr failures in the past that went away when the code was compiled with a different compiler. The failure occurred for me when code compiled by Eclipse was being checked (as can happen if using Eclipse to develop). Using mvn clean before running clirr fixed the issue. [It was a while ago; I think that was the the way it happened, rather than the reverse] See also the issue I raised a year ago: https://jira.codehaus.org/browse/MCLIRR-36 It would be good if someone in Maven-land could take a look; fixing the array bug should be trivial for someone that is familiar with building Maven plugins. Hi Just wanted to let you know that Clirr Maven Plugin 2.4 has been released. It includes a fix for MCLIRR-36. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: Maven bugs when building Sanselan
Le 02/03/2012 06:28, Damjan Jovanovic a écrit : Clirr doesn't find the 0.97 release because the groupId and artifactId for it were different. It breaks for me because I somehow have Sanselan 0.98 (a version that was never released) in my ~/.m2 directory. But there is still a Clirr bug here which will affect future releases even if it doesn't affect this one. IHMO don't waste too much time on this, it's not that important to have a Clirr report for a 1.0 release. The package will be different (org.apache.commons.imaging), so there is no point checking the binary compatibility. Emmanuel Bourg smime.p7s Description: S/MIME Cryptographic Signature
Re: Maven bugs when building Sanselan
On 2 March 2012 05:28, Damjan Jovanovic damjan@gmail.com wrote: On Thu, Mar 1, 2012 at 11:37 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I am unable to reproduce this error using current trunk of Sanselan. Are you using some local modifications to your pom.xml that specifies which artifact Clirr should compare against? All I get is this: [INFO] Unable to find a previous version of the project in the repository [INFO] Not generating Clirr report as there is no previous version of the library to compare against Clirr doesn't find the 0.97 release because the groupId and artifactId for it were different. It breaks for me because I somehow have Sanselan 0.98 (a version that was never released) in my ~/.m2 directory. But there is still a Clirr bug here which will affect future releases even if it doesn't affect this one. I will attach the minimum set of Sanselan 0.98 files needed to reproduce this bug to the bug report. I don't think applies here, but I have seen Clirr failures in the past that went away when the code was compiled with a different compiler. The failure occurred for me when code compiled by Eclipse was being checked (as can happen if using Eclipse to develop). Using mvn clean before running clirr fixed the issue. [It was a while ago; I think that was the the way it happened, rather than the reverse] See also the issue I raised a year ago: https://jira.codehaus.org/browse/MCLIRR-36 It would be good if someone in Maven-land could take a look; fixing the array bug should be trivial for someone that is familiar with building Maven plugins. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: Maven bugs when building Sanselan
On 2012-03-01 06:23, Damjan Jovanovic wrote: On Wed, Feb 29, 2012 at 9:45 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I'll take a look at the patch and see if I can push for a release of the Clirr plugin. Great, thank you! Damjan Hi I had some trouble building Sanselan locally with Java 5, so I added Sanselan to our Continuum CI server. The first build gives the same result as I got locally, which is a compilation failure. The full report is here: http://vmbuild.apache.org/continuum/buildResult.action?buildId=19556projectId=251 The error message is: [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /home/continuum/continuum-base/data/working-directory/251/src/main/java/org/apache/commons/sanselan/formats/jpeg/iptc/IptcParser.java:[56,37] cannot find symbol symbol : method copyOfRange(byte[],int,int) location: class java.util.Arrays That seems to be a Java 6 method. Someone should have a look at that. I'll continue chasing Clirr-bugs using Java 6 for the time being. -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: Maven bugs when building Sanselan
On Thu, Mar 1, 2012 at 2:25 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-03-01 06:23, Damjan Jovanovic wrote: On Wed, Feb 29, 2012 at 9:45 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I'll take a look at the patch and see if I can push for a release of the Clirr plugin. Great, thank you! Damjan Hi I had some trouble building Sanselan locally with Java 5, so I added Sanselan to our Continuum CI server. The first build gives the same result as I got locally, which is a compilation failure. The full report is here: http://vmbuild.apache.org/continuum/buildResult.action?buildId=19556projectId=251 The error message is: [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /home/continuum/continuum-base/data/working-directory/251/src/main/java/org/apache/commons/sanselan/formats/jpeg/iptc/IptcParser.java:[56,37] cannot find symbol symbol : method copyOfRange(byte[],int,int) location: class java.util.Arrays That seems to be a Java 6 method. Someone should have a look at that. I'll continue chasing Clirr-bugs using Java 6 for the time being. Interesting that I just mentioned: - Is there anything in Java 6 that would make Imaging better? Is using Java 5 vs. 6 an impediment? ! Why not use Java 6 for this component? Gary -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
Re: Maven bugs when building Sanselan
On Thu, Mar 1, 2012 at 2:25 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-03-01 06:23, Damjan Jovanovic wrote: On Wed, Feb 29, 2012 at 9:45 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I'll take a look at the patch and see if I can push for a release of the Clirr plugin. Great, thank you! Damjan Hi I had some trouble building Sanselan locally with Java 5, so I added Sanselan to our Continuum CI server. The first build gives the same result as I got locally, which is a compilation failure. The full report is here: http://vmbuild.apache.org/continuum/buildResult.action?buildId=19556projectId=251 The error message is: [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /home/continuum/continuum-base/data/working-directory/251/src/main/java/org/apache/commons/sanselan/formats/jpeg/iptc/IptcParser.java:[56,37] cannot find symbol symbol : method copyOfRange(byte[],int,int) location: class java.util.Arrays That seems to be a Java 6 method. Someone should have a look at that. I'll continue chasing Clirr-bugs using Java 6 for the time being. Why are we chasing Clirr-bugs when this is not released? Gary -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
Re: Maven bugs when building Sanselan
On Thu, Mar 1, 2012 at 9:25 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-03-01 06:23, Damjan Jovanovic wrote: On Wed, Feb 29, 2012 at 9:45 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I'll take a look at the patch and see if I can push for a release of the Clirr plugin. Great, thank you! Damjan Hi I had some trouble building Sanselan locally with Java 5, so I added Sanselan to our Continuum CI server. The first build gives the same result as I got locally, which is a compilation failure. The full report is here: http://vmbuild.apache.org/continuum/buildResult.action?buildId=19556projectId=251 The error message is: [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /home/continuum/continuum-base/data/working-directory/251/src/main/java/org/apache/commons/sanselan/formats/jpeg/iptc/IptcParser.java:[56,37] cannot find symbol symbol : method copyOfRange(byte[],int,int) location: class java.util.Arrays That seems to be a Java 6 method. Someone should have a look at that. I'll continue chasing Clirr-bugs using Java 6 for the time being. -- Dennis Lundberg Sorry about that. In commit 1295763 I've added the animal-sniffer-maven-plugin to the POM, configured it to check for Java 1.5 compatibility, and taken out the Arrays.copyOfRange(). Damjan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: Maven bugs when building Sanselan
On 2012-03-01 20:45, Gary Gregory wrote: On Thu, Mar 1, 2012 at 2:25 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-03-01 06:23, Damjan Jovanovic wrote: On Wed, Feb 29, 2012 at 9:45 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I'll take a look at the patch and see if I can push for a release of the Clirr plugin. Great, thank you! Damjan Hi I had some trouble building Sanselan locally with Java 5, so I added Sanselan to our Continuum CI server. The first build gives the same result as I got locally, which is a compilation failure. The full report is here: http://vmbuild.apache.org/continuum/buildResult.action?buildId=19556projectId=251 The error message is: [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /home/continuum/continuum-base/data/working-directory/251/src/main/java/org/apache/commons/sanselan/formats/jpeg/iptc/IptcParser.java:[56,37] cannot find symbol symbol : method copyOfRange(byte[],int,int) location: class java.util.Arrays That seems to be a Java 6 method. Someone should have a look at that. I'll continue chasing Clirr-bugs using Java 6 for the time being. Why are we chasing Clirr-bugs when this is not released? I'm trying to fix bugs in Maven Clirr Plugin. The JIRA tickets uses Commons Sanselan as an example project that shows the bugs in action. That's what got me building Sanselan. Gary -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: Maven bugs when building Sanselan
On Thu, Mar 1, 2012 at 3:18 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-03-01 20:45, Gary Gregory wrote: On Thu, Mar 1, 2012 at 2:25 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-03-01 06:23, Damjan Jovanovic wrote: On Wed, Feb 29, 2012 at 9:45 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I'll take a look at the patch and see if I can push for a release of the Clirr plugin. Great, thank you! Damjan Hi I had some trouble building Sanselan locally with Java 5, so I added Sanselan to our Continuum CI server. The first build gives the same result as I got locally, which is a compilation failure. The full report is here: http://vmbuild.apache.org/continuum/buildResult.action?buildId=19556projectId=251 The error message is: [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure /home/continuum/continuum-base/data/working-directory/251/src/main/java/org/apache/commons/sanselan/formats/jpeg/iptc/IptcParser.java:[56,37] cannot find symbol symbol : method copyOfRange(byte[],int,int) location: class java.util.Arrays That seems to be a Java 6 method. Someone should have a look at that. I'll continue chasing Clirr-bugs using Java 6 for the time being. Why are we chasing Clirr-bugs when this is not released? I'm trying to fix bugs in Maven Clirr Plugin. The JIRA tickets uses Commons Sanselan as an example project that shows the bugs in action. That's what got me building Sanselan. Ah... I see the light! :) G Gary -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
Re: Maven bugs when building Sanselan
On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I am unable to reproduce this error using current trunk of Sanselan. Are you using some local modifications to your pom.xml that specifies which artifact Clirr should compare against? All I get is this: [INFO] Unable to find a previous version of the project in the repository [INFO] Not generating Clirr report as there is no previous version of the library to compare against Otherwise, what is the procedure for renaming the project to Apache Commons Imaging? Thank you Damjan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: Maven bugs when building Sanselan
On Thu, Mar 1, 2012 at 11:37 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I am unable to reproduce this error using current trunk of Sanselan. Are you using some local modifications to your pom.xml that specifies which artifact Clirr should compare against? All I get is this: [INFO] Unable to find a previous version of the project in the repository [INFO] Not generating Clirr report as there is no previous version of the library to compare against Clirr doesn't find the 0.97 release because the groupId and artifactId for it were different. It breaks for me because I somehow have Sanselan 0.98 (a version that was never released) in my ~/.m2 directory. But there is still a Clirr bug here which will affect future releases even if it doesn't affect this one. I will attach the minimum set of Sanselan 0.98 files needed to reproduce this bug to the bug report. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Maven bugs when building Sanselan
Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. Otherwise, what is the procedure for renaming the project to Apache Commons Imaging? Thank you Damjan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: Maven bugs when building Sanselan
On Wed, Feb 29, 2012 at 1:00 PM, Damjan Jovanovic damjan@gmail.comwrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. Otherwise, what is the procedure for renaming the project to Apache Commons Imaging? I do not think there is an official guide one something like this. How about: - Create a new Imaging spot in SVN - Copy everything to the new place - Do all the renaming (Java packages, any names in the docs, and so on) - Rename or create the JIRA name. - Move the now old Sanselan to the Attic. Also to do before 1.0: - Update the parent POM and plugins to the latest - Is there anything in Java 6 that would make Imaging better? Is using Java 5 vs. 6 an impediment? - Add reports: PMD, FindBugs, Checkstyle (see Lang, Net, IO, Codec, for example) Gary Thank you Damjan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
Re: Maven bugs when building Sanselan
On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I'll take a look at the patch and see if I can push for a release of the Clirr plugin. Otherwise, what is the procedure for renaming the project to Apache Commons Imaging? Thank you Damjan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: Maven bugs when building Sanselan
On Wed, Feb 29, 2012 at 9:45 PM, Dennis Lundberg denn...@apache.org wrote: On 2012-02-29 19:00, Damjan Jovanovic wrote: Hi As we near the 1.0 release of Sanselan / Apache Commons Imaging, I am having showstopper problems with Maven. The first problem, now fixed, was that mvn assembly:assembly failed due to the Maven Assembly plugin failing to add a non-ASCII filename to a tar file (https://jira.codehaus.org/browse/MASSEMBLY-515), because Plexus Archiver had a bug that wrongly assumed number of chars = number of bytes, an assumption that quickly fails on UTF-8 locales (http://jira.codehaus.org/browse/PLXCOMP-195). I sent a patch to Plexus Archiver, they quickly included that patch in the next release, and Maven Assembly then made a 2.3 release which unknowingly pulled in that new release of Plexus Archiver. So by increasing the needed version of Maven Assembly to 2.3, I got that working now :). I see someone recently patched the Commons parent POM with the same version change - even better. The second is that mvn site fails because Clirr can't compare some inner classes properly, and the Maven Clirr plugin doesn't properly count and delete classes that can't be compared, leading to ArrayIndexOutOfBoundsException (http://jira.codehaus.org/browse/MCLIRR-36 and probably http://jira.codehaus.org/browse/MCLIRR-25 and http://jira.codehaus.org/browse/MCLIRR-37). I made and attached a working patch to that bug, but there's been no response yet and the project seems dead :(. I'll take a look at the patch and see if I can push for a release of the Clirr plugin. Great, thank you! Damjan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
