On Tue, 10 Oct 2023 at 13:52, Gary Gregory wrote:
>
> I agree that '--file pom.xml' is superfluous, it probably comes from
> something that was generated or from copy pasta.
>
> RE other options, I prefer full option names like: 'mvn -V
> --batch-mode --no-transfer-progress' because it makes
I agree that '--file pom.xml' is superfluous, it probably comes from
something that was generated or from copy pasta.
RE other options, I prefer full option names like: 'mvn -V
--batch-mode --no-transfer-progress' because it makes maintenance and
eyeballing straightforward without requiring
On Tue, 10 Oct 2023 at 13:05, Gary Gregory wrote:
>
> On Mon, Oct 9, 2023 at 7:50 PM sebb wrote:
> >
> > On Sun, 8 Oct 2023 at 18:52, Gary Gregory wrote:
> > >
> > > The default goal is always used by GitHub builds
> >
> > Are you sure about that?
>
> Yes, UNLESS, someone has decided to
On Mon, Oct 9, 2023 at 7:50 PM sebb wrote:
>
> On Sun, 8 Oct 2023 at 18:52, Gary Gregory wrote:
> >
> > The default goal is always used by GitHub builds
>
> Are you sure about that?
Yes, UNLESS, someone has decided to circumvent the default goal with a
custom goal list in a .github file.
Gary
On Sun, 8 Oct 2023 at 18:52, Gary Gregory wrote:
>
> The default goal is always used by GitHub builds
Are you sure about that?
GH does not automatically know how to call Maven.
We have to configure the calls in the workflows.
Not all workflows rely on the default goal, though most do.
> and it
On Sun, 8 Oct 2023 at 22:53, sebb wrote:
>
> > > On Oct 8, 2023, at 7:11 AM, sebb wrote:
> > >
> > > There are currently lots of variations of the defaultGoal in different
> > > components.
> > >
> > > It may be sensible to establish a standard setting which components
> > > should adopt
On Sun, 8 Oct 2023 at 18:25, Phil Steitz wrote:
>
> What exactly is the point of the default goal? I mean when is it expected to
> be used? Automations? Pipes of some kind? It’s not always executed, right?
> So if I say “clean” was the default, “mvn test” would not mean “mvn clean
>
The default goal is always used by GitHub builds and it is nice to use as a
dev before you push. This lets us avoid putting some custom mvn call in the
GH build definition. We can also document to users that calling 'mvn' is a
all you need to do to validate a PR or push.
Gary
On Sun, Oct 8,
What exactly is the point of the default goal? I mean when is it expected to
be used? Automations? Pipes of some kind? It’s not always executed, right?
So if I say “clean” was the default, “mvn test” would not mean “mvn clean
test”, right?
Phil
> On Oct 8, 2023, at 7:11 AM, sebb
On Sun, 8 Oct 2023 at 17:18, Gary Gregory wrote:
>
> What matters is the space and noise saved by putting plug-in configurations
> in the parent POM. The default goal is a single line so the savings there
> is minuscule IMO.
I agree the savings are minuscule.
But that is not the only reason to
What matters is the space and noise saved by putting plug-in configurations
in the parent POM. The default goal is a single line so the savings there
is minuscule IMO.
Gary
On Sun, Oct 8, 2023, 12:05 PM sebb wrote:
> On Sun, 8 Oct 2023 at 15:38, Gilles Sadowski wrote:
> >
> > Le dim. 8 oct.
(verify includes test and package)
Looks like there is some consensus for:
clean verify
-- plus --
apache-rat:check
checkstyle:check
japicmp:cmp
javadoc:javadoc
pmd:check
spotbugs:check
I think these should be optional:
pmd:cpd-check
revapi:check
On Sun, 8 Oct 2023 at 17:04, sebb wrote:
>
On Sun, 8 Oct 2023 at 15:38, Gilles Sadowski wrote:
>
> Le dim. 8 oct. 2023 à 16:11, sebb a écrit :
> >
> > There are currently lots of variations of the defaultGoal in different
> > components.
> >
> > It may be sensible to establish a standard setting which components
> > should adopt (unless
Le dim. 8 oct. 2023 à 16:48, Gary Gregory a écrit :
>
> Clirr and FindBugs are now unmainted and broken on modern Java versions.
> They have been replaced by JApiCmp and SpotBugs.
+1 to not run deprecated software.
>
> It does not make sense IMO to run both JApiCmp and RevApi, they do the same
Clirr and FindBugs are now unmainted and broken on modern Java versions.
They have been replaced by JApiCmp and SpotBugs.
It does not make sense IMO to run both JApiCmp and RevApi, they do the same
thing.
Gary
On Sun, Oct 8, 2023, 10:38 AM Gilles Sadowski wrote:
> Le dim. 8 oct. 2023 à
Le dim. 8 oct. 2023 à 16:11, sebb a écrit :
>
> There are currently lots of variations of the defaultGoal in different
> components.
>
> It may be sensible to establish a standard setting which components
> should adopt (unless there is a good reason to do otherwise).
+1
>
> If so, what should
There are currently lots of variations of the defaultGoal in different
components.
It may be sensible to establish a standard setting which components
should adopt (unless there is a good reason to do otherwise).
If so, what should that be, and where does it get documented?
Personally, I don't
17 matches
Mail list logo