Re: [DBCP] ManagedConnection must clear its cached state after transaction completes

2020-12-26 Thread Florent Guillaume
Hi, You're right. I've now added a test in the PR. Thanks, Florent On Thu, Dec 10, 2020 at 8:55 PM Gary Gregory wrote: > Hi Florent, > > There has to be a way to test SOMETHING about this, using H2 for example, > or mocking, otherwise, this is just a regression bug waiting to happen. > >

Re: [DBCP] ManagedConnection must clear its cached state after transaction completes

2020-12-10 Thread Gary Gregory
Hi Florent, There has to be a way to test SOMETHING about this, using H2 for example, or mocking, otherwise, this is just a regression bug waiting to happen. Gary On Tue, Dec 8, 2020 at 7:19 PM Florent Guillaume wrote: > Hi, > > A few weeks ago I opened the ticket >

[DBCP] ManagedConnection must clear its cached state after transaction completes

2020-12-08 Thread Florent Guillaume
Hi, A few weeks ago I opened the ticket https://issues.apache.org/jira/browse/DBCP-568 (ManagedConnection must clear its cached state after transaction completes) with an associated proposed fix at https://github.com/apache/commons-dbcp/pull/75. Would anyone be interested in reviewing this?