Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/44
I'm closing this as `StrLookup` will deprecated and replaced with
`StringLookup` in the next release.
---
-
To
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
Lets park this for 2.X release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/44
[](https://coveralls.io/builds/11887530)
Coverage remained the same at 96.653% when pulling
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/44
@britter - I would have to test it out, but fair point.
It feels like we should always maintain source and binary backwards
compatibility for minor version updates. But, if the policy
Github user britter commented on the issue:
https://github.com/apache/commons-text/pull/44
@chtompki this indicates a source incompatible release. Binary compatible
means that you can swap out the 1.1 jar with the 1.2 jar without a recompile.
Would that work?
I can't recall
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/44
@britter if I declare a class
```java
package com.rt;
import org.apache.commons.text.StrLookup;
public class TextTester extends StrLookup {
public String
Github user britter commented on the issue:
https://github.com/apache/commons-text/pull/44
@ameyjadiye the best would be to rebase your branch against master an dann
do a force push. You can do it like this (if you have configured this
repository as remote with name upstream):
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
Hi @britter, there is no issue even in checkstyle with my changes, above
Travis build failed because there was some trailing space issue in master and
which you have already fixed. merging
Github user britter commented on the issue:
https://github.com/apache/commons-text/pull/44
@chtompki did you run chirr manually? Because it was checkstyle which
caused the Travis build to fail (trailing white spaces). I think this change
should not break BC. @ameyjadiye can you
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
Hi @chtompki , since commons-text is relatively new there are very [low
usage](https://mvnrepository.com/artifact/org.apache.commons/commons-text),
```clirr:check``` is also passed whoever
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/44
The change is generally all right with me, but we can't release this until
a 2.X release though because of signature changes.
---
If your project is set up for it, you can reply to this email
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
Hi @garydgregory , Its already discussed here
[LANG-564](https://issues.apache.org/jira/browse/LANG-564) and
[TEXT-80](https://issues.apache.org/jira/browse/TEXT-80) and all seems agree on
Github user garydgregory commented on the issue:
https://github.com/apache/commons-text/pull/44
BTW, this will break source compatibility for certain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user garydgregory commented on the issue:
https://github.com/apache/commons-text/pull/44
Hi All,
Why is it confusing? Why is the patch better? You get the idea, you have to
make a point that what you propose is better beyond changing source.
Gary
---
If your
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/44
Would this imply a 2.0 release because of BC compatibility?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user britter commented on the issue:
https://github.com/apache/commons-text/pull/44
LGTM, @chtompki what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/44
@britter , please review and accept this PR. Travis build on this is
because previous commit in master , by merging this won't make any issue in
master. Tested on local before creating PR.
17 matches
Mail list logo
