Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/57
Will get to this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/57
@chtompki Please review and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/57
[](https://coveralls.io/builds/12640859)
Coverage decreased (-0.2%) to 98.021% when pulling
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/57
@chtompki , I think whichever items are piled up for 2.x are not too
critical, we should wait for 2.x release.
If we are releasing some major improvement or fix we can release all queued
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/57
This all opens the question about going `2.x`. I think we have a couple of
things that would warrant a 2.x move. Do we want to attempt that in the fall,
or is it still too premature?
---
If
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/57
@arunvinudss , just addition to @PascalSchumacher comment , at this point
we don't know other than Commons text who else having dependancy on
`isDelimiter` so better we can make it
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/57
@arunvinudss While I agree that `isDelimiter` should have been private, it
is public and was released with commons-text `1.1`. Due to the strict binary
compatibilities promise of
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/57
@ameyjadiye I want to remove the isDelimiter method. I would be surprised
if someone uses isDelimiter separately because all it does is to check if a
given element is present in an array or
