[GitHub] couchdb-fabric pull request: Respect doc_options during _all_docs ...

2015-02-11 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-fabric/pull/13#issuecomment-73856750 Is somebody able to review this? It would make another swath of PouchDB tests happy if we can get COUCHDB-2568 fixed :) --- If your project is set up

[GitHub] couchdb-fabric pull request: Respect doc_options during _all_docs ...

2015-02-06 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-fabric/pull/13 Respect doc_options during _all_docs serialization When full documents are returned as part of an _all_docs response, respect doc_options (e.g. attachments=true) during JSON serialization

[GitHub] couchdb-fabric pull request: Respect conflicts=true when collectin...

2015-02-02 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-fabric/pull/11#issuecomment-72524473 After looking at COUCHDB-2522 I think this is the wrong fix. Instead we should be figuring out how to populate Options correctly... --- If your project is set

[GitHub] couchdb-fabric pull request: Respect conflicts=true when collectin...

2015-02-02 Thread willholley
Github user willholley closed the pull request at: https://github.com/apache/couchdb-fabric/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fabric pull request: Respect conflicts=true when collectin...

2015-02-02 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-fabric/pull/11#issuecomment-72532030 Ah no - I think I was right the first time. COUCHDB-2522 is broken because we're not populating/handling #changes_args.doc_options. --- If your project is set

[GitHub] couchdb-fabric pull request: Respect conflicts=true when collectin...

2015-02-02 Thread willholley
GitHub user willholley reopened a pull request: https://github.com/apache/couchdb-fabric/pull/11 Respect conflicts=true when collecting clustered changes This looks to be a relatively straightforward fix. Previously we attempted to look for a conflicts property in Options which

[GitHub] couchdb-fabric pull request: Respect doc_options during _changes s...

2015-02-02 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-fabric/pull/12 Respect doc_options during _changes serialization When including full documents in the changes feed response, respect doc_options (e.g. attachments=true) during JSON serialization

[GitHub] couchdb-chttpd pull request: Parse attachment-related parameters f...

2015-02-02 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-chttpd/pull/23 Parse attachment-related parameters for /_changes Match the way that couch_httpd_db:parse_changes_query handles attachment related query parameters. COUCHDB-2522 You can

[GitHub] couchdb-fabric pull request: Respect conflicts=true when collectin...

2015-02-02 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-fabric/pull/11 Respect conflicts=true when collecting clustered changes This looks to be a relatively straightforward fix. Previously we attempted to look for a conflicts property in Options which

[GitHub] couchdb-fabric pull request: Handle empty list of id/revs in fabri...

2015-01-31 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-fabric/pull/10#issuecomment-72334792 @kxepal thanks. I moved the fix to fabric_doc_missing_revs:go (similar to https://github.com/apache/couchdb-fabric/blob/master/src/fabric_doc_update.erl#L21

[GitHub] couchdb-fabric pull request: Handle empty list of id/revs in fabri...

2015-01-31 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-fabric/pull/10 Handle empty list of id/revs in fabric:get_missing_revs fabric_doc_missing_revs:go doesn't handle the case when AllIdsRevs is an empty list (resulting in a timeout). Given

[GitHub] couchdb-chttpd pull request: Enable POST requests to /_changes in ...

2015-01-31 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-chttpd/pull/22 Enable POST requests to /_changes in clustered CouchDB Appropriate handling of a POST to _changes is already in place in single node CouchDB. In clustered CouchDB, allow POST requests

[GitHub] couchdb-chttpd pull request: Enable POST requests to /_changes in ...

2015-01-31 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/22#issuecomment-72316917 @kxepal thanks - addressed both points in the latest push --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-chttpd pull request: validate _all_docs query parameters

2015-01-29 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-chttpd/pull/19 validate _all_docs query parameters Perform the same query parameter validation in the clustered interface for /_all_docs requests as we do in the non-clustered interface. Fixes COUCHDB

[GitHub] couchdb-chttpd pull request: validate _all_docs query parameters

2015-01-29 Thread willholley
Github user willholley closed the pull request at: https://github.com/apache/couchdb-chttpd/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-chttpd pull request: Set view type before validating _all_...

2015-01-29 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb-chttpd/pull/20 Set view type before validating _all_docs parameters Matching couch_mrview, set view_type to map before validating query parameters for _all_docs. This fixes a bug whereby validation

[GitHub] couchdb pull request: Fauxton: fix fauxton query parameters for co...

2014-05-28 Thread willholley
Github user willholley closed the pull request at: https://github.com/apache/couchdb/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb pull request: Fauxton: fix fauxton query parameters for co...

2014-05-27 Thread willholley
Github user willholley commented on the pull request: https://github.com/apache/couchdb/pull/237#issuecomment-44365419 @robertkowalski Those comments / placeholders should not have slipped in - now fixed :) --- If your project is set up for it, you can reply to this email and have

[GitHub] couchdb pull request: Fauxton: fix fauxton query parameters for co...

2014-05-26 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb/pull/237 Fauxton: fix fauxton query parameters for complex keys (COUCHDB-2249) Fix URL generation in Fauxton when complex keys are specified as query parameters (COUCHDB-2249). This PR

[GitHub] couchdb pull request: Store the initial collection parameters to a...

2014-03-07 Thread willholley
GitHub user willholley opened a pull request: https://github.com/apache/couchdb/pull/168 Store the initial collection parameters to allow a safe reset to the first page (COUCHDB-2187) When adjusting page size, the desired behaviour is to navigate back to the first page