Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-23 Thread via GitHub
rzo1 commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1575690967 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-22 Thread via GitHub
rzo1 commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1575258821 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-22 Thread via GitHub
ffang commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1574802910 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-20 Thread via GitHub
rzo1 commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1573294891 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
ffang commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572923309 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
rzo1 closed pull request #1822: Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x URL: https://github.com/apache/cxf/pull/1822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
rzo1 commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572898811 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
ffang commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572882731 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
ffang commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572581658 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
rzo1 commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572491679 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
reta commented on code in PR #1822: URL: https://github.com/apache/cxf/pull/1822#discussion_r1572368151 ## rt/transports/http/src/main/java/org/apache/cxf/transport/http/AbstractHTTPDestination.java: ## @@ -410,8 +410,12 @@ private boolean

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
ffang commented on PR #1822: URL: https://github.com/apache/cxf/pull/1822#issuecomment-2066538612 Hi @rzo1 , Yes, this change is caused by Jetty12 upgrade. And it's good that we just catch NPE from jetty other than more generic exceptions. Thanks for reporting and fixing this!

Re: [PR] Exception for getUserPrincipal() in AbstractHTTPDestination is slurped since CXF 4.1.x [cxf]

2024-04-19 Thread via GitHub
rzo1 commented on PR #1822: URL: https://github.com/apache/cxf/pull/1822#issuecomment-2066319454 Ok from what I can read in the commit history, it seems, it was introduced because of jetty 12? The underlying exception (reason for failing GH actions) is a NPE in Jetty: ```